From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#29866: 27.0.50; cl-loop: Calculate the array length just once Date: Tue, 05 May 2020 22:21:36 -0400 Message-ID: <877dxpn6q7.fsf@gmail.com> References: <87wp18179m.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="61831"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.91 (gnu/linux) Cc: 29866@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 06 04:23:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jW9iK-000Fyx-Ir for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 May 2020 04:23:12 +0200 Original-Received: from localhost ([::1]:40340 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jW9iJ-0003in-Jp for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 May 2020 22:23:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jW9iA-0003i4-BD for bug-gnu-emacs@gnu.org; Tue, 05 May 2020 22:23:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54703) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jW9iA-0002nk-2A for bug-gnu-emacs@gnu.org; Tue, 05 May 2020 22:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jW9i9-0000RV-SN for bug-gnu-emacs@gnu.org; Tue, 05 May 2020 22:23:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 May 2020 02:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29866 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 29866-submit@debbugs.gnu.org id=B29866.15887317321640 (code B ref 29866); Wed, 06 May 2020 02:23:01 +0000 Original-Received: (at 29866) by debbugs.gnu.org; 6 May 2020 02:22:12 +0000 Original-Received: from localhost ([127.0.0.1]:38016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jW9hI-0000QE-Oz for submit@debbugs.gnu.org; Tue, 05 May 2020 22:22:12 -0400 Original-Received: from mail-qv1-f53.google.com ([209.85.219.53]:37389) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jW9hH-0000Px-Nm; Tue, 05 May 2020 22:22:08 -0400 Original-Received: by mail-qv1-f53.google.com with SMTP id y19so28041qvv.4; Tue, 05 May 2020 19:22:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=LMMxGI7cdkdN87jp2nm4AMg6kslLTVf0rot+Dds9d3k=; b=knAAsvZnTd42Z1GFVtaD1/JFlpwdLXzyYDOJ9aNjJforNH2kDnFPakdKdL84o8EwaV oQ7s78+0EVDpw/kU54KBmle90XBw4a/+RW6qxFygo87L2cwfNeHrqF5LDkwVXP3M72sy Ihz9W/xYBm+8yuCXZvqx6qXlu5sklXU3gqzt+XfUW77ntYxTotZ9g0/F/LdJNHbOKWvX cNZVE/4cU83j8hUJfqYqHHCxDkPMtBxJZ1qvDgSaKBfhJlOD+C3aq6UjSWijyhUEUW3H id5QS1NYt9k3LlwTBHNrmE0B3WcybAuuf1V5dX4M8hrHP2nywKpTc4jjKTQivBxwKoGC 1qQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=LMMxGI7cdkdN87jp2nm4AMg6kslLTVf0rot+Dds9d3k=; b=m9ghF+KdtHcxEG6ta5ygmRLUP6WVIAJhN5ZKa/PorWb9gIPa5o0Nnkz5Z8sP1QsLX9 eGDqNIYCNA+z+fqocQPWEjlAT19u9g9kGfpgv27LFCb4S2qXDofu/9s61I+gW65O2prX yZLQaUnpiTB514w+CmZiuULdxCSJ3lH8R3dw/t3HJLYGeHGhmhO71G6+meLE1ffO+8Y6 Rm1HgAdYaQtpkblZsesfrKTg4jIk3Tcytb7I8yg1GDZ7HZV1PMVeBzzPoi33sJAnc7qg 8fKip9ObyYl8VT8cjioHpKm1vMFrP2qwIVBjrnSNBtdJmwTuJAXqkD/URC0qLNY/Php8 C2kQ== X-Gm-Message-State: AGi0PuYpeR/FLOpESkLGVOZ3t3pMVugJr/m1Y7vjGhqIbD4fsIKpMUph 7DjT4zodFwqws96LhtRTOwyAl73a X-Google-Smtp-Source: APiQypJis3FaH/KuGRFWalQxGsUgftwFMFr2b7f9d9BTHpmYAe+4XS9HjFHXO4ola2kxvGn2ZJeCqg== X-Received: by 2002:ad4:4c92:: with SMTP id bs18mr5898782qvb.67.1588731722040; Tue, 05 May 2020 19:22:02 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-47.yyz.frontiernetworks.ca. [45.2.119.47]) by smtp.gmail.com with ESMTPSA id c23sm614303qka.12.2020.05.05.19.21.51 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 May 2020 19:22:01 -0700 (PDT) In-Reply-To: <87wp18179m.fsf@gmail.com> (Tino Calancha's message of "Thu, 28 Dec 2017 01:10:29 +0900") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179783 Archived-At: tags 29866 - patch tags 29866 + wontfix quit Tino Calancha writes: > (let ((temp-vec (make-symbol "--cl-vec--")) > + (temp-len (make-symbol "--cl-len--")) > (temp-idx (make-symbol "--cl-idx--"))) > (push (list temp-vec (pop cl--loop-args)) loop-for-bindings) > + (push (list temp-len `(length ,temp-vec)) loop-for-bindings) > (push (list temp-idx -1) loop-for-bindings) I reverted this because it breaks with 'and' because the bindings are made with 'let' rather than 'let*' (see Bug#40727). I'm marking wontfix because I don't intend to anything more about it, but I wouldn't oppose another attempt that didn't have this problem (I think it would require extensive code changes though).