From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#41338: Toolbar-bug in Emacs 27.0.91/Pretest Date: Sun, 17 May 2020 01:55:06 +0300 Organization: LINKOV.NET Message-ID: <877dxb4hzh.fsf@mail.linkov.net> References: <87ftbzva1f.fsf@rub.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="31049"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 41338@debbugs.gnu.org, Konrad Podczeck To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 17 01:25:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ja6B7-0007yq-DB for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 May 2020 01:25:13 +0200 Original-Received: from localhost ([::1]:55744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ja6B6-0006x8-DI for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 May 2020 19:25:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51718) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ja6Ax-0006ui-Gu for bug-gnu-emacs@gnu.org; Sat, 16 May 2020 19:25:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58605) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ja6Ax-0001AB-8A for bug-gnu-emacs@gnu.org; Sat, 16 May 2020 19:25:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ja6Ax-00012S-5H for bug-gnu-emacs@gnu.org; Sat, 16 May 2020 19:25:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 May 2020 23:25:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41338 X-GNU-PR-Package: emacs Original-Received: via spool by 41338-submit@debbugs.gnu.org id=B41338.15896714893911 (code B ref 41338); Sat, 16 May 2020 23:25:03 +0000 Original-Received: (at 41338) by debbugs.gnu.org; 16 May 2020 23:24:49 +0000 Original-Received: from localhost ([127.0.0.1]:41906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ja6Aj-000110-JM for submit@debbugs.gnu.org; Sat, 16 May 2020 19:24:49 -0400 Original-Received: from relay5-d.mail.gandi.net ([217.70.183.197]:55873) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ja6Ah-00010j-8v for 41338@debbugs.gnu.org; Sat, 16 May 2020 19:24:48 -0400 X-Originating-IP: 91.129.104.245 Original-Received: from mail.gandi.net (m91-129-104-245.cust.tele2.ee [91.129.104.245]) (Authenticated sender: juri@linkov.net) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id BAE141C0003; Sat, 16 May 2020 23:24:39 +0000 (UTC) In-Reply-To: <87ftbzva1f.fsf@rub.de> (Stephen Berman's message of "Sat, 16 May 2020 23:34:36 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180414 Archived-At: >> To reproduce: >> >> (1) Start Emacs (without any customizations). >> >> (2) Open a file which has the standard toolbar, say mouse.el >> >> (3) Do C-x m, to open a message buffer; this buffer has a toolbar _different_ >> from the standard one. >> >> (4) Do C-x 5 2, to get the message buffer shown in a second frame. >> >> (5) In the first frame, make the buffer showing mouse.el active again. >> >> (6) In that buffer, do C-s, to invoke isearch and search for some word. >> >> (7) Using the mouse, close the frame showing mouse.el, but do so in a state >> where still isearch overlays show up. >> >> (8) Now click with mouse-1 in the remaining frame, i.e., in that showing the >> message buffer, and the toolbar changes to the standard one. >> >> I consider this as a bug. In case it is not platform independent, I us an NS-build. > > I see this too, on GNU/Linux (both in 27.0.91 and a recent build from > master). Moreover, if in the remaining frame I switch from the message > buffer to the buffer in which isearch was invoked, the tool bar is now > the isearch tool bar and the mode line has the "Isearch" lighter, but > there are no isearch overlays and point is where it was before invoking > isearch. This seems surprising. But now typing C-s restores the > isearch state the buffer had (i.e. the same overlays) before closing the > other frame. isearch-mode-map has such bindings: ;; Pass frame events transparently so they won't exit the search. ;; In particular, if we have more than one display open, then a ;; switch-frame might be generated by someone typing at another keyboard. (define-key map [switch-frame] nil) (define-key map [delete-frame] nil) and indeed the ‘switch-frame’ event is fired when the frame is switched during isearch, and it exits isearch. But I don't know why the ‘delete-frame’ event is not fired on frame deletion. Perhaps isearch.el should explicitly use the hook ‘delete-frame-functions’ to exit isearch.