From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#24940: [PATCH] Add should-call, should-not-call, and their tests Date: Tue, 11 Aug 2020 15:23:18 +0200 Message-ID: <877du5wc3d.fsf@gnus.org> References: <8337iuhxgu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9922"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 24940@debbugs.gnu.org To: Gemini Lasswell Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 11 15:24:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5UGA-0002SH-Cz for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Aug 2020 15:24:10 +0200 Original-Received: from localhost ([::1]:50560 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5UG9-0002Kx-A6 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Aug 2020 09:24:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50656) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5UG2-0002KY-TY for bug-gnu-emacs@gnu.org; Tue, 11 Aug 2020 09:24:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55637) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k5UG2-0003QX-KM for bug-gnu-emacs@gnu.org; Tue, 11 Aug 2020 09:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k5UG2-00054g-GB for bug-gnu-emacs@gnu.org; Tue, 11 Aug 2020 09:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Aug 2020 13:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24940 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24940-submit@debbugs.gnu.org id=B24940.159715221319453 (code B ref 24940); Tue, 11 Aug 2020 13:24:02 +0000 Original-Received: (at 24940) by debbugs.gnu.org; 11 Aug 2020 13:23:33 +0000 Original-Received: from localhost ([127.0.0.1]:38947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5UFZ-00053g-Hm for submit@debbugs.gnu.org; Tue, 11 Aug 2020 09:23:33 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:60196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5UFX-00053O-SR for 24940@debbugs.gnu.org; Tue, 11 Aug 2020 09:23:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5Jo/GDcoHMVbla65w5gRNzP8LYeUpX1DAGS7R46V6RA=; b=f/UNYdmxUeyXIoW/Bu3oF1GmXY 6DIryiJbt+s1daxsd3g57MX61Ln82XPgkf8gFBrs+nSPtAtbpbXbg7qs4eKRqO4I9U+WpZWTt38R9 /sZxLfqUHEX6Ex5LrmV26QdtAFRAGXiNDqaZxZEX1YzZ6VZ3lPaZwkS9FzF4bRSONE+0=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5UFM-0003d8-8c; Tue, 11 Aug 2020 15:23:25 +0200 In-Reply-To: (Gemini Lasswell's message of "Mon, 14 Nov 2016 21:52:23 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184646 Archived-At: Gemini Lasswell writes: >> I don't think our test suite should in general test whether some >> functions are or aren't called during execution of the >> command/function under test. That's because we are not interested in >> the fine details of the implementation of the features being tested, >> we are interested in whether it does what it's supposed to do. "What >> it's supposed to do" means we should test the return values and the >> side effects, a.k.a. "the behavior", and not how the code works >> internally. > > I'll modify the tests I've written to focus on "the behavior". Gemini, this was apparently never done? Did you abandon this patch in favour of Phillip's assess package? (Which I see is in Melpa now.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no