From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#43714: 28.1: auto-revert code improvements [PATCH] Date: Wed, 30 Sep 2020 15:48:05 +0200 Message-ID: <877dsb74ve.fsf@gnus.org> References: <20200930062633.n3ntw2lmmantsx47@E15-2016.optimum.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13640"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 43714@debbugs.gnu.org To: Boruch Baum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 30 16:06:44 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNckl-0003R1-Ht for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Sep 2020 16:06:43 +0200 Original-Received: from localhost ([::1]:50594 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kNckk-0001RH-KZ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Sep 2020 10:06:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40350) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kNcTf-0005mb-Jv for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 09:49:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47126) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kNcTe-0006IH-Vj for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 09:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kNcTe-0000Jc-SU for bug-gnu-emacs@gnu.org; Wed, 30 Sep 2020 09:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Sep 2020 13:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43714 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 43714-submit@debbugs.gnu.org id=B43714.16014737131148 (code B ref 43714); Wed, 30 Sep 2020 13:49:02 +0000 Original-Received: (at 43714) by debbugs.gnu.org; 30 Sep 2020 13:48:33 +0000 Original-Received: from localhost ([127.0.0.1]:58668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNcT3-0000II-JI for submit@debbugs.gnu.org; Wed, 30 Sep 2020 09:48:33 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:45332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kNcT0-0000I3-Ty for 43714@debbugs.gnu.org; Wed, 30 Sep 2020 09:48:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=AglaYntiMpJ9aCQY0qLYYrcrNHfn1pfXHkyd51c/fYU=; b=Jy0gRCtCzkxFyO/kGu1xchr0KR zMutBvfFMtuMaU7xXC9twMxptrmhvbd4eGRV9VptJzceA9i2p9Ykq73epwqYpFcMrxTDSkJFHZbNk ccAKZOa0OPNISWONqTE+HdOgQJpXEQzgGYH+IQpX6vgGnzmNxsUtstznvDiVo7ywZ1c4=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kNcSk-00023y-La; Wed, 30 Sep 2020 15:48:16 +0200 X-Now-Playing: So's _So_: "f" In-Reply-To: <20200930062633.n3ntw2lmmantsx47@E15-2016.optimum.net> (Boruch Baum's message of "Wed, 30 Sep 2020 02:26:33 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:189337 Archived-At: Boruch Baum writes: > Just as a 'for example': I started on this because I saw that the code > was saving match data, which had me on a wild goose chase hunting for > why and where it was necessary - I found nothing, and removing the code > doesn't seem to have ill effect. That's really hard to tell, though -- the reason for saving the match data may be in hard-to-trigger circumstances, and the saving was introduced in a commit of its own, so I'm guessing there was some specific reason for it. The commit message is super-helpful here: commit 33512cbeb168764f83f5a740090ce40b4b948591 Author: Luc Teirlinck AuthorDate: Wed Jun 1 20:51:03 2005 +0000 (auto-revert-buffers): Use save-match-data. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no