From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#44068: 28.0.50; Faulty uses of tabulated-list-format Date: Mon, 19 Oct 2020 20:20:16 +0200 Message-ID: <877drm13j3.fsf@gmx.net> References: <87imb7e242.fsf@gmx.net> <83zh4ipbli.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25303"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 44068@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 19 20:21:32 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kUZml-0006Rl-JM for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Oct 2020 20:21:31 +0200 Original-Received: from localhost ([::1]:53844 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kUZmk-0000uR-Hz for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Oct 2020 14:21:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60142) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kUZmI-0000nl-DC for bug-gnu-emacs@gnu.org; Mon, 19 Oct 2020 14:21:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59000) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kUZmI-0003Xj-41 for bug-gnu-emacs@gnu.org; Mon, 19 Oct 2020 14:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kUZmH-0004xs-Uq for bug-gnu-emacs@gnu.org; Mon, 19 Oct 2020 14:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Oct 2020 18:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44068 X-GNU-PR-Package: emacs Original-Received: via spool by 44068-submit@debbugs.gnu.org id=B44068.160313163119038 (code B ref 44068); Mon, 19 Oct 2020 18:21:01 +0000 Original-Received: (at 44068) by debbugs.gnu.org; 19 Oct 2020 18:20:31 +0000 Original-Received: from localhost ([127.0.0.1]:42313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUZln-0004wz-7k for submit@debbugs.gnu.org; Mon, 19 Oct 2020 14:20:31 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:43221) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kUZlm-0004wm-5H for 44068@debbugs.gnu.org; Mon, 19 Oct 2020 14:20:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1603131623; bh=snjJfF6JBdn2EpTbgoxYGNWQ6XWGFpv2RATNFa0SGq4=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=V6F9X+HSDDs+YuBZq/66ctptsOax3rZRJDLqNHJmmaVLfGF1n2bJ5Y33Z2c+a04kN Gfr0F+dsKKCednGRg7ZjCALvwMPla8URQA2qL4vyR2KL4NXy+9LlNJY5b+8xTxueYb TBAD79yOmDcanXNTXzczs2lAFzLJuhMr59u91Jxw= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from strobe-jhalfs ([188.101.169.69]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MCKFu-1kdxga44LS-009PwY; Mon, 19 Oct 2020 20:20:23 +0200 In-Reply-To: <83zh4ipbli.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 19 Oct 2020 16:52:09 +0300") X-Provags-ID: V03:K1:Yf8C7QtEviCJIIGAfCXmlB7lrfxiS8IAZQtbQrHJd/+LOBThQHJ voaxtWvS7cQGeCDFqcdJsB+n0dc7fITaL5fUi+DxrSI4P2fpuZZP4rKYd6B68OGtrJWW+oz iqKhUlCoJINnpahboLsIDoSdZNY5X1z2zMJ6XFBo7TAzU3rEP5BuliAQGK801XrUPtdXzIK lZggMn9UQ8Fi9b2m84zhw== X-UI-Out-Filterresults: notjunk:1;V03:K0:vXAS+GnMljI=:RT9vR5OtGGpa1pdSuX0Vb2 9DI1TVHUifmFhI5pnxYwDlgv/HW/R1Wa9KxnBi2l6lE5Yfb40qc+kacljFO0cVZ0yJl5kbZYa NGogdC5ISa3Q5O69/ghThq/jEfzEFni2ZwyIZ3E3tn1YzUoqCLbBp1bongCM5sIOiu19W0DYp EJE2wtLuAH8N2BKj8aaeRiPi8sPHhimjur92WntHa/Op3DLNtzphbGHsBC0hbFBEs6LB8kxVQ yOPKFTcUrXQWn2gOy/MOt3oRwLaAye+ng+E6bSPNL7kCaqoFOLw+ywh7+zYnrZR/45HAxqvvJ SuevYGKKdRuT99RvIjJa60SiO3vcCSgG8fEFwRf2b3yGZMUXv5jpwuya7rERDk7Ik+uYOOGCm IF1u819dDMMIjwx+9O2DPuuKsVWvQVd7PLPyNovLu2HO5v6cLmzTOHCWE/Be4pWEadskaXD4H AGNSmL0w1Q/QudXTMicIEimdJjvCa/ZkOWjhJccrPCY/Itx5fDqiNpJKdk3q2CUEuVtBZJR0x SOWPlP5+ebzea6ATj6bSmOUkNlxFlCFne7ylnQ449/RdmtJwS1Dr3LYmkuMIMk0/QqrgWZyHY tnO8ZJx58D/pKBVa7vMdFD2dtO/a7Nqw+0dVSw2JWm4/xgX6fPT6/7lVkbKi/HYB0wzMbim98 aJtC189dlM6mpybq7bi6i4eBWHWQT0SlUaYb3EbggkniXda64HBFwwc59NebfgEWbDdJQl/8F 5JCpyfoie2kyHYCSTezvc25PH9RQJium4M/3i8G9QcAHbPEu6Dg8nVDP4AZqs6rwZyekvjrP X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:191023 Archived-At: On Mon, 19 Oct 2020 16:52:09 +0300 Eli Zaretskii wrote: >> From: Stephen Berman >> Date: Sun, 18 Oct 2020 22:00:13 +0200 >>=20 >> On trying out the new tabulated-list implementation of the bookmarks >> list I noticed that, when clicking on the File header, the sort >> indicator is not displayed, unlike with the Bookmark header. Then I >> noticed that the same thing happens in the tabulated buffer list (C-x >> C-b). Then I grepped for all uses of tabulated-list-format in the Emacs >> sources and found the same problem in most of them. The reason is that >> in these modes the width of at least one of the columns is too narrow, >> so that tabulated-list-init-header omits the indicator. In most cases >> the problematic column is the final one, but in a couple of cases there >> are also non-final too narrow columns. And I think these bugs are due >> to a misleading description in tabulated-list-format's doc string. The >> attached patch corrects the doc string and the problematic uses of >> tabulated-list-format. The patch also fixes a typo and tries to improve >> column alignment in timer-list-mode: this is one of the few modes >> derived from tabulated-list-mode whose column widths didn't need to be >> corrected, but the alignment seemed suboptimal; however, when the header >> line uses a variable-pitch face, the alignment is still suboptimal even >> with the patch, and I don't know how to fix that. > > Instead of manually fine-tuning each column's width, wouldn't it be > better to use the string-trim capabilities that replace excess > characters with an ellipsis? I'm not sure I understand your suggestion. If you mean to truncate the column label in the header line when displaying the sort indicator, e.g. change "Status" to "Sta=E2=80=A6 =E2=96=BC", I'm dubious it's worth th= e effort, since most of the problematic cases in the Emacs sources are with the final column, where there's always enough space, but due to the misleading description in tabulated-list-format's doc string, many modes have made it unnecessarily narrow, preventing the display of the sort indicator. So to avoid the final column being labelled e.g. either "File" or "Fi=E2=80=A6 =E2=96=BC" instead of "File =E2=96=BC", it is necess= ary to change the width manually anyway. In other words, the truncation proposal would be an addition to manual fine-tuning (for non-final columns), not a substitute for it. Or did you mean something else? Steve Berman