From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Ryan C. Thompson" <rct@thompsonclan.org>
Cc: 19412@debbugs.gnu.org, Stefan Kangas <stefan@marxist.se>
Subject: bug#19412: 24.3; ido-write-file sometimes writes to a different directory than, it says it will
Date: Mon, 11 Jan 2021 15:14:50 +0100 [thread overview]
Message-ID: <877dojimqt.fsf@gnus.org> (raw)
In-Reply-To: <1f98bdf5-2da4-10b6-57f0-bdc0964a6df9@thompsonclan.org> (Ryan C. Thompson's message of "Sun, 10 Jan 2021 18:12:20 -0500")
"Ryan C. Thompson" <rct@thompsonclan.org> writes:
> It's been a while, but I've fixed up my patch and given it some
> testing, and it seems to work on for me. However, in the meantime,
> this issue has recently been "fixed" by special-casing write-file in
> ido.el, as seen in #28513. So if you want to install my patch now,
> you'll need to install the version attached to that thread. That
> version reverts the other fix, since of course they are not
> compatible, and would be redundant even if they were.
It looks like a more thorough fix. However:
+ (minibuffer-with-setup-hook
+ (:append
+ (lambda ()
+ ;; Clear out whatever started in the minibuffer and
+ ;; replace it with what the user had already entered
+ ;; into ido.
+ (delete-minibuffer-contents)
+ (insert (abbreviate-file-name ido-current-directory))))
+ (call-interactively this-command))))
I'd be worried that this would step on other modifications the user may
be doing from the minibuffer setup.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-01-11 14:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-19 20:21 bug#19412: 24.3; ido-write-file sometimes writes to a different directory than it says it will Don Morrison
2019-11-03 22:48 ` bug#19412: 24.3; ido-write-file sometimes writes to a different directory than, " Ryan C. Thompson
2019-11-04 14:52 ` Ryan C. Thompson
2019-11-04 15:55 ` Ryan C. Thompson
2020-03-11 16:46 ` Ryan C. Thompson
2020-08-12 16:44 ` Stefan Kangas
2021-01-10 23:12 ` Ryan C. Thompson
2021-01-11 14:14 ` Lars Ingebrigtsen [this message]
2021-01-11 14:28 ` Ryan C. Thompson
2021-01-11 18:43 ` Lars Ingebrigtsen
2021-01-11 18:50 ` Ryan C. Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dojimqt.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=19412@debbugs.gnu.org \
--cc=rct@thompsonclan.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).