From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#46574: cperl-mode: Improve detection of entries for imenu [PATCH] Date: Wed, 17 Feb 2021 00:03:12 +0100 Message-ID: <877dn7r4y7.fsf@gnus.org> References: <871rdffwtr.fsf@hajtower> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5426"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 46574@debbugs.gnu.org To: haj@posteo.de (Harald =?UTF-8?Q?J=C3=B6rg?=) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 17 00:04:25 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lC9OK-0001Ih-PY for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Feb 2021 00:04:24 +0100 Original-Received: from localhost ([::1]:53496 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lC9OJ-0005QL-Rc for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 Feb 2021 18:04:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44212) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lC9Ny-0005Q9-1J for bug-gnu-emacs@gnu.org; Tue, 16 Feb 2021 18:04:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58634) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lC9Nx-00078A-QI for bug-gnu-emacs@gnu.org; Tue, 16 Feb 2021 18:04:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lC9Nx-0005C1-Mi for bug-gnu-emacs@gnu.org; Tue, 16 Feb 2021 18:04:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Feb 2021 23:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46574 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46574-submit@debbugs.gnu.org id=B46574.161351660519907 (code B ref 46574); Tue, 16 Feb 2021 23:04:01 +0000 Original-Received: (at 46574) by debbugs.gnu.org; 16 Feb 2021 23:03:25 +0000 Original-Received: from localhost ([127.0.0.1]:41947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lC9NM-0005B0-NX for submit@debbugs.gnu.org; Tue, 16 Feb 2021 18:03:24 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:57736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lC9NK-0005Ao-TQ for 46574@debbugs.gnu.org; Tue, 16 Feb 2021 18:03:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=xTXW5dsVYjY2apaFe4U9yzEXHFDpM/TtUiHXXsLXczs=; b=nccAn6xR2KIthADkW/XgIh6lnz JSjHOt+6h+PWVa57F0ssXCPTbTC2+Vxa/LIKRk9K8IMw4xDyFgrbteHh6jcuOQT8l0eNargMxqk8g eVMLXLs/WBu2vm9VXLWaQEy07BOZ8QkU7huL0unjwK5uxuoQ8m89I5fEE34oZ3ho0kwY=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lC9NC-0001Oq-2d; Wed, 17 Feb 2021 00:03:16 +0100 X-Now-Playing: Stephen Mallinder's _The Wire Tapper 51_: "Um Dada [SM edit 5" In-Reply-To: <871rdffwtr.fsf@hajtower> ("Harald =?UTF-8?Q?J=C3=B6rg?="'s message of "Tue, 16 Feb 2021 23:54:08 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200169 Archived-At: haj@posteo.de (Harald J=C3=B6rg) writes: > This patch helps CPerl mode to detect various declarations which should > go into the imenu index but were missed, and also prevents some false > positives from being included. Undetected package declarations also led > to wrong namespace attributions for subroutines declared within those > packages. I've only skimmed the patch, but it makes sense to me. When applying it, though, patch said: patching file lisp/progmodes/cperl-mode.el Hunk #2 succeeded at 1210 (offset -41 lines). Hunk #3 succeeded at 1367 (offset -41 lines). Hunk #4 succeeded at 5286 (offset -41 lines). Hunk #5 succeeded at 5368 (offset -41 lines). Hunk #6 succeeded at 5403 (offset -41 lines). Hunk #7 succeeded at 6734 (offset -41 lines). Which is odd. Could you check whether the patch is against the current Emacs trunk? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no