From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#47699: [PATCH] Improve completion-list-mode-map Date: Tue, 25 May 2021 13:31:19 +0100 Message-ID: <877djnuh9k.fsf@tcd.ie> References: <3755fe92dcbf588701ae@heytings.org> <83o8el46rs.fsf@gnu.org> <3755fe92dc6b58671717@heytings.org> <83k0p944s5.fsf@gnu.org> <3755fe92dc4a9ba66a0b@heytings.org> <83im4t43ul.fsf@gnu.org> <3755fe92dc626b55646c@heytings.org> <83eefh3y0r.fsf@gnu.org> <3755fe92dc6a74421fa9@heytings.org> <83czv13q3l.fsf@gnu.org> <3755fe92dc3b94023c91@heytings.org> <877djn77gm.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="833"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Gregory Heytings , 47699@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 25 14:32:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llWEH-000AXT-GA for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 May 2021 14:32:13 +0200 Original-Received: from localhost ([::1]:58870 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1llWEG-0002R4-IU for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 May 2021 08:32:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46362) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1llWE6-0002PJ-VF for bug-gnu-emacs@gnu.org; Tue, 25 May 2021 08:32:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33362) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1llWE6-000270-4s for bug-gnu-emacs@gnu.org; Tue, 25 May 2021 08:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1llWE6-0004yk-0n for bug-gnu-emacs@gnu.org; Tue, 25 May 2021 08:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 May 2021 12:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47699 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 47699-submit@debbugs.gnu.org id=B47699.162194589219087 (code B ref 47699); Tue, 25 May 2021 12:32:01 +0000 Original-Received: (at 47699) by debbugs.gnu.org; 25 May 2021 12:31:32 +0000 Original-Received: from localhost ([127.0.0.1]:44905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llWDc-0004xn-2I for submit@debbugs.gnu.org; Tue, 25 May 2021 08:31:32 -0400 Original-Received: from mail-wr1-f52.google.com ([209.85.221.52]:37498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1llWDZ-0004xZ-34 for 47699@debbugs.gnu.org; Tue, 25 May 2021 08:31:30 -0400 Original-Received: by mail-wr1-f52.google.com with SMTP id q5so32025855wrs.4 for <47699@debbugs.gnu.org>; Tue, 25 May 2021 05:31:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=hUXSznfYvJtMAyNANXZaDChgNExvQ3TaGEqAdpvq1n8=; b=BRwSPiJbFkGXkvuc1RZ+6G5XxIws5QOvlvgoPAzDN4dkP4OxcvoKgtZ0lff+rNK2Hs U3u+9UrEFtgOA7bVyi6NbdDjLDqPAkYoBbfHc1YQJfWEnrN674f7w0HqmJYN4xbucR37 pN4ewOwu10PjDMAqlPMgjEgPP6eGptDNDVzXh/aW1CJPO55LeaWt2Ig1vuFR5UQ7r9WC AqXKcdFdwMn4ObYp7EUyg3R71TGSScNsv9oF8/avixY65iaPX4gsyM3kCJtAr8/8czOF DTxa6eaNK+y5iLXJoWaSP5zu7HRyEbaplXpUX+/Ot67v4HkidjIgluV2BPLV7ooIyw2D jDvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=hUXSznfYvJtMAyNANXZaDChgNExvQ3TaGEqAdpvq1n8=; b=Ne2b3h7kDoXph3KTG6fz2hm70CotEjqejM9P0i+o2+khURxORRS6OimjXIVc5ZaiC5 hXgCVyWDZyd0KDRAht6imPzU0+9sNBB8FiadF5guGE5HBq9BlscoHiEyMTVnXYLqF128 msP4DFZLinC61A44Sdh/xN1ss7puStuKQi/dMwSIrf2xPxNwHLkBs/FD+b1SrrMGFiIC 7qZ6TBdt0U1PrO6ef+PmS8EgTnNJo2v2ZYIC6B19KjG0CmMteyVJ3H1OMpVry++jK++o sjEi36TWLNvGaOXpRrSU+CGC5K0uTtseYrzqqz3eY64YwoBGAnbeSyaNJpZlGlQPMRTR re3Q== X-Gm-Message-State: AOAM530Fiid4aPcSUGdTdkOT6DOMjUWkQPu6ubk5MSHV04VPbi3+tR8u eEkDfyEdzVaVvcNSOv3BHOq6Vg== X-Google-Smtp-Source: ABdhPJzcl9/Y/WUzEI364ArTOEZDNK2gsgEiTyDH6tIb2uuNLdzzLlYp2JSBfV0IbITF0auACiUY0Q== X-Received: by 2002:a05:6000:1c2:: with SMTP id t2mr26606052wrx.424.1621945883118; Tue, 25 May 2021 05:31:23 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:f410:82e8:3a21:eedf]) by smtp.gmail.com with ESMTPSA id s83sm10944992wms.16.2021.05.25.05.31.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 May 2021 05:31:22 -0700 (PDT) In-Reply-To: <877djn77gm.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 25 May 2021 06:39:21 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207198 Archived-At: Lars Ingebrigtsen writes: > Gregory Heytings writes: > >> Thanks. Here is the updated patch. I tested it with minibuffer-only >> frames, and it seems to work. >> >> Are you sure that it's okay to rebind M-c in >> minibuffer-local-completion-map? It's a good mnemonic for >> "completion", but it hides the capitalize-word binding, that users >> might possibly want to use there (I don't, it's only when thinking >> about this patch that I realized this). >> >> Another option would be M-g, which would not hide anything that is >> possibly useful in the minibuffer, and is still a mnemonic of "goto". > > Thanks; applied to Emacs 28. Thanks, but test/lisp/help-tests.el also needs updating: Test help-tests-substitute-command-keys/keymaps condition: (ert-test-failed ((should (equal (substitute-command-keys orig) result)) :form (equal #("key binding..." ...) "key binding...") :value nil :explanation (arrays-of-different-length 715 688 ... first-mismatch-at 495))) FAILED 16/24 help-tests-substitute-command-keys/keymaps (0.000349 sec) -- Basil