unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: "João Guerra" <joca.bt@gmail.com>
Cc: 48669@debbugs.gnu.org
Subject: bug#48669: Inconsistent overlay placement between minibuffer-message and set-minibuffer-message
Date: Mon, 31 May 2021 23:24:14 +0300	[thread overview]
Message-ID: <877djek6eh.fsf@mail.linkov.net> (raw)
In-Reply-To: <CAGiBfP2YnmQyLHsUqnLw9+RbhQ-tJoXf=VuZzd2+pJt5bLU2-w@mail.gmail.com> ("João Guerra"'s message of "Wed, 26 May 2021 14:50:20 +0200")

> `minibuffer-message' and `set-minibuffer-message' place the overlay
> containing the message slightly differently, resulting in a different
> behaviour when there are other overlays present at the end of the
> minibuffer.
>
> The overlay created by `minibuffer-message' always gets added to the
> end of the minibuffer.
> The overlay created by `set-minibuffer-message' also gets added to the
> end of the minibuffer, but its properties make it so that it is shown
> before other overlays at the position.
> This is particularly important when the user uses packages that add
> overlays to the minibuffer, such as vertical completion packages like
> selectrum, vertico, and others.
> The way `set-minibuffer-message' configures the overlays makes it so
> that the overlay is displayed before the other overlays, which I
> believe is more compatible with external packages (see attached image
> for a visual example).

To support completion packages such as icomplete, the overlay in
`set-minibuffer-message' was fixed, but not `minibuffer-message'.

> Would it make sense to change this behaviour (i.e. overlay
> configuration) so that it is consistent in both functions?

Right, `minibuffer-message' should be consistent with `set-minibuffer-message'
by copying this part:

        ;; Make sure the overlay with the message is displayed before
        ;; any other overlays in that position, in case they have
        ;; resize-mini-windows set to nil and the other overlay strings
        ;; are too long for the mini-window width.  This makes sure the
        ;; temporary message will always be visible.
        (overlay-put minibuffer-message-overlay 'priority 1100)





  reply	other threads:[~2021-05-31 20:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-26 12:50 bug#48669: Inconsistent overlay placement between minibuffer-message and set-minibuffer-message João Guerra
2021-05-31 20:24 ` Juri Linkov [this message]
2021-06-05 21:43 ` Juri Linkov
2021-06-06  5:58   ` Eli Zaretskii
2021-06-06 20:54     ` Juri Linkov
2021-06-07 12:21       ` Eli Zaretskii
2021-06-08 16:52         ` Juri Linkov
2021-06-08 18:12           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877djek6eh.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=48669@debbugs.gnu.org \
    --cc=joca.bt@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).