From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#46775: 27.1; ERC: Track: Modified channels doc and `erc-track-find-face' fixes Date: Wed, 09 Jun 2021 06:07:17 -0700 Message-ID: <877dj3xk3e.fsf__29607.6435291738$1623244097$gmane$org@neverwas.me> References: <3089116.bT80LyP3VS@ravel> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26783"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-erc@gnu.org, 46775@debbugs.gnu.org To: Olivier Certner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 09 15:08:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lqxwG-0006ll-Ov for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Jun 2021 15:08:08 +0200 Original-Received: from localhost ([::1]:37450 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqxwF-0001Hf-RJ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 09 Jun 2021 09:08:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52802) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqxwA-0001HX-DL for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2021 09:08:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49223) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lqxwA-00081Q-5X for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2021 09:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lqxwA-0002EN-1s for bug-gnu-emacs@gnu.org; Wed, 09 Jun 2021 09:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Jun 2021 13:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46775 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46775-submit@debbugs.gnu.org id=B46775.16232440488530 (code B ref 46775); Wed, 09 Jun 2021 13:08:02 +0000 Original-Received: (at 46775) by debbugs.gnu.org; 9 Jun 2021 13:07:28 +0000 Original-Received: from localhost ([127.0.0.1]:60769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqxvb-0002DU-Vb for submit@debbugs.gnu.org; Wed, 09 Jun 2021 09:07:28 -0400 Original-Received: from mail-109-mta143.mxroute.com ([136.175.109.143]:38475) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqxva-0002DH-MK for 46775@debbugs.gnu.org; Wed, 09 Jun 2021 09:07:27 -0400 Original-Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-109-mta143.mxroute.com (ZoneMTA) with ESMTPSA id 179f0e26696000774e.001 for <46775@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Wed, 09 Jun 2021 13:07:19 +0000 X-Zone-Loop: 9cc18d3a107a91ea601c14c59baeea153aa593ee6f05 X-Originating-IP: [149.28.56.236] In-Reply-To: <3089116.bT80LyP3VS@ravel> (Olivier Certner's message of "Thu, 25 Feb 2021 18:14:25 +0100") X-AuthUser: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208292 Archived-At: Olivier Certner writes: > Several small documentation changes and one minor fix. List of (separate) > changes: > 1. Fix documentation of `erc-modified-channels-alist' about its structure. > 2. Fix documentation of `erc-modified-channels-alist' about which channels it > contains and when. Add references to docstring of `erc-make-mode-line-buffer- > name'. The bit about the structure makes perfect sense, and the revised language is much clearer and easier to understand, at least to me. > 3. Rewrite `erc-track-find-face' to clarify what it does (& minor performance > improvement; no functional changes). The updates to the doc string here are likewise superb and make things crystal clear. Although sometimes, for drooling cretins like me, a unit test is worth a thousand words: way easier to take in the whole cause-and-effect of it all (push lever -> get pellet). Also, as a native EngRish speaker, I'm only 51% sure you meant s/necessary means/necessarily means/ in that last paragraph. In general though, I feel little optimizations like this are more than welcome because this stuff runs more or less constantly. > 4. `erc-track-modified-channels': Fix a perceived bug in the use of `erc- > track-find-face' (changes mode line faces selection in some cases). For this one, something like a detailed repro would be nice. But I suppose that's rather involved/tricky without fancier tooling. So I'll just take your word for it because (1) it sounds plausible and (2) you're way more familiar with this module than I. Regarding this module generally, it's definitely another one whose layout confuses me. For example, I guess we can't add keymaps to minor modes defined with `define-erc-module'? IOW, why the `erc-track-minor-mode-map' instead of a `erc-track-mode-map'? I'm also confused by the 001 RPL_WELCOME hook, but for now, I'll just assume it's a vestige of a simpler time when `erc-user-is-active' looked different and maybe did more. Or (more likely) there's something I'm not seeing just yet. Anyway, I mention this stuff because you may be the best/only qualified person to address such concerns at present. Would you be willing to audit this file for redundancy/cruft/obsolescence at some point before the next release? Thanks.