From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#41343: tab-bar-mode: Close tab on mouse-2 click Date: Wed, 04 Aug 2021 23:13:12 +0300 Organization: LINKOV.NET Message-ID: <877dh18lj3.fsf@mail.linkov.net> References: <87wnp2cg52.fsf@linkov.net> <83tuk5la2u.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6374"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: 41343@debbugs.gnu.org, stefankangas@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 04 22:32:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mBNYn-0001XL-Bn for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 Aug 2021 22:32:17 +0200 Original-Received: from localhost ([::1]:60440 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBNYm-0001w4-65 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 04 Aug 2021 16:32:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51918) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBNYZ-0001r4-1h for bug-gnu-emacs@gnu.org; Wed, 04 Aug 2021 16:32:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33704) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mBNYY-00049M-KD for bug-gnu-emacs@gnu.org; Wed, 04 Aug 2021 16:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mBNYY-0001JL-Eg for bug-gnu-emacs@gnu.org; Wed, 04 Aug 2021 16:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Aug 2021 20:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41343 X-GNU-PR-Package: emacs Original-Received: via spool by 41343-submit@debbugs.gnu.org id=B41343.16281090794978 (code B ref 41343); Wed, 04 Aug 2021 20:32:02 +0000 Original-Received: (at 41343) by debbugs.gnu.org; 4 Aug 2021 20:31:19 +0000 Original-Received: from localhost ([127.0.0.1]:45247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBNXr-0001IE-Em for submit@debbugs.gnu.org; Wed, 04 Aug 2021 16:31:19 -0400 Original-Received: from relay2-d.mail.gandi.net ([217.70.183.194]:36753) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mBNXp-0001Hn-MN for 41343@debbugs.gnu.org; Wed, 04 Aug 2021 16:31:17 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 7AB9C40008; Wed, 4 Aug 2021 20:31:10 +0000 (UTC) In-Reply-To: <83tuk5la2u.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 04 Aug 2021 14:32:09 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211185 Archived-At: >> > Please consider adding a binding to close a tab in tab-bar-mode by >> > clicking on it using the middle mouse button (mouse-2). >> >> Here's the patch that implements mouse-2 tab closing: > > Do we really have to hard-code the mouse button this way, including > explicit values in C? Why is that necessary or justified? In tab-line.el it was very easy to bind mouse-2 to close the tab: (defvar tab-line-tab-map (let ((map (make-sparse-keymap))) (define-key map [tab-line mouse-1] 'tab-line-select-tab) (define-key map [tab-line mouse-2] 'tab-line-close-tab) But it's impossible to do the same for the menu-bar and the tool-bar and so in the tab-bar too. There is no other way to bind mouse-2 to close the tab that would work in X, xterm, console, w32, w32term. Ot do you mean adding an integer variable that holds a number of the mouse button used to close the tab? For example, tab-bar-close-tab-mouse-button = 2.