From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#45934: native-comp - Dylib ID of ELN files not optimal Date: Sat, 07 Aug 2021 12:25:02 +0200 Message-ID: <877dgx8sch.fsf@gnus.org> References: <7D999BAF-3306-4625-B062-E4512363E584@yahoo.it> <87mtq4m16u.fsf@gnus.org> <87eeb9hf63.fsf@gnus.org> <87im0ki2lq.fsf@gnus.org> <877dgyc0fw.fsf@gnus.org> <87mtpt8tus.fsf@gnus.org> <87im0h8tmo.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8203"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Davide Restivo , 45934@debbugs.gnu.org, xgutter@yahoo.it, Andrea Corallo To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 07 12:26:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mCJWv-0001xa-2H for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Aug 2021 12:26:13 +0200 Original-Received: from localhost ([::1]:40262 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mCJWt-00064L-5s for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Aug 2021 06:26:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36716) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mCJWk-00063s-PE for bug-gnu-emacs@gnu.org; Sat, 07 Aug 2021 06:26:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40451) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mCJWk-0004dZ-HT for bug-gnu-emacs@gnu.org; Sat, 07 Aug 2021 06:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mCJWj-00008b-TM for bug-gnu-emacs@gnu.org; Sat, 07 Aug 2021 06:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Aug 2021 10:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45934 X-GNU-PR-Package: emacs Original-Received: via spool by 45934-submit@debbugs.gnu.org id=B45934.162833191532595 (code B ref 45934); Sat, 07 Aug 2021 10:26:01 +0000 Original-Received: (at 45934) by debbugs.gnu.org; 7 Aug 2021 10:25:15 +0000 Original-Received: from localhost ([127.0.0.1]:51991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mCJVz-0008Te-6s for submit@debbugs.gnu.org; Sat, 07 Aug 2021 06:25:15 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:45944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mCJVw-0008Q0-5w for 45934@debbugs.gnu.org; Sat, 07 Aug 2021 06:25:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=4xCetEfJeg8w1siH56Q4QvBuTb4/JpNhpOrYLDLQWmg=; b=EDIiRfgUXLkg6nAlHuJVKto1ys 2sUG9aUSpjWIjKDhCLvGO07qU0zS9TkDJcG4TJ0DUe2KJ8BCEY8DVUHABkuXd3wFKaPWF3WN8MP0k Oim9QbYo8L4qgY3e/nGbAZUBKQSYWMSOhYPBJDxfr/o+/RWSBebweLbblOGivuktKsjg=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mCJVm-0006W0-Vu; Sat, 07 Aug 2021 12:25:05 +0200 In-Reply-To: <87im0h8tmo.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 07 Aug 2021 11:57:19 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211368 Archived-At: OK, back to the ostensible subject of this bug report. This is what the current trunk currently gives us: bash-3.2$ otool -D native-lisp/28_0_50-395a4a99/preloaded/x-win-3c49581f-3fe8af32.eln native-lisp/28_0_50-395a4a99/preloaded/x-win-3c49581f-3fe8af32.eln: /var/folders/09/qpnlh75n3t70kt9dcw8jlqb80000gn/T//libgccjit-BikCmL/fake.so And with Andrea's patch it... er... segfaults... Let's try a "make bootstrap" and see whether that helps. ... Yup, now it compiles fine. And: bash-3.2$ otool -D native-lisp/28_0_50-395a4a99/preloaded/x-win-3c49581f-3fe8af32.eln native-lisp/28_0_50-395a4a99/preloaded/x-win-3c49581f-3fe8af32.eln: /var/folders/09/qpnlh75n3t70kt9dcw8jlqb80000gn/T//libgccjit-Lge08S/fake.so So... it had no effect? This was the patch I applied: diff --git a/src/comp.c b/src/comp.c index c380346482..6347c015cd 100644 --- a/src/comp.c +++ b/src/comp.c @@ -4490,6 +4490,16 @@ DEFUN ("comp--compile-ctxt-to-file", Fcomp__compile_ctxt\ _to_file, GCC_JIT_INT_OPTION_OPTIMIZATION_LEVEL, comp.speed < 0 ? 0 : (comp.speed > 3 ? 3 : comp.speed)); + +/* On MacOS set a unique dylib ID (Bug#45934). */ +#if defined (LIBGCCJIT_HAVE_gcc_jit_context_add_driver_option) \ + && defined (DARWIN_OS) + gcc_jit_context_add_driver_option ( + comp.ctxt, + SSDATA (concat2 (build_string ("-dynamiclib -install_name "), + Ffile_name_nondirectory (filename)))); +#endif + comp.d_default_idx = CALL1I (comp-data-container-idx, CALL1I (comp-ctxt-d-default, Vcomp_ctxt))\ ; comp.d_impure_idx = -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no