From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#39452: [PATCH] vc-git-state fails for filenames with wildcards Date: Sat, 14 Aug 2021 13:56:36 +0200 Message-ID: <877dgoutmz.fsf@gnus.org> References: <83h802g77h.fsf@gnu.org> <8f427281-510c-30c3-995f-364e22d9c1e2@yandex.ru> <85y2texxso.fsf@gmail.com> <52f47a82-b93e-d9c2-ee94-752b289d4b96@yandex.ru> <85lfp7ygk3.fsf@gmail.com> <87pmxwgcps.fsf@gnus.org> <1cb67253-c43f-caac-ee83-1241edaaeeaa@yandex.ru> <87k0lildtq.fsf@gnus.org> <6e6060f9-0259-9b12-f925-a1a85c6757c4@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32429"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Noam Postavsky , 39452@debbugs.gnu.org, Wolfgang.Scherer@gmx.de To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 14 13:57:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mEsHp-0008Fx-P0 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Aug 2021 13:57:13 +0200 Original-Received: from localhost ([::1]:44692 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mEsHo-0001U5-La for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 14 Aug 2021 07:57:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52262) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mEsHe-0001Th-O8 for bug-gnu-emacs@gnu.org; Sat, 14 Aug 2021 07:57:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60421) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mEsHe-00086r-GL for bug-gnu-emacs@gnu.org; Sat, 14 Aug 2021 07:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mEsHe-0000hR-FQ for bug-gnu-emacs@gnu.org; Sat, 14 Aug 2021 07:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Aug 2021 11:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39452-submit@debbugs.gnu.org id=B39452.16289422102671 (code B ref 39452); Sat, 14 Aug 2021 11:57:02 +0000 Original-Received: (at 39452) by debbugs.gnu.org; 14 Aug 2021 11:56:50 +0000 Original-Received: from localhost ([127.0.0.1]:43734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mEsHR-0000h0-SJ for submit@debbugs.gnu.org; Sat, 14 Aug 2021 07:56:50 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:60698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mEsHP-0000gn-QV for 39452@debbugs.gnu.org; Sat, 14 Aug 2021 07:56:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uVfJyoMORJHGwthmXAxiGsD6a+r7PBmn1BWES/RjMTw=; b=lJeCEVBCiP7ZhiVQpZ8Ye0hSku YTISyFtfA/1JU4Mm+fV3TxnKXDWDPRtpxDOE2/mLwOdYpEGgUrNHWRPKq9UxV2v8PwtWqq5Yv2wK7 G5o31XtST8OYR7Rt1qHRV7dKDhbIJfwX9dHNcSHzGWLaNpEKeXBdQnjbpVMUfPmArp/M=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mEsHF-0000E7-B3; Sat, 14 Aug 2021 13:56:41 +0200 In-Reply-To: <6e6060f9-0259-9b12-f925-a1a85c6757c4@yandex.ru> (Dmitry Gutov's message of "Sat, 14 Aug 2021 03:11:56 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:211825 Archived-At: Dmitry Gutov writes: >> Nobody had any opinions, and the "if it's good enough for Magit" >> argument is a good one. So I went ahead and applied Dmitry's patch to >> Emacs 28, and we'll see whether there's any push back on that... > > As luck would have it, I have a bit of code (namely > project--vc-list-files) that got broken with that change. > > Because, when EXTRA-IGNORES are present, it constructs some > non-literal pathspecs, which naturally fail (get misinterpreted) with > GIT_LITERAL_PATHSPECS=1. > > So we need an escape hatch to turn off this feature, which could take > form of a dynamic variable, like in the patch below. > > Or we could revert to the other approach. What do people think? If we've seen one piece of code break here already, then perhaps reverting and moving to the other (safer, but more invasive) approach is the right way to go. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no