From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50228: [PATCH] 'command-completion-using-modes-p' doesn't work with multiple modes Date: Fri, 27 Aug 2021 17:31:41 +0200 Message-ID: <877dg6oqea.fsf@gnus.org> References: <87pmtzmatt.fsf@mailbox.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25121"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 50228@debbugs.gnu.org To: Johannes Maier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 27 17:33:24 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJdr9-0006JM-A0 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 Aug 2021 17:33:23 +0200 Original-Received: from localhost ([::1]:60976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJdr8-0006cS-49 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 Aug 2021 11:33:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33002) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJdqo-0006c1-FS for bug-gnu-emacs@gnu.org; Fri, 27 Aug 2021 11:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41225) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mJdqo-0004dm-8Q for bug-gnu-emacs@gnu.org; Fri, 27 Aug 2021 11:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mJdqo-0003Ti-3n for bug-gnu-emacs@gnu.org; Fri, 27 Aug 2021 11:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Aug 2021 15:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50228 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 50228-submit@debbugs.gnu.org id=B50228.163007832311528 (code B ref 50228); Fri, 27 Aug 2021 15:33:02 +0000 Original-Received: (at 50228) by debbugs.gnu.org; 27 Aug 2021 15:32:03 +0000 Original-Received: from localhost ([127.0.0.1]:52769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJdpm-0002vs-RN for submit@debbugs.gnu.org; Fri, 27 Aug 2021 11:32:03 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:33346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJdpg-0002nK-S4 for 50228@debbugs.gnu.org; Fri, 27 Aug 2021 11:31:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9GyjNsOQabKFy3DD7b1teHhBgWr/4TMXI1KJO4uMqi0=; b=Jy+3NP+vlbSB/Ww71d5DUhlNvZ mJWDB6wUAUBFuMn3sVSrdorieeU5Siewet2Eg0dBrUKDO8osNBJyHJrc8RLS6sHhqcqjZeInt5++u 5ja568xCmw9e91h4AqibVpE1XAnHahzyT/jdAZfFGKu14evNyJV45K0LdPkp/yK+BEC4=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJdpW-0003zK-93; Fri, 27 Aug 2021 17:31:46 +0200 In-Reply-To: <87pmtzmatt.fsf@mailbox.org> (Johannes Maier's message of "Fri, 27 Aug 2021 12:38:38 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212824 Archived-At: Johannes Maier writes: > I've attached a patch that removes the duplicated checks in these two > functions and simply calls 'command-completion-with-modes-p' from > 'command-completion-using-modes-p'. Now it works for me with one or > more (major or minor) modes in 'interactive'. Thanks, that does fix the problem. However, the reason `command-completion-using-modes-p' is coded that way is that `command-completion-with-modes-p' is slower in the common case, and completion has to be fast. But in the multiple-mode case, we can indeed just call `command-completion-with-modes-p', so I've kept the common case, but punted to `command-completion-with-modes-p' in the multiple-mode case, and that seems to fix the issue. > (I didn't see any tests for those functions, but I'm not sure how to go > about those yet. Could probably have look into those, too.) Yes, there really should be tests in this area... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no