From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#39452: [PATCH] vc-git-state fails for filenames with wildcards Date: Sat, 28 Aug 2021 17:44:35 +0200 Message-ID: <877dg5fuak.fsf@gmx.net> References: <83h802g77h.fsf@gnu.org> <8f427281-510c-30c3-995f-364e22d9c1e2@yandex.ru> <85y2texxso.fsf@gmail.com> <52f47a82-b93e-d9c2-ee94-752b289d4b96@yandex.ru> <85lfp7ygk3.fsf@gmail.com> <87pmxwgcps.fsf@gnus.org> <1cb67253-c43f-caac-ee83-1241edaaeeaa@yandex.ru> <87k0lildtq.fsf@gnus.org> <6e6060f9-0259-9b12-f925-a1a85c6757c4@yandex.ru> <877dgoutmz.fsf@gnus.org> <2602aeaf-0f02-e744-2b4f-012e73e012e8@yandex.ru> <87y28nbky4.fsf@linkov.net> <87o89ieruy.fsf@mail.linkov.net> <87a6l2d5kd.fsf@gmx.net> <87ilzpk3qi.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9168"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Juri Linkov , Dmitry Gutov , Noam Postavsky , 39452@debbugs.gnu.org, Wolfgang.Scherer@gmx.de To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 28 17:45:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mK0W6-00021M-Pp for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 Aug 2021 17:45:10 +0200 Original-Received: from localhost ([::1]:46208 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mK0W5-0003HB-9j for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 Aug 2021 11:45:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40988) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mK0Vy-0003F9-Rc for bug-gnu-emacs@gnu.org; Sat, 28 Aug 2021 11:45:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43314) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mK0Vy-0008Rp-JV for bug-gnu-emacs@gnu.org; Sat, 28 Aug 2021 11:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mK0Vy-0006dH-IN for bug-gnu-emacs@gnu.org; Sat, 28 Aug 2021 11:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Aug 2021 15:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39452-submit@debbugs.gnu.org id=B39452.163016549425463 (code B ref 39452); Sat, 28 Aug 2021 15:45:02 +0000 Original-Received: (at 39452) by debbugs.gnu.org; 28 Aug 2021 15:44:54 +0000 Original-Received: from localhost ([127.0.0.1]:54860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mK0Vm-0006cZ-79 for submit@debbugs.gnu.org; Sat, 28 Aug 2021 11:44:53 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:45513) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mK0Vg-0006cC-Ax for 39452@debbugs.gnu.org; Sat, 28 Aug 2021 11:44:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1630165476; bh=EfVWwzB1cRq02yc74I2YB/ND2YkHeO+7s6Twq4D6Fug=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=LkNdyqwi42C2HVwAZJRRBbMkBZFzKo0hy8kT1g1y5HDa4dx2hf0279RL7Gg1WmIdb CTukUu0fOjQzzwT5NYYypPkz7LtN3TORKz/Yy7LsND1P+zNrAVhow626TwwAE+BcZ4 yAB7Zii0TeB4CQ453HJ/yzSNxsWzonZFZNkK3spg= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from strobelfs ([178.1.124.4]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MWzjt-1mVDhN2kmn-00XJ1I; Sat, 28 Aug 2021 17:44:36 +0200 In-Reply-To: <87ilzpk3qi.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 28 Aug 2021 17:07:01 +0200") X-Provags-ID: V03:K1:WvQh9TQWHVUmtAVPkcbodD5IRdBbozI+nqCQkQDRwssLD5/e0LJ SELGNoAbNL1bEcc9Z3XDrifNEBZZ968IJMcEbfuDyxxXbWeAOyGIPSKGCkVuuIphI3UHMvS 3m9wHuVo7YYvsubTjeB/VRLQR/7rKP7vb4LJG4vCNdyHwYL4MpXS0vTUYU+NPjnpMj6EjWU Vdgi1nGidaOKabgPGb0Rw== X-UI-Out-Filterresults: notjunk:1;V03:K0:9GjbVSkwfOo=:be72OwmtXvRpoxGqj/m2BT tow5VbPYZ7mw/LaBGRe1GdMojoYLdEXhtmEbdj8PYN+Ds5c46wDubLNCdTqxmeFh2yM8pwuqP Mz3Kl383v2iOn/NPXsfRfCUh7GaV9ybOWkVndCzWIitGknP0Eu4N5mXkI6XjzAu0T9onTPeq5 /iJuUSsFu7KPT+XRqj7gBNpaQhl90fEgaForJQNA9vPrQHPc3ZxmhR88gGmpq2dtnV76O9gsh PyyS1cstoX6w0itEM7ny9UfBmHwv6j4aRhf43oiOZyVIzzOwB2wwjDBxk8npDCzL/p2xTIVf9 W351vmcoS4AdB2RqhUM04hYRP6kxUsrKnspZTEfvqBfQINzNGsNQDlV4Kgjx1WSx3S7zufSwp sE3bXY+pHJBerU1oS0cZ3jmEQk7SRtno21ttplV/x6HZbSJnPgPFwf45Ys/8iyVVwa4iXB+xC 1VwjZdpfk9zNKsAeeW/N/UzfbiSUCn4BlC5QdfN+izNe/0GbqAMXuu3Y958CtmyyJxEG/EhE9 GhZNSJi5LT5uSAdWoLTU2/8I/OascLoY+JfwSrVr2IVlMAOZuOdCMRTNJqmfaYJvsLNAoLWKq SVXrRE7qLqHKf5+w4Mrc8UmFPVxKSsAG9HkJVlEyCEvEHZ3/KMnceAoGUIb3XYUodstxEOPdc AS4RL80lDvf9/u4prL1iO3YSIVFxPLhzOIa7ArPsYJdxrnHzciErjHNbDiTQpaXm93ySqIeSm pzhKqV+fqEbui3rzTk6gsVG+C6J/HX5wojyGGsjEOYogrSAClI5QmQe6CP9p5fz5g1PXKP9y X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212878 Archived-At: On Sat, 28 Aug 2021 17:07:01 +0200 Lars Ingebrigtsen wrote: > Stephen Berman writes: > >> I just discovered that some code I have that uses vc-print-log-internal >> broke after the literal-pathspecs change; specifically, my code passes a >> directory name beginning with "~/" to vc-print-log-internal, and this >> had worked fine till that change, which broke it, and I found I have to >> wrap the directory name in expand-file-name to make the code work again. >> Is this expected fallout from that change or was I perhaps misusing >> vc-print-log-internal and was just lucky that it had worked before? > > I think it's reasonable to expect parameters to `vc-print-log-internal' > to have been expanded first, but that should be documented, at least. I'm not sure it needs to be documented, it is internal, after all. I'm using it because I want a different UI than what vc-print-log provides. The latter passes the file name to vc-print-log-internal already expanded; I should have checked that when I decided to use the internal function. But I don't see at first glance why the unexpanded file name in the latter worked prior to the literal-pathspecs change but not afterwards. Steve Berman