From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50459: 28.0.50; Python shell completion is incompatible with flex, orderless, etc. Date: Fri, 10 Sep 2021 13:37:57 +0200 Message-ID: <877dfopsoa.fsf@gnus.org> References: <87wnnsl1d1.fsf@gmail.com> <87czpijixk.fsf@gmail.com> <877dfqjfwu.fsf@gmail.com> <87mtolr91a.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23947"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 50459@debbugs.gnu.org, Gregory Heytings , Michael Albinus To: Augusto Stoffel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 10 13:42:22 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mOevG-00061R-Lp for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Sep 2021 13:42:22 +0200 Original-Received: from localhost ([::1]:44254 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mOevF-0003St-8V for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Sep 2021 07:42:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51056) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mOes2-0001m4-H1 for bug-gnu-emacs@gnu.org; Fri, 10 Sep 2021 07:39:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53801) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mOes2-0003jR-8x for bug-gnu-emacs@gnu.org; Fri, 10 Sep 2021 07:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mOes2-00023E-4Y for bug-gnu-emacs@gnu.org; Fri, 10 Sep 2021 07:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Sep 2021 11:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50459 X-GNU-PR-Package: emacs Original-Received: via spool by 50459-submit@debbugs.gnu.org id=B50459.16312738917803 (code B ref 50459); Fri, 10 Sep 2021 11:39:02 +0000 Original-Received: (at 50459) by debbugs.gnu.org; 10 Sep 2021 11:38:11 +0000 Original-Received: from localhost ([127.0.0.1]:37111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOerD-00021n-67 for submit@debbugs.gnu.org; Fri, 10 Sep 2021 07:38:11 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:54026) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOerA-00021V-Iv for 50459@debbugs.gnu.org; Fri, 10 Sep 2021 07:38:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=hJsE41yYNBSXMuVp9xfw34boNSOoZJRBC9DJO1LbuwM=; b=qAS0BGJPe5HQ96JoCVmjipUKGR 74U/TkoWwpA1nrVkWtxEfgCLqLx1icVXfPmzR4gXJZjFZGiwFklR3+4jAn1HNZEdVfwWDw2RIPOfG hXMAFIduGOVfMGiS1YDGzQ0JmRtlx6ieepJRNoK1RpZ7hd3zUc6Lh+M/fSvS8Cm8BV6g=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mOer0-0003IE-C1; Fri, 10 Sep 2021 13:38:00 +0200 In-Reply-To: <87mtolr91a.fsf@gmail.com> (Augusto Stoffel's message of "Thu, 09 Sep 2021 18:46:57 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213992 Archived-At: Augusto Stoffel writes: > To alleviate this, the completion-at-point function could implement some > sort of caching. The difficult question is when to invalidate the > cache. I've attached one possiblility as a draft patch. If the > approach seems reasonable, then I'll format it properly. Would it be possible to do caching at a lower level instead of in python-mode? > As a side effect, the patch also solves the original issue described in > this ticket. [...] > - (list start end > - (completion-table-dynamic > - (apply-partially > - completion-fn > - process import-statement))))) > + (let ((re (or (car python-shell--capf-cache) regexp-unmatchable)) > + (prefix (buffer-substring-no-properties start end))) > + (unless (string-match re prefix) > + (setq python-shell--capf-cache > + (cons (concat "\\`" (regexp-quote prefix) "\\(?:\\sw\\|\\s_\\)*\\'") > + (funcall completion-fn process import-statement prefix))))) > + (list start end (cdr python-shell--capf-cache)))) I'm not sure I understand this patch -- it's not using `completion-table-dynamic' at all now? (But my understanding of the completion functions in Emacs is pretty lacking.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no