From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#50424: 27.2; Tab bar button mouse face not clearing entirely Date: Mon, 13 Sep 2021 10:59:12 +0300 Organization: LINKOV.NET Message-ID: <877dfkhpnz.fsf@mail.linkov.net> References: <87eea2cebb.fsf.ref@yahoo.com> <87eea2cebb.fsf@yahoo.com> <83eea2rn8z.fsf@gnu.org> <87h7exc2dk.fsf@yahoo.com> <83lf49r4bc.fsf@gnu.org> <87czplb51o.fsf@yahoo.com> <83ilzcpt0d.fsf@gnu.org> <83mtonob41.fsf@gnu.org> <87tuiryn17.fsf@mail.linkov.net> <831r5uhpd3.fsf@gnu.org> <8735qazyjv.fsf@mail.linkov.net> <83zgsifob4.fsf@gnu.org> <87zgsii8cy.fsf@mail.linkov.net> <83k0jmfay2.fsf@gnu.org> <87lf41hlym.fsf@mail.linkov.net> <835yv5g3rp.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28196"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: luangruo@yahoo.com, 50424@debbugs.gnu.org, alan@idiocy.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 13 10:03:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mPgvt-0007AW-9T for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Sep 2021 10:03:17 +0200 Original-Received: from localhost ([::1]:59860 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPgvs-0001Pt-7F for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 13 Sep 2021 04:03:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49208) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPgvf-0001L8-7E for bug-gnu-emacs@gnu.org; Mon, 13 Sep 2021 04:03:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60836) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mPgve-0007se-Ve for bug-gnu-emacs@gnu.org; Mon, 13 Sep 2021 04:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mPgve-00034k-SG for bug-gnu-emacs@gnu.org; Mon, 13 Sep 2021 04:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 13 Sep 2021 08:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50424 X-GNU-PR-Package: emacs Original-Received: via spool by 50424-submit@debbugs.gnu.org id=B50424.163152014411757 (code B ref 50424); Mon, 13 Sep 2021 08:03:02 +0000 Original-Received: (at 50424) by debbugs.gnu.org; 13 Sep 2021 08:02:24 +0000 Original-Received: from localhost ([127.0.0.1]:44145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mPgv1-00033Y-UL for submit@debbugs.gnu.org; Mon, 13 Sep 2021 04:02:24 -0400 Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]:43541) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mPgv0-000333-OM; Mon, 13 Sep 2021 04:02:23 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 6A418C0002; Mon, 13 Sep 2021 08:02:13 +0000 (UTC) In-Reply-To: <835yv5g3rp.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 12 Sep 2021 19:25:14 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214186 Archived-At: tags 50424 fixed close 50424 28.0.50 quit >> > If we want the default value of tab-bar-button-margin to be a cons >> > cell, let's change the default value to be a cons cell, it's not more >> > complicated than setting it to a scalar, even in C. But tab-bar.el >> > should use in its image specs the exact value of >> > tab-bar-button-margin, it cannot decide to change it behind the back >> > of the caller. >> >> I tried a cons cell, but it looks ugly for buttons other than the close button. >> OTOH, margin 1 looks nice for all buttons: > > Fine by me. So pushed to master. >> -#define DEFAULT_TAB_BAR_BUTTON_MARGIN 4 >> +#define DEFAULT_TAB_BAR_BUTTON_MARGIN 1 >> #define DEFAULT_TAB_BAR_BUTTON_RELIEF 1 > > Btw, I don't see much sense in keeping the > DEFAULT_TAB_BAR_BUTTON_MARGIN macro: it's used in one place only, > AFAICT, so we could simply have it there literally. I thought about this too, but it will break the symmetry with DEFAULT_TOOL_BAR_BUTTON_MARGIN and DEFAULT_TOOL_BAR_BUTTON_RELIEF when DEFAULT_TAB_BAR_BUTTON_MARGIN will be used in more places.