unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 51075@debbugs.gnu.org, eggert@cs.ucla.edu
Subject: bug#51075: 29.0.50; Uninitialised variable warning in src/term.c
Date: Fri, 08 Oct 2021 11:21:02 +0100	[thread overview]
Message-ID: <877denom0h.fsf@tcd.ie> (raw)
In-Reply-To: <8335pd0z09.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 07 Oct 2021 09:02:03 -0400")

Eli Zaretskii [2021-10-07 09:02 -0400] wrote:

>> Cc: Paul Eggert <eggert@cs.ucla.edu>
>> Date: Thu, 07 Oct 2021 12:18:14 +0100
>> From:  "Basil L. Contovounesios" via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>
>> Is
>> 
>>   cmp = composition_table[src->u.cmp.id];
>> 
>> indeed guaranteed to be non-NULL?
>
> If it's ever NULL, the very next line will segfault:
>
> 	      cmp = composition_table[src->u.cmp.id];
> 	      required = cmp->glyph_len;

Right, I didn't read carefully enough.

Thanks,

-- 
Basil





      parent reply	other threads:[~2021-10-08 10:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-07 11:18 bug#51075: 29.0.50; Uninitialised variable warning in src/term.c Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-07 13:01 ` Eli Zaretskii
2021-10-07 20:13   ` Paul Eggert
2021-10-08 10:21     ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-08 10:21   ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877denom0h.fsf@tcd.ie \
    --to=bug-gnu-emacs@gnu.org \
    --cc=51075@debbugs.gnu.org \
    --cc=contovob@tcd.ie \
    --cc=eggert@cs.ucla.edu \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).