unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: 54131@debbugs.gnu.org
Subject: bug#54131: 29.0.50; Flyspell incorrectly reports first word in Python f-string
Date: Wed, 23 Feb 2022 21:13:27 +0100	[thread overview]
Message-ID: <877d9l5ok8.fsf@gnus.org> (raw)
In-Reply-To: <wvr4y22178k4.fsf@gmail.com> (Philipp Stephani's message of "Wed,  23 Feb 2022 19:16:11 +0100")

Philipp Stephani <p.stephani2@gmail.com> writes:

> Given this Python file:
>
> $ cat /tmp/a.py 
> print(f'hello world')
>
> Visit it and enable Flyspell:
>
> $ emacs -Q /tmp/a.py -f flyspell-prog-mode
>
> Flyspell then marks the string "f'hello" as incorrect, thinking it's a
> misspelling of "hello".  But it shouldn't cross the string boundary.

Hm, yes.  In this case, the mode knows that f isn't part of the
expression, but I guess we have no way of communicating that to ispell?

Skimming ispell-get-word, it looks like it uses a regexp to determine
what the word at point is, so we'd need to make some sort of framework
to allow modes to say where a string begins and ends?  Or if we want to
just do something hackish, we could make that function check
the face for font-lock-string-face and then limit based on that.  (Which
sounds simple enough.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2022-02-23 20:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-23 18:16 bug#54131: 29.0.50; Flyspell incorrectly reports first word in Python f-string Philipp Stephani
2022-02-23 20:13 ` Lars Ingebrigtsen [this message]
2022-02-23 20:27   ` Philipp Stephani
2022-02-24  6:33     ` Eli Zaretskii
2022-02-24  6:27   ` Eli Zaretskii
2022-02-24  9:12     ` Lars Ingebrigtsen
2022-02-24  9:26       ` martin rudalics
2022-02-24 10:19       ` Eli Zaretskii
2022-02-24 11:23         ` Visuwesh
2022-02-24 14:36           ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877d9l5ok8.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=54131@debbugs.gnu.org \
    --cc=p.stephani2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).