From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#52209: 28.0.60; [PATCH] date-to-time fails on pure dates Date: Thu, 24 Feb 2022 10:19:43 +0100 Message-ID: <877d9k4o5s.fsf@gnus.org> References: <7c22f300-eedb-da65-db02-e82025ec2f48@cs.ucla.edu> <87zgoq2vwm.fsf@gnus.org> <25029.60989.564217.290743@orion.rgrjr.com> <87bl1428x5.fsf@gnus.org> <25031.40994.286546.498819@orion.rgrjr.com> <87ee5zzjpg.fsf@gnus.org> <25035.12991.328986.987982@orion.rgrjr.com> <87o84z782g.fsf@gnus.org> <25038.8156.470964.935330@orion.rgrjr.com> <87lezz5x92.fsf@gnus.org> <87h7an7bdm.fsf@igel.home> <25040.62646.635818.692654@orion.rgrjr.com> <87mtkd3vee.fsf@gnus.org> <25043.53490.928476.622599@orion.rgrjr.com> <87lezudw3q.fsf@gnus.org> <25046.8337.837242.510788@orion.rgrjr.com> <25105.33397.961104.269676@orion.rgrjr.com> <87wnhphepw.fsf@igel.home> <87ilt9vicd.fsf@gnus.org> <25106.48460.775490.619228@orion.rgrjr.com> <25110.49174.412406.711346@orion.rgrjr.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27435"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 52209@debbugs.gnu.org, Andreas Schwab , Paul Eggert To: Bob Rogers Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 24 10:20:57 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nNAIx-0006rz-V8 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Feb 2022 10:20:55 +0100 Original-Received: from localhost ([::1]:34236 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nNAIw-0007hO-A3 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Feb 2022 04:20:54 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51482) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nNAIM-0007f5-Rt for bug-gnu-emacs@gnu.org; Thu, 24 Feb 2022 04:20:30 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53630) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nNAI8-00051C-4p for bug-gnu-emacs@gnu.org; Thu, 24 Feb 2022 04:20:16 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nNAI8-0001Be-0v for bug-gnu-emacs@gnu.org; Thu, 24 Feb 2022 04:20:04 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Feb 2022 09:20:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52209 X-GNU-PR-Package: emacs Original-Received: via spool by 52209-submit@debbugs.gnu.org id=B52209.16456943964522 (code B ref 52209); Thu, 24 Feb 2022 09:20:03 +0000 Original-Received: (at 52209) by debbugs.gnu.org; 24 Feb 2022 09:19:56 +0000 Original-Received: from localhost ([127.0.0.1]:47523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNAI0-0001Ar-9r for submit@debbugs.gnu.org; Thu, 24 Feb 2022 04:19:56 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:43438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nNAHy-0001AW-IY for 52209@debbugs.gnu.org; Thu, 24 Feb 2022 04:19:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Ju8VX1d8HERbmqnGDrqCqnE6FYHxU31POOcPQxoJ6m8=; b=ssp/qF2l8xneeIG58b+5EEHhm7 EgYzXdBmIRUBKtzIG2NSEtIHnQ93ds6pruCJjWEN01ltU3/4TZFaYos+mG6BMo8z+bk7Xo7z2vfs9 srcy78RnkguEYq51XFDUS2QbRLe//sDUIVJctNasTjaZvpxpCB1EiWvs4EN4tICND6ws=; Original-Received: from [84.212.220.105] (helo=giant) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nNAHn-0003qj-V2; Thu, 24 Feb 2022 10:19:46 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEWJgHTa2NZIQTr/ ///FtiXEAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+YCGAg1E8s4rP8AAAF7SURBVCjPfdDBThsxEAbg 2Sitqj1FUYxETyQHlPopXJQg2NMW7aCyp4AaKexTOFWMopx6SDivo1KZ/yk7dlALF+b2ee3Z+YcU /y9KmDJPuGLqeznxhqQEoTzuDAVdOeztzf3H4SJ+UdTzk6fT7BYI+Y767eTkzs2w9xEI2X65EDQR yEbLBnjWggDq+DvBhZL/jC38TBpI6z5aq/1cAwlBMD17AdbwfJ6uHVlS0zdTv4Xpfn/GTmDUWDX2 PggG/KM3ck220BF+/mu0NHQS8RhmYxoWCBBsoT9ZAQ4o1lYVOk/INOyuGFYH5HrzVDiG5NnaPja+ HrCW2Ns95RtfXnOTO3pA0PDfrrhOkPKXzFWpaGXp3+TkXkc4oByk9bopV8QlZC8CkrdcBrRBxWuy AgF6CV+Z68/487iLkM4XV1h1IyrxZY3VwEX4Od+c4bd2MkGHMjZUtxDIaGs2WY0E6RoKmye00Btb x9kFEgdfBD/tB3LWmPcivIaEkZf4C95g2gEFswnBAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIyLTAy LTI0VDA4OjUzOjE5KzAwOjAwzyT0ogAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0wMi0yNFQwODo1 MzoxOSswMDowML55TB4AAAAASUVORK5CYII= X-Now-Playing: Bobbie Gentry's _The Girl From Chickasaw County (6): Fancy_: "Apartment 21" In-Reply-To: <25110.49174.412406.711346@orion.rgrjr.com> (Bob Rogers's message of "Wed, 23 Feb 2022 18:15:34 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227569 Archived-At: Bob Rogers writes: > Benchmarking code and results attached. I extracted a handful of > non-error cases from the tests as being more representative than any of > the error cases; the resulting numbers make it seem like any difference > between the two implementations is in the noise. > > But this is my first foray into elisp benchmarking, so I may have > overlooked something. Fortunately, email dates are not that diverse, so > I am hoping this sampling may be broad enough. [...] > (benchmark-run-compiled 10000 (run-timings #'ietf-drums-parse-date)) > ;; (7.220905228 83 3.3420971879999968) > ;; (7.24936647 83 3.3321491059999993) > ;; (7.3240701370000005 84 3.371737411) > ;; (/ (+ 7.249 7.324 7.324) 3) 7.299 [...] > (benchmark-run 10000 (run-timings #'ietf-drums-old-parse-date)) > ;; (7.249068317 83 3.3251401939999994) > ;; (7.317397244 84 3.3750772899999983) > ;; (7.268244294 84 3.3820036280000005) > ;; (/ (+ 7.249 7.317 7.268) 3) 7.278 Thanks; that looks quite promising. Can you send a new version of the patch, and I'll get it pushed? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no