From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.bugs Subject: bug#54921: eww/url mishandles IDN over proxy Date: Thu, 14 Apr 2022 15:52:57 +0200 Message-ID: <877d7rzs92.fsf@igel.home> References: <87bkx44q3v.fsf@igel.home> <87czhko3xg.fsf@gnus.org> <87bkx4yw98.fsf@igel.home> <87tuavn6vx.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29479"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) Cc: 54921@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 14 15:54:44 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nezvl-0007Pg-PP for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Apr 2022 15:54:41 +0200 Original-Received: from localhost ([::1]:51208 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nezvk-0003FU-JE for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Apr 2022 09:54:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39460) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nezv8-0002H6-83 for bug-gnu-emacs@gnu.org; Thu, 14 Apr 2022 09:54:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33540) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nezv7-0005pi-U5 for bug-gnu-emacs@gnu.org; Thu, 14 Apr 2022 09:54:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nezv7-0003mG-RW for bug-gnu-emacs@gnu.org; Thu, 14 Apr 2022 09:54:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Apr 2022 13:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54921 X-GNU-PR-Package: emacs Original-Received: via spool by 54921-submit@debbugs.gnu.org id=B54921.164994438214439 (code B ref 54921); Thu, 14 Apr 2022 13:54:01 +0000 Original-Received: (at 54921) by debbugs.gnu.org; 14 Apr 2022 13:53:02 +0000 Original-Received: from localhost ([127.0.0.1]:55670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nezuA-0003kd-Bs for submit@debbugs.gnu.org; Thu, 14 Apr 2022 09:53:02 -0400 Original-Received: from mail-out.m-online.net ([212.18.0.10]:46823) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nezu8-0003kH-61 for 54921@debbugs.gnu.org; Thu, 14 Apr 2022 09:53:00 -0400 Original-Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4KfLWb0CJfz1s949; Thu, 14 Apr 2022 15:52:58 +0200 (CEST) Original-Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4KfLWZ506nz1qqkC; Thu, 14 Apr 2022 15:52:58 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id HHNi31AXdVYh; Thu, 14 Apr 2022 15:52:58 +0200 (CEST) X-Auth-Info: qAFi7dqKymKXCETQC1qdceHMZACkA2U81J4Gw4UuFNjyX27OY/76rjGpUjbZ3PQ0 Original-Received: from igel.home (ppp-46-244-164-67.dynamic.mnet-online.de [46.244.164.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 14 Apr 2022 15:52:57 +0200 (CEST) Original-Received: by igel.home (Postfix, from userid 1000) id 796D22C39A8; Thu, 14 Apr 2022 15:52:57 +0200 (CEST) X-Yow: Either CONFESS now or we go to ``PEOPLE'S COURT''!! In-Reply-To: <87tuavn6vx.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 14 Apr 2022 15:15:14 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229870 Archived-At: On Apr 14 2022, Lars Ingebrigtsen wrote: > Andreas Schwab writes: > >> I have set https_proxy=http://localhost:8118/ in the environment, which >> is picked up by url to set url-proxy-services. > > Hm, right... > > I'm not at all familiar with this code, so here's a stab in the dark. > Does this fix the problem? > > diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el > index daeba17031..22e003d22d 100644 > --- a/lisp/url/url-http.el > +++ b/lisp/url/url-http.el > @@ -1405,10 +1405,12 @@ url-https-proxy-connect > (and proxy-auth > (concat "Proxy-Authorization: " proxy-auth "\r\n"))) > "\r\n") > - (url-host url-current-object) > + (url-http--encode-string > + (puny-encode-domain (url-host url-current-object))) > (or (url-port url-current-object) > url-https-default-port) > - (url-host url-current-object)))) > + (url-http--encode-string > + (puny-encode-domain (url-host url-current-object)))))) url-http--encode-string shouldn't be needed, since puny encoding is always ASCII. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."