From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#55269: 29.0.50; Infinite recursion causes segmentation fault Date: Thu, 05 May 2022 11:14:31 +0000 Message-ID: <877d70dyeg.fsf@posteo.net> References: <87levge24r.fsf@posteo.net> <871qx8uu39.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14779"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55269@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 05 13:18:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nmZUs-0003eM-9r for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 May 2022 13:18:14 +0200 Original-Received: from localhost ([::1]:48728 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nmZUr-0000wy-4U for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 May 2022 07:18:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39394) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nmZRm-0007BC-Ab for bug-gnu-emacs@gnu.org; Thu, 05 May 2022 07:15:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50613) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nmZRl-0002C5-Uy for bug-gnu-emacs@gnu.org; Thu, 05 May 2022 07:15:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nmZRl-0004Tz-QZ for bug-gnu-emacs@gnu.org; Thu, 05 May 2022 07:15:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 May 2022 11:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55269 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 55269-submit@debbugs.gnu.org id=B55269.165174928317191 (code B ref 55269); Thu, 05 May 2022 11:15:01 +0000 Original-Received: (at 55269) by debbugs.gnu.org; 5 May 2022 11:14:43 +0000 Original-Received: from localhost ([127.0.0.1]:44510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmZRS-0004TC-TU for submit@debbugs.gnu.org; Thu, 05 May 2022 07:14:43 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:33347) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nmZRQ-0004Sy-1R for 55269@debbugs.gnu.org; Thu, 05 May 2022 07:14:40 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id C1B76240107 for <55269@debbugs.gnu.org>; Thu, 5 May 2022 13:14:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1651749273; bh=yNuBHfRQekBlfPhbhKJDffiGZ863DuNrcct/j0BGS3g=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=iQXLT+M8DQ5k5OtDgJThBNCMOhwGHi8p/rqpdqMITPoY3fWPhAVeCy2vUwAvETCe0 AH9SzBrfEjZk2FmV6VAXJBIc0dpAqcRDGsT3/PahS1b2HcMRk1YIQ6qWVj7RYGnZRt /nHouNb3ygCeeb3+NtssuoGYG1uc7Grr6gxwQ17p+cYQvFLb8FkuVqqNvD7N5Q4YhW acY0x5qfOox+3qsXfuQ3dxIgg0K63oTFcDqrUEScvKDUdxOmPUM63JZPMhniRG+RVQ JthmlLyTH1xPxn4moQMoht3CQr/rI1ob5w1St7yz/D5QHMF85ROf8kjOjSprXnQYlb YVOICov2PM7+w== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4KvB150nlBz9rxK; Thu, 5 May 2022 13:14:32 +0200 (CEST) Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB In-Reply-To: <871qx8uu39.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 05 May 2022 12:55:38 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:231417 Archived-At: Lars Ingebrigtsen writes: > Philip Kaludercic writes: > >> #12 0x0000000000686c42 in print_error_message (data=0x1fc6273, stream=0x7ffff4881285, context=0x0, caller=0x0) at print.c:957 >> #13 0x0000000000686978 in Ferror_message_string (obj=0x1fc6273) at print.c:902 >> #14 0x00000000006569f5 in skip_debugger (conditions=0x7ffff44534b3, data=0x1fc6273) at eval.c:1888 > > Hm... so the backtrace here seems to say that skip_debugger (which is > supposed to be a predicate) is itself bugging out (i.e., the > Ferror_message_string is erroring)? > > Hm... Oh, it's coming from here? > > void > print_error_message (Lisp_Object data, Lisp_Object stream, const char *context, > Lisp_Object caller) > [...] > if (!NILP (Ffboundp (Qsubstitute_command_keys))) > errmsg = call1 (Qsubstitute_command_keys, errmsg); > > I think the fix here would be to ensure that that call never signals an > error (i.e., slap a condition-case around that call1). I.e., could you > try this patch and see whether it fixes the problem? I can confirm this solves the problem. Thanks! > diff --git a/src/print.c b/src/print.c > index 54d8bdfa3d..5255ea3632 100644 > --- a/src/print.c > +++ b/src/print.c > @@ -954,7 +954,11 @@ print_error_message (Lisp_Object data, Lisp_Object stream, const char *context, > errmsg = Fget (errname, Qerror_message); > /* During loadup 'substitute-command-keys' might not be available. */ > if (!NILP (Ffboundp (Qsubstitute_command_keys))) > - errmsg = call1 (Qsubstitute_command_keys, errmsg); > + { > + Lisp_Object subs = safe_call1 (Qsubstitute_command_keys, errmsg); > + if (!NILP (subs)) > + errmsg = subs; > + } > > file_error = Fmemq (Qfile_error, error_conditions); > }