From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Visuwesh Newsgroups: gmane.emacs.bugs Subject: bug#55977: 29.0.50; [PATCH] repeat-mode: Don't echo unset keys in help message Date: Tue, 14 Jun 2022 23:32:17 +0530 Message-ID: <877d5j2keu.fsf@gmail.com> References: <87fsk72m0b.fsf@gmail.com> <83y1xzrvn6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13015"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 55977@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 14 20:03:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o1Aso-0003Bw-OG for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Jun 2022 20:03:18 +0200 Original-Received: from localhost ([::1]:38722 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o1Asn-0002G7-4A for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Jun 2022 14:03:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37034) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1AsY-0002Fy-Vv for bug-gnu-emacs@gnu.org; Tue, 14 Jun 2022 14:03:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41810) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o1AsY-0005Ay-Ka for bug-gnu-emacs@gnu.org; Tue, 14 Jun 2022 14:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o1AsY-000435-FU for bug-gnu-emacs@gnu.org; Tue, 14 Jun 2022 14:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Jun 2022 18:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55977 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55977-submit@debbugs.gnu.org id=B55977.165522975215525 (code B ref 55977); Tue, 14 Jun 2022 18:03:02 +0000 Original-Received: (at 55977) by debbugs.gnu.org; 14 Jun 2022 18:02:32 +0000 Original-Received: from localhost ([127.0.0.1]:35707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1As3-00042L-Un for submit@debbugs.gnu.org; Tue, 14 Jun 2022 14:02:32 -0400 Original-Received: from mail-pg1-f193.google.com ([209.85.215.193]:35406) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1Arz-000425-Bh for 55977@debbugs.gnu.org; Tue, 14 Jun 2022 14:02:30 -0400 Original-Received: by mail-pg1-f193.google.com with SMTP id 129so9201404pgc.2 for <55977@debbugs.gnu.org>; Tue, 14 Jun 2022 11:02:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=7mYcXiectHbYUmOx304Hi1VuhW/h7OEGGXuBSaXEjKM=; b=jvEsJ2ZTpAuJng8r4rOQZJeIGNPV3+33uwiH045XBJeaH7Z1PmNIdVA4WFYDp2p6tt 1e8Hmx2JAX1yQAADZuZMX8TwOjgdz0CTMPs9JMvx6QqSYzu+zX/fjiHGQL/CrglipJXL v5F3HepcbubbVS8qeU9ImJ6WElPW8lYv+zJuP9eG0RijfWkqKbV20UUAGrSFHQRxMyY/ 0xW4EwkpVNWsr/1254ugzSNgSdRlb/mqjavOaSinYOvs9af93NxU3ynNfknSkxfPv8Fz +QbXNwH0933L2tJv6NxCMZGOBiNPS9A3hPJtpESlyxkIaqRkfZtFIC8ikAKxdX4P/J9k +0Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=7mYcXiectHbYUmOx304Hi1VuhW/h7OEGGXuBSaXEjKM=; b=svI7NIFw0xd5MRHROd5OA7nvQ5aOcKGvAJEKDjA/ewbuDTSr+IyIwx7ihX2yPdHGn9 bmPFHfFMeCuImTngog/P1LqOwP5B3Kb651DUXdfD9qIEyJ+Dl3UzvSwb7K24kR87kFx9 elFJBVYpWAuvdaDNcIWORuBLuKW0LbACK54dFfmJakCUpGlpm1ZG9PsqwT6NsBRmHR8t RTPGP0G4Dbnpegg9+IfQfA6dZulaLyUFPrZ7RyH9XgPX9YP7RNsAWPtaXRtpuYkwCpmI J907y9+f4l3mCMuP0+2ahXQVrQSKPRUY/iIKvpGmbGF/l5xrM9qCJKhajuUO6ok/V3jZ PBow== X-Gm-Message-State: AOAM532NcYAh/1PFq7Tulo99F2xE69t5ZsvyF2qoy+MOPaSY0V2kc5uV f+7wiv9ZctgZLycAy0x9NUA= X-Google-Smtp-Source: ABdhPJxyExQRVUeigRGZcTXi4Jl4dOvHktRjYAGhNkvI3dUlXQaQTfqAWRyIkga1gc6iWpdG4vbk4Q== X-Received: by 2002:a65:5385:0:b0:3fa:52e3:6468 with SMTP id x5-20020a655385000000b003fa52e36468mr5507508pgq.366.1655229741545; Tue, 14 Jun 2022 11:02:21 -0700 (PDT) Original-Received: from localhost ([49.204.128.74]) by smtp.gmail.com with ESMTPSA id e3-20020a170903240300b00168e83eda56sm2772813plo.3.2022.06.14.11.02.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 11:02:20 -0700 (PDT) In-Reply-To: <83y1xzrvn6.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 14 Jun 2022 20:40:29 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234526 Archived-At: [=E0=AE=9A=E0=AF=86=E0=AE=B5=E0=AF=8D=E0=AE=B5=E0=AE=BE=E0=AE=AF=E0=AF=8D = =E0=AE=9C=E0=AF=82=E0=AE=A9=E0=AF=8D 14, 2022 20:40] Eli Zaretskii wrote: >> From: Visuwesh >> Date: Tue, 14 Jun 2022 22:57:48 +0530 >>=20 >> repeat-mode echoes unset keys in the help message since it doesn't check >> for non-nil value of command bound to key; will attach patch once I get >> the bug number. > > Thanks, but can you please show a recipe from "emacs -Q", to > understand better what problem are you trying to fix? Sure. 1. M-x repeat-mode RET. 2. C-h n. 3. M-: (define-key outline-navigation-repeat-map (kbd "C-n") nil). 4. C-c @ C-n. Notice how the help message still says C-n despite being unbound, and when you type C-n the repeat map exits contrary to what the message says.