From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Visuwesh Newsgroups: gmane.emacs.bugs Subject: bug#55977: 29.0.50; [PATCH] repeat-mode: Don't echo unset keys in help message Date: Wed, 15 Jun 2022 13:06:45 +0530 Message-ID: <877d5iidiq.fsf@gmail.com> References: <87fsk72m0b.fsf@gmail.com> <83y1xzrvn6.fsf@gnu.org> <877d5j2keu.fsf@gmail.com> <87zgif15i9.fsf@gmail.com> <86k09i5qy8.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38323"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , 55977@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 15 09:38:16 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o1NbT-0009o0-EW for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Jun 2022 09:38:15 +0200 Original-Received: from localhost ([::1]:55884 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o1NbR-0002r1-My for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Jun 2022 03:38:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55894) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o1NaI-0002pU-HY for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2022 03:37:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42463) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o1NaI-0001yl-8y for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2022 03:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o1NaI-0004BU-5h for bug-gnu-emacs@gnu.org; Wed, 15 Jun 2022 03:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Jun 2022 07:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55977 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55977-submit@debbugs.gnu.org id=B55977.165527862016074 (code B ref 55977); Wed, 15 Jun 2022 07:37:02 +0000 Original-Received: (at 55977) by debbugs.gnu.org; 15 Jun 2022 07:37:00 +0000 Original-Received: from localhost ([127.0.0.1]:36360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1NaF-0004BC-QH for submit@debbugs.gnu.org; Wed, 15 Jun 2022 03:36:59 -0400 Original-Received: from mail-pj1-f68.google.com ([209.85.216.68]:53841) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o1NaB-0004Av-2f for 55977@debbugs.gnu.org; Wed, 15 Jun 2022 03:36:58 -0400 Original-Received: by mail-pj1-f68.google.com with SMTP id a10so10491877pju.3 for <55977@debbugs.gnu.org>; Wed, 15 Jun 2022 00:36:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=WHh/hCcidYHw1qK42uqmG5zeNnTXKY+A2qrro1wkGxE=; b=kPblg9ipurToCYxw1URpGxrqZ3SU/oc22jOTzQzcRUl4VE+GXFFNe1ocvwNIgUmv6B K3186I93KVnZB/F69lhsy9uiFJKNkoXGqChYEiPxwZn8M/Pu/k8IpuiR7iE8dvrWSANO MYXu3M8pUBALoalYSW5JRalocuX4qgpW/YWKN/a/JEN2c8RsV7MrDDDd8eSJgcOlVSdp CP/fuRrP548NhPAtkXS26FbhVBlQ2MfB7iuqjWS7oVL2g3XPaoDsPmFJXNUkijLnF0XE PyeK4ZjbfNseUq9SNVRXjNKcWJ/ud0jHNziZOFAXAN6+FHUrep5IFIvHtdOpStPK3hfK qMJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=WHh/hCcidYHw1qK42uqmG5zeNnTXKY+A2qrro1wkGxE=; b=mJHd18/aTnZc8oRWyyutw/hDv+T+qh8AQeCOSoItltrXzOnh5ULx8MGeXB0lRORfzM OhnUyUZybDT+zCrtd+TRgzqjAIiCdYJTPVB30w/M4I+fuS9YyWenAZ2/qKSjj1NvzLSv OVSp/cQNh8OQwNyO+cWOiKVLl7dWuGqdc4d4CtU2ufuIhrdERggWOOvgpYZ9DAA7ivzO 1tmohzVrsIKvpsFklHGmaAsRJRU/hJIVysqIHG6KpZfZJ7Zq2SaV7UuwX0xLWDfXaLjv /LqGm47IcksyWTsqiGWyzcfgwacVrCewhvVmECFa3m3cTY77kqUhsKfmwYfPyQr6wAt3 rLUg== X-Gm-Message-State: AJIora8HVwIBwwYtwucev7oK7yyRsvpx3kaGoT/figrJZjR0ew6x8/XI qLg8YbtPgT5+hDfAV8xtO0k= X-Google-Smtp-Source: AGRyM1tU2ZdCWPO8Jq1w9e8x+/WjYbKsjjRfux6rKDn3ir2LBD2gBrEA0t8sFqFqu4p2KraBxJSf9Q== X-Received: by 2002:a17:902:ba81:b0:168:cca6:1b2f with SMTP id k1-20020a170902ba8100b00168cca61b2fmr7949573pls.84.1655278609134; Wed, 15 Jun 2022 00:36:49 -0700 (PDT) Original-Received: from localhost ([49.204.134.215]) by smtp.gmail.com with ESMTPSA id z10-20020aa785ca000000b0051b95c76752sm8952910pfn.153.2022.06.15.00.36.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jun 2022 00:36:48 -0700 (PDT) In-Reply-To: <86k09i5qy8.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 15 Jun 2022 10:25:03 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:234556 Archived-At: [=E0=AE=AA=E0=AF=81=E0=AE=A4=E0=AE=A9=E0=AF=8D =E0=AE=9C=E0=AF=82=E0=AE=A9= =E0=AF=8D 15, 2022 10:25] Juri Linkov wrote: > close 55977 29.0.50 > thanks > >>>>> repeat-mode echoes unset keys in the help message since it doesn't ch= eck >>>>> for non-nil value of command bound to key; will attach patch once I g= et >>>>> the bug number. >>>> >>>> Thanks, but can you please show a recipe from "emacs -Q", to >>>> understand better what problem are you trying to fix? >>> >>> Sure. >>> >>> 1. M-x repeat-mode RET. >>> 2. C-h n. >>> 3. M-: (define-key outline-navigation-repeat-map (kbd "C-n") nil). >>> 4. C-c @ C-n. Notice how the help message still says C-n despite >>> being unbound, and when you type C-n the repeat map exits >>> contrary to what the message says. >> >> Oh, looks like if I give `define-key' a non-nil REMOVE argument, then >> C-n is no longer displayed in the help message. > > Indeed, the REMOVE removes a key, but nil is also a valid way to undefine= a key, > so now your patch is pushed to master, thanks. Great, thanks!