From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#56561: 29.0.50; Infloop in try_window Date: Sat, 16 Jul 2022 18:34:17 +0800 Message-ID: <877d4djqhi.fsf@yahoo.com> References: <874jzjwmhn.fsf@md5i.com> <83v8rzsdd1.fsf@gnu.org> <878rovxqjo.fsf@md5i.com> <83sfn2sy19.fsf@gnu.org> <83lesusl4w.fsf@gnu.org> <87lesumqgf.fsf@yahoo.com> <83ilnysbc5.fsf@gnu.org> <83fsj2s8fg.fsf@gnu.org> <83cze6s7xt.fsf@gnu.org> <83bktqs724.fsf@gnu.org> <878rotlpck.fsf@yahoo.com> <834jzhsj1a.fsf@gnu.org> <87v8rxk3eb.fsf@yahoo.com> <83zgh9r2he.fsf@gnu.org> <87lestk18e.fsf@yahoo.com> <83y1wtqzqp.fsf@gnu.org> <87edyljvfs.fsf@yahoo.com> <83tu7hqvq1.fsf@gnu.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17588"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: mwd@md5i.com, 56561@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 16 12:35:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oCf8j-0004Ot-2t for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Jul 2022 12:35:13 +0200 Original-Received: from localhost ([::1]:54346 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oCf8i-00075x-1P for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Jul 2022 06:35:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43848) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCf8Z-00075p-6C for bug-gnu-emacs@gnu.org; Sat, 16 Jul 2022 06:35:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45240) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oCf8Y-0004pO-Ta for bug-gnu-emacs@gnu.org; Sat, 16 Jul 2022 06:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oCf8Y-0000Ki-Na for bug-gnu-emacs@gnu.org; Sat, 16 Jul 2022 06:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Jul 2022 10:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56561 X-GNU-PR-Package: emacs Original-Received: via spool by 56561-submit@debbugs.gnu.org id=B56561.16579676781224 (code B ref 56561); Sat, 16 Jul 2022 10:35:02 +0000 Original-Received: (at 56561) by debbugs.gnu.org; 16 Jul 2022 10:34:38 +0000 Original-Received: from localhost ([127.0.0.1]:42995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCf8A-0000Jg-D2 for submit@debbugs.gnu.org; Sat, 16 Jul 2022 06:34:38 -0400 Original-Received: from sonic301-31.consmr.mail.ne1.yahoo.com ([66.163.184.200]:41158) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCf89-0000JU-1x for 56561@debbugs.gnu.org; Sat, 16 Jul 2022 06:34:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657967670; bh=ykh59TFp+N4RCxkwx+jkewBkQ1TqZtrzU1sNuwNO+Uw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=XIiLhEkSTCKv/YDVs48AhCbsNPv2cbM+o76hgKn2sBKnhFGOuBXPdXqZr5sJDJgd9CXpksL4sQWE0G94G/2JEtt1e8NTn7/xo/XxMFJycddL/zazLSDEYuJoybQEnJRya2pUtSYgOxYVdW11zXrYtmCINUeMXgd0rNn3oXfmAaLGeSRnJ2Xi47Ymsgpr+EXxVVxPdsg3vvOSWcE4ieys9G2To49fRmG70Pjwy1KgUmEvrTIdPm9dXVn3rFbkcapQArLRjyf9Q2buizWSsBfr3ZbRMMTqoy7u3IcTwZWez2WAKSk7uxbwpapLro0CxvuMfxABaoBQWjXlOdtQRofoFQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657967670; bh=Mc++nnGKa1k4o1dDZ42Uo5uKLFh7FUkAgkHZz2qN1w+=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=bMb8tf8v7qde1I5SYVytYa9ZsHr32MM/y3/jAZMYxcvJ/xJYKJdy6oZ29ggdTKjojwJz/pEHkmGpz+kgtBnlm9+ZhuQdgaGruGVXBhKnRUoUWOQH872/mioFGyXzCTe6o8b6qpKUE4TxwsbvYSxsDAHiuF233igiBfkhOvilJnd/zj4/nJkZ5HO6AQOvEkePOCVnGbwO+Yro4D2fNVvC3hJtdKQbpdbrlqpY/ukki+SPv7TYIea12qPEhmxIlAyerI+xGrwjW0p4aS3wi6VpItM33MjzzhlndG6rWg8LbpE3H3MuiieG2uKNiAO2J2c7aJGw8prqMNEzeTLLPcd1TA== X-YMail-OSG: 41nHMsgVM1mcL27btTp2DCQNnOKcGO0f18mNyjV9xwLPODjtn840jcSk4Bz5JGO miUB25AanHTbAA1LoNydfhoBSDCdesSvcQt3Edu6FxJ6ohEXGoRDBJYESZHAvryVIX7Sok1ox9DF VaT6aG48vP3WeoWe2XxrGECtPwAJVsUD7TO1eqYWJefTtWxdlC8LPXiNPr.kDKvSxBpo92fTkxaX 7qy7wZEYG__Jlf0nnho8V71mTVQJE1csKCxDfBvvLmr_WTEB8NArmYozjoWhiju64YkCis8cUe6n stomkCKSM9v_WRNyG5eYlOaWyvWrOPY7V6j1V9UBmoNQ7xD.2CQTO6nSahU0yPKtgpUWqvqJ3L7t efJCAkywSzgZIflWhPTYyFowz217nknFeHf0LwZ4NPW.JIumhIgY5c8oiUghd8aqzbCUc3ODVc.T yEIxKsFrQUmWCfhad14x_jpnhWqJE.K00gr_U05h_IvT5q32EQKogbok_drln8QNUNQArgKxZryw oNU4AIoklVmSdopAHe7V8nK6dO.5h8yZDimUcEu74c5hHhkmxeEJ7d1VUQMP_GEDkFm5rMrnKCt5 YzJKFFO5b8YWZqQ_qPdx.vnoR1t_6fi5mFI8ZGhHrSsbtP.9rRkiEuAePLx5TaHJHNl3gefSivhF bG9vcqnCyybRJfNhCAPnsylI0vegy3xRHyh8Tuhnc0DyQn9He1dSVZokq6P.OEGHdCuZ7RakEv1v T.hCKJ7let5KrUY_HXxINoFulY.Kg0CrBTFzcGwMGrPyGfPeFXs139Fmw1bTkhCY8ZWvehoQj1Qc RgepMauPo.zMSIDkFKmhlHhmXIwwJUFf4CSr2pNLXA X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.ne1.yahoo.com with HTTP; Sat, 16 Jul 2022 10:34:30 +0000 Original-Received: by hermes--canary-production-sg3-67975bbd4b-mtf9g (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 51f9ae5e1a6db2d11f9569eb94ecec30; Sat, 16 Jul 2022 10:34:23 +0000 (UTC) In-Reply-To: <83tu7hqvq1.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 16 Jul 2022 11:59:18 +0300") X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237163 Archived-At: Eli Zaretskii writes: >> The point I was making was that aborting in such a situation (when there >> is no row where ends_at_zv_p is true) will result in false positives >> when the tooltip is intentionally too small to display the entire text. > Yes, and so this situation should be detected, and we should avoid > triggering the assertion violation in that case. Hmm. I might've missed where you explained that, but how would I go about detecting that situation? The way I understand the code is that we set the window dimensions to the max tooltip size, create a glyph matrix of that size, and then call try_window. Thanks.