unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#56972: 29.0.50; nntp-send-authinfo error because netrc-parse can't handle multibytes
@ 2022-08-04 12:04 Kevin Brubeck Unhammer
  2022-08-04 13:38 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 4+ messages in thread
From: Kevin Brubeck Unhammer @ 2022-08-04 12:04 UTC (permalink / raw)
  To: 56972

nntp-send-authinfo uses netrc-parse to parse ~/.authinfo.gpg, but
netrc-parse (unlike auth-source) uses base64-encode-string which as of
https://lists.gnu.org/archive/html/bug-gnu-emacs/2021-12/msg01599.html
throws an error if it sees a multibyte. So if there's a multibyte
somewhere in the netrc file, we get this on trying to connect with nntp

Unable to open server gmane due to: Multibyte character in data for base64 encoding

(even if we don't use any auth info for connecting).

I'm guessing nntp-send-authinfo could be changed to using
auth-source-netrc-parse, though I don't actually use authinfo for
connecting to nntp so I have no way to test that use-case.





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#56972: 29.0.50; nntp-send-authinfo error because netrc-parse can't handle multibytes
  2022-08-04 12:04 bug#56972: 29.0.50; nntp-send-authinfo error because netrc-parse can't handle multibytes Kevin Brubeck Unhammer
@ 2022-08-04 13:38 ` Lars Ingebrigtsen
  2022-08-05  8:09   ` Kevin Brubeck Unhammer
  0 siblings, 1 reply; 4+ messages in thread
From: Lars Ingebrigtsen @ 2022-08-04 13:38 UTC (permalink / raw)
  To: Kevin Brubeck Unhammer; +Cc: 56972

Kevin Brubeck Unhammer <unhammer@fsfe.org> writes:

> I'm guessing nntp-send-authinfo could be changed to using
> auth-source-netrc-parse, though I don't actually use authinfo for
> connecting to nntp so I have no way to test that use-case.

Yes -- there's no longer any reason to parse the authinfo file twice
this way now that `nntp-authinfo-file' has been removed, so I've
adjusted the code to just use auth-source in Emacs 29.  Can you check
that this really fixes the issue you were seeing?






^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#56972: 29.0.50; nntp-send-authinfo error because netrc-parse can't handle multibytes
  2022-08-04 13:38 ` Lars Ingebrigtsen
@ 2022-08-05  8:09   ` Kevin Brubeck Unhammer
  2022-08-05 11:58     ` Lars Ingebrigtsen
  0 siblings, 1 reply; 4+ messages in thread
From: Kevin Brubeck Unhammer @ 2022-08-05  8:09 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: 56972

Lars Ingebrigtsen <larsi@gnus.org> čálii:

> Yes -- there's no longer any reason to parse the authinfo file twice
> this way now that `nntp-authinfo-file' has been removed, so I've
> adjusted the code to just use auth-source in Emacs 29.  Can you check
> that this really fixes the issue you were seeing?

That does seem to resolve the issue for me – thank you :-)

best regards,
Kevin





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#56972: 29.0.50; nntp-send-authinfo error because netrc-parse can't handle multibytes
  2022-08-05  8:09   ` Kevin Brubeck Unhammer
@ 2022-08-05 11:58     ` Lars Ingebrigtsen
  0 siblings, 0 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2022-08-05 11:58 UTC (permalink / raw)
  To: Kevin Brubeck Unhammer; +Cc: 56972

Kevin Brubeck Unhammer <unhammer@fsfe.org> writes:

> That does seem to resolve the issue for me – thank you :-)

Thanks for checking; closing this bug report, then.






^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-08-05 11:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-04 12:04 bug#56972: 29.0.50; nntp-send-authinfo error because netrc-parse can't handle multibytes Kevin Brubeck Unhammer
2022-08-04 13:38 ` Lars Ingebrigtsen
2022-08-05  8:09   ` Kevin Brubeck Unhammer
2022-08-05 11:58     ` Lars Ingebrigtsen

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).