From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#57334: 28.1; Fix wdired with (dired '(dir f1 f2 ...)) Date: Mon, 22 Aug 2022 16:54:54 +0200 Message-ID: <877d3049c1.fsf@gnus.org> References: <878rng23aq.fsf@posteo.net> <877d30bmki.fsf@gnus.org> <875yik49ic.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38372"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 57334@debbugs.gnu.org To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 22 17:54:40 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQ9l9-0009o4-Ph for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Aug 2022 17:54:39 +0200 Original-Received: from localhost ([::1]:58928 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oQ9l8-00026E-Lc for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Aug 2022 11:54:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59340) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQ9Gv-0007Ei-3U for bug-gnu-emacs@gnu.org; Mon, 22 Aug 2022 11:23:25 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51732) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oQ9Gu-00074X-Q0 for bug-gnu-emacs@gnu.org; Mon, 22 Aug 2022 11:23:24 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oQ8qQ-00034V-Dp for bug-gnu-emacs@gnu.org; Mon, 22 Aug 2022 10:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Aug 2022 14:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57334 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 57334-submit@debbugs.gnu.org id=B57334.166118010611734 (code B ref 57334); Mon, 22 Aug 2022 14:56:02 +0000 Original-Received: (at 57334) by debbugs.gnu.org; 22 Aug 2022 14:55:06 +0000 Original-Received: from localhost ([127.0.0.1]:41450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ8pV-00033C-Uv for submit@debbugs.gnu.org; Mon, 22 Aug 2022 10:55:06 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:55600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ8pT-00032c-Gz for 57334@debbugs.gnu.org; Mon, 22 Aug 2022 10:55:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=49s/J6I5M7yxlL/ZdV7ZkqqwU4qF+qcH8v86IdtZvl8=; b=CVghB6O86B/B+5bWuu2zA88gjz veYhHJ9t3IABRINqQZJAjOS6dxDmvq3koBZ3sXykXpgBXfRB9l1hqeAdR/K2j0aF95ql6yNKJrk6Q l/g+jiaINoT03nRDNkKe55tg4YYQOUrBW2kyoXyZuUGSZ9e9jn8TscTJkj/MOJJQGMXw=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQ8pL-0006eP-7d; Mon, 22 Aug 2022 16:54:57 +0200 In-Reply-To: <875yik49ic.fsf@posteo.net> (Thierry Volpiatto's message of "Mon, 22 Aug 2022 14:42:31 +0000") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEXv4c/BtaeJgHdW UUv///8yXQ++AAAAAWJLR0QEj2jZUQAAAAd0SU1FB+YIFg40ChiqJl4AAAGkSURBVDjLXVOLFcMg CARdAM0Cigsksv9uBVFjw2sT4/HxDgQkWPauzAIXoJgpI3aCYlv6wAKx9atH5tYqCzexVe9sgDTO 7elcxX79ynLxUzQVdw5Xy5wSM+tf/TgXQC7wb+wvZPoA8zvKnedOhUBNhukBMZkHU7jVFfWTrdLK glBj13c7I4pXiY+7vBGEZdcAnBHiuRK8iqVh80MgllVsPGlTCWU40wSS5wlSNIKm/1eIZfhApnEO 1S2xBX7aFYQly/Axf+V+H+G2OwlaLlxAdD5pSTTkmQz/0jsPTw4ZPoYzrGn9UHDEBTribWvL+Q7X 0V6smGmxul4ghUe73eaR0Iu3fp6NVI84glD7gy9j2sSCSBkk0oiqWz0HtlVY/QVvtbWW1hC4DJcK WbFOgKgeco23Z3cyx8XawNgKe2UAvnyS8qDBIi2JNJWuaaiiRUdOnBkZkRC+VnVa3EXnzC+FF692 13CfzP+7M/j3pIR2o+Zs6+CmCaRzNHbxHBIvtUuU0uwI8pxOCgQ2HhkcsI7Q8tKhhUsB624sKDek GT5AB3S8uPwAvKgswflmujsAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjItMDgtMjJUMTQ6NTI6MTAr MDA6MDCcT/BSAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIyLTA4LTIyVDE0OjUyOjEwKzAwOjAw7RJI 7gAAAABJRU5ErkJggg== X-Now-Playing: Jordan Rakei's _Blue Note Re:imagined (1)_: "Wind Parade" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240434 Archived-At: Thierry Volpiatto writes: >>> + (setcdr dired-directory [...] > Of course it have to be changed, it has been modified by wdired at this point, > so if you want to redisplay a dired buffer reflecting your changes you > have to modify it no ? I don't understand what you mean. >> which we shouldn't do. > > You already do it when DIRNAME is a string isn't it? Strings can't be modified. >> (It may even be a constant.) > > Can you elaborate? If the list is in purespace, for instance, it can't be modified. In case there's any misunderstanding here, I'm talking about the destructive alteration of the list pointed to by dired-directory by that `setcdr' -- not the altering of the dired-directory variable. So the safe change here would be something like (setq dired-directory (cons (car dired-directory) (mapcar ...)))