From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Protesilaos Stavrou Newsgroups: gmane.emacs.bugs Subject: bug#57424: Perceptibility of display-fill-column-indicator-mode Date: Fri, 26 Aug 2022 09:27:55 +0300 Message-ID: <877d2vh638.fsf@protesilaos.com> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34416"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Notmuch/0.37 (https://notmuchmail.org) Emacs/29.0.50 (x86_64-pc-linux-gnu) To: Christopher Dimech , 57424@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 26 08:29:40 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oRSqY-0008jm-DP for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Aug 2022 08:29:38 +0200 Original-Received: from localhost ([::1]:36846 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oRSqW-0003DH-PK for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Aug 2022 02:29:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37470) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRSpy-0003D8-Nw for bug-gnu-emacs@gnu.org; Fri, 26 Aug 2022 02:29:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33878) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oRSpy-0000Hh-4s for bug-gnu-emacs@gnu.org; Fri, 26 Aug 2022 02:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oRSpx-0003l7-S7 for bug-gnu-emacs@gnu.org; Fri, 26 Aug 2022 02:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Aug 2022 06:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57424 X-GNU-PR-Package: emacs Original-Received: via spool by 57424-submit@debbugs.gnu.org id=B57424.166149528814377 (code B ref 57424); Fri, 26 Aug 2022 06:29:01 +0000 Original-Received: (at 57424) by debbugs.gnu.org; 26 Aug 2022 06:28:08 +0000 Original-Received: from localhost ([127.0.0.1]:51860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRSp5-0003jo-Ti for submit@debbugs.gnu.org; Fri, 26 Aug 2022 02:28:08 -0400 Original-Received: from relay8-d.mail.gandi.net ([217.70.183.201]:36953) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRSp3-0003jJ-Hb for 57424@debbugs.gnu.org; Fri, 26 Aug 2022 02:28:06 -0400 Original-Received: (Authenticated sender: public@protesilaos.com) by mail.gandi.net (Postfix) with ESMTPSA id 9050E1BF207; Fri, 26 Aug 2022 06:27:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protesilaos.com; s=gm1; t=1661495279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GhBV0Fk1mi1CjFfAzr+2EdyYO+BN2USc2XrX51US/9Y=; b=lJh8re75N2NpLmh5847cKROooT+y5E/ssDrwv9QVOLZzEMc9eMp6R3iM8jkWgLl+N7QxQy pca2MLDWa/yu5fFW1FvCCOOPjsBuKZPMVXKlDyqgvytB/9ntK14c3dGay/8jMgxVl40V6c ePukFVlpuHBVOEgQ5+MjQvTPwtYumIefOy9n8jT20DNWiRCUNt6EeMII1Ai8MUaVZxkapL EcmD5k09A+qKPkP0+Tl5icqvWiokl2KwhBwuKtl8VkODxm2nHNb73ZyPLLqV+4d4u5bcWZ b98SRARdMpjIHfBM5F4xqVyR1FzMX7RuwU+z7cM+l72G6aSvxMeJFO9gP+yELw== In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240775 Archived-At: > From: Christopher Dimech > Date: Fri, 26 Aug 2022 07:44:23 +0200 > > Have followed the customisation discussion about > display-fill-column-indicator-mode > > Have consulted with Protesilaos Stavrou, author of > modus-themes. I agree that the default indicator character is > too thin. Changing the character to something wider does not > change things much. A solution that works is that of setting a > background colour, rather than changing the foreground colour . Christopher, please don't take words out of context. State what you think the bug is without involving me or other people. My involvement in this only concerns the modus-themes. I explained via a private channel why the modus-themes style the fill-column-indicator like this: ;; Not actual code, but true to form: (set-face-attribute 'fill-column-indicator nil :height 1 :background "gray50" :foreground "gray50") The default face of fill-column-indicator creates a dashed line when (i) the user applies a default font with a tall line height, (ii) increases the value of 'line-spacing', (iii) applies an increased height to certain elements, such as scaling the faces of Org headings. Because of these common scenaria, users would tell me that the visuals looked broken. Changing the face, as shown above, produces a contiguous line. This is a compromise, so that I stop getting the same issue over and over that the themes are broken. > [... 15 lines elided] > The only way to ensure a contiguous vertical line is to > explicitly set the :height of the face to a small value. This > brings out the perceptibility problem. > > Studying carefully WCAG 2.1, Section 1.4.3 Contrast (Minimum), > the contrast ratio is also subject to change according to the > thinness of the characters. For instance, With larger thicker > text, the contrast ratio of at least 4.5:1 can be modified to to > at least 3:1. > > I see the requirement of a contiguous indicator line is mainly about > aesthetics. But practical usability should be of higher concern. I shared code with you on how to change the face to the effect that it widens the width of the line. Please use it. I also stated in clear terms why this decision was made. You insist on dismissing it as "aesthetics". There is nothing more I can do about it. -- Protesilaos Stavrou https://protesilaos.com