From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#54863: 28.1; hook move-frame-functions not working in emacs 28.1 Date: Tue, 06 Sep 2022 15:24:22 +0200 Message-ID: <877d2gskjd.fsf@gnus.org> References: <0ee6195e-4561-d9ff-e30b-68707ce14b9e@gmx.at> <87r162wweb.fsf@yahoo.com> <877d2gu4u0.fsf@gnus.org> <87a67cbt0t.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27907"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: James Ahlborn , martin rudalics , 54863@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 06 16:53:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVZwt-000713-MX for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Sep 2022 16:53:11 +0200 Original-Received: from localhost ([::1]:48794 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oVZws-0002gr-LR for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Sep 2022 10:53:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57184) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVYZc-0008B4-QL for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2022 09:25:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33185) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oVYZc-0007sX-GG for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2022 09:25:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oVYZa-00006I-AJ for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2022 09:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Sep 2022 13:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54863 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54863-submit@debbugs.gnu.org id=B54863.1662470686355 (code B ref 54863); Tue, 06 Sep 2022 13:25:02 +0000 Original-Received: (at 54863) by debbugs.gnu.org; 6 Sep 2022 13:24:46 +0000 Original-Received: from localhost ([127.0.0.1]:50117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVYZK-00005e-1s for submit@debbugs.gnu.org; Tue, 06 Sep 2022 09:24:46 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:57764) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVYZH-00005F-65 for 54863@debbugs.gnu.org; Tue, 06 Sep 2022 09:24:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=IP//SUCR0piD7Lh1Zywqp1fIF0qBq7HFJd7HAOQ2nV8=; b=kx1rRhv+GGbBgMWykehdtq2pIy TlMTcjOdUFaY4ksbZNYD71xh5EOvTeUghm33tOAnjsUuxsopPSpAgPb6/M97mURK+2O0a2rZ37rTR qOSxpXlYJIC1eHYPROXmThwrCzTIqn99td/hQMA2odHzt7JXkolpAYASojAcMzl6pCYw=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVYYz-00050o-3C; Tue, 06 Sep 2022 15:24:27 +0200 In-Reply-To: <87a67cbt0t.fsf@yahoo.com> (Po Lu's message of "Tue, 06 Sep 2022 20:13:06 +0800") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEWqmqSOSFhbNET/ //9e1sLLAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+YJBg0XKWtb4DsAAAGJSURBVCjPRZIxT/MwEIaP DBV06lJEMzHQofyLdkAoUxU1lpKJoY0S/woaQQemEhGLL1OEHCt+f+V3tgK9xXp873u27o7myV9s SeIvuhHkBT5gAOHAwmZwlDGEGCZOZB87KjPYHEZ6KIS77iX6gGVsgCkejRAMucsUV+hNR6lBBrWh leTSU77/Z48U1tE9zVMFDEQ38aSjRRZ5eGpZNhdc7m1GQcywFJGHzYlhlUQGb/e0Vk6WTH3mE3gZ gejYbNhzcPCwOrpqS/Z87+QQOwh3N6b5WqaB+87tfqGar4ckSIcXCnWGnd7fVpU905WeRrgz5n1d vlJoJ5G9jtV6g1duVST1c9CImmULpNyRujn4vqGFRfWeyxFwqFUizNm3t0cM2Xho0fdKJAm2tPeZ U1wq71FW91XuPSVnNKqKDwfS9KaqS9Ge3Xw0UCknYJADUNel3W+psHDgPDsquJ8SPzWPbjaC4Zm2 3ShrzTh6idyeWCZ/l8L8SFf6oPG7I5wZMI7bPXpZJE0zusR/q00b6GxEIYUAAAAldEVYdGRhdGU6 Y3JlYXRlADIwMjItMDktMDZUMTM6MjM6NDErMDA6MDAevdF/AAAAJXRFWHRkYXRlOm1vZGlmeQAy MDIyLTA5LTA2VDEzOjIzOjQxKzAwOjAwb+BpwwAAAABJRU5ErkJggg== X-Now-Playing: Talking Heads's _More Songs About Buildings and Food_: "Found A Job" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241677 Archived-At: Po Lu writes: > I missed a call to kbd_buffer_store_event after the last XSETINT. > What happens if you add: > > kbd_buffer_store_event (&ie); With the following patch, the hook fires when I move the frame on Macos. diff --git a/src/nsterm.m b/src/nsterm.m index 6c6151701b..bc4e072ea0 100644 --- a/src/nsterm.m +++ b/src/nsterm.m @@ -7912,6 +7912,7 @@ - (void)windowDidMove: sender NSRect r = [win frame]; NSArray *screens = [NSScreen screens]; NSScreen *screen = [screens objectAtIndex: 0]; + struct input_event ie; NSTRACE ("[EmacsView windowDidMove:]"); @@ -7922,12 +7923,14 @@ - (void)windowDidMove: sender emacsframe->left_pos = NSMinX (r) - NS_PARENT_WINDOW_LEFT_POS (emacsframe); emacsframe->top_pos = NS_PARENT_WINDOW_TOP_POS (emacsframe) - NSMaxY (r); - // FIXME: after event part below didExitFullScreen is not received - // if (emacs_event) - // { - // emacs_event->kind = MOVE_FRAME_EVENT; - // EV_TRAILER ((id)nil); - // } + if (emacs_event) + { + ie.kind = MOVE_FRAME_EVENT; + XSETFRAME (ie.frame_or_window, emacsframe); + XSETINT (ie.x, emacsframe->left_pos); + XSETINT (ie.y, emacsframe->top_pos); + kbd_buffer_store_event (&ie); + } } }