From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries Date: Tue, 06 Sep 2022 16:58:07 +0200 Message-ID: <877d2gczy8.fsf@gmail.com> References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <871qsooenn.fsf@posteo.net> <87o7vsfu5p.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19089"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , Eli Zaretskii , 55039@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Sep 06 16:59:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVa2h-0004iM-B7 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Sep 2022 16:59:11 +0200 Original-Received: from localhost ([::1]:33738 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oVa2g-0006PF-D9 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Sep 2022 10:59:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35384) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oVa2Y-0006N8-JX for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2022 10:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35366) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oVa2Y-0000ME-8m for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2022 10:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oVa2Y-0003Xm-5D for bug-gnu-emacs@gnu.org; Tue, 06 Sep 2022 10:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Sep 2022 14:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55039 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch Original-Received: via spool by 55039-submit@debbugs.gnu.org id=B55039.166247629713516 (code B ref 55039); Tue, 06 Sep 2022 14:59:02 +0000 Original-Received: (at 55039) by debbugs.gnu.org; 6 Sep 2022 14:58:17 +0000 Original-Received: from localhost ([127.0.0.1]:52298 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVa1p-0003Vv-E5 for submit@debbugs.gnu.org; Tue, 06 Sep 2022 10:58:17 -0400 Original-Received: from mail-wr1-f48.google.com ([209.85.221.48]:38869) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oVa1n-0003VX-PU for 55039@debbugs.gnu.org; Tue, 06 Sep 2022 10:58:16 -0400 Original-Received: by mail-wr1-f48.google.com with SMTP id b5so15885186wrr.5 for <55039@debbugs.gnu.org>; Tue, 06 Sep 2022 07:58:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=38yMU45UYoB0GMo2UD6bfvjn4LTxkzTx1mECg5Q65YE=; b=XkQvVkcTP3RRfserEIqjqOm35MjMLYF+xXwbTRViYVKDe/hePnnqNDUxHulUaZUDcG dw8wBXEtKqkWow95ju4Vo7QsPxcGqhKxw553vQpZe9vROSYl7jQaT9G8MXoMw/QVrVtZ 2SD8fUqPCmxZkrA30CIOxQQVPJ4Y6jr5gkTeXhm2hatUzeyKnjqug/6HNojpfs+R0K3I j4KKXpDxhiYFWjHhzXgEK6gArevBHTbGWS9eCPnG612IyIEQw9Ppey54QdS8okJ7Ef/H NvTA3qDWFKDSzVxtWwBYF0Zac/Be47htTHn9jisBtRYv1rr0m7odTZr6dKoL9rI+9RV3 Q6Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=38yMU45UYoB0GMo2UD6bfvjn4LTxkzTx1mECg5Q65YE=; b=z44xLz94IpYWAHhwuOIUxnQikyayyJ8kqegt2k2doMoyT3UM80USccyNKh4CjZ9kq0 /GQxdGaOhkPYMurLSP+YAPVzohPE2IXJOxujaDSjTLtAfpsty/1v7fHrWEJwRLFa1G42 OLAxdaVkU4fM4g3F1Rf2WE51uA54r1Nw06gwGurqMYpgcMIum8dEHdUhguV6QmYm/B12 ra7LRNtMCRWll5vDwfxWAuHPTIDt4r7Dk7mlOsgYNgQgh4tVqXgq+nL7izUKpsUsN3ck kghb1uJA/6+qw200ewVTK8Rmnz//yvjCG/5YzwlzoxCKR4HKsoJtI8s95XWhM3naQGrF fYyA== X-Gm-Message-State: ACgBeo3Y4Z0616998j33a5NCtFDCVLvFuGbZxcybFN3qDbtQQ6Pkq4U2 +n1XY8R+AwRAnY5yrebEPxypA3niEe4QCQ== X-Google-Smtp-Source: AA6agR7B5Z8wo3H3mTh6MUqaTmHwo8UNcLDP9MaBjnuTISgYmMDpb0nzAVWQPqH3w9o1lb78hG0WQA== X-Received: by 2002:adf:f58b:0:b0:228:6504:6751 with SMTP id f11-20020adff58b000000b0022865046751mr6944477wro.3.1662476289449; Tue, 06 Sep 2022 07:58:09 -0700 (PDT) Original-Received: from rltb ([2a01:e0a:3f3:fb50:f116:dbc2:98c7:dbf1]) by smtp.gmail.com with ESMTPSA id d6-20020a5d6446000000b00224f5bfa890sm12475146wrw.97.2022.09.06.07.58.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Sep 2022 07:58:08 -0700 (PDT) In-Reply-To: <87o7vsfu5p.fsf@posteo.net> (Philip Kaludercic's message of "Tue, 06 Sep 2022 14:34:58 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241679 Archived-At: >>>>> On Tue, 06 Sep 2022 14:34:58 +0000, Philip Kaludercic said: Philip> (defun diff-add-log-current-defuns () Philip> "Return an alist of defun names for the current diff. Philip> The elements of the alist are of the form (FILE . (DEFUN...)), Philip> @@ -2374,9 +2380,11 @@ diff-add-log-current-defuns Philip> (re-search-forward diff-hunk-header-re nil t) Philip> (setq hunk-end (save-excursion (diff-end-of-hunk))) Philip> (pcase-let* ((filename (substring-no-properties Philip> - (file-relative-name Philip> - (diff-find-file-name) Philip> - (vc-root-dir)))) Philip> + (if diff-relative-names-in-cha= ngelog Philip> + (file-relative-name Philip> + (diff-find-file-name) Philip> + (vc-root-dir)) Philip> + (diff-find-file-name)))) Philip> (=3Dlines 0) Philip> (+lines 0) Philip> (-lines 0) That doesn=CA=BCt look like the code that=CA=BCs currently in master. Is th= is on top of your previous patch? Philip> Assuming nobody objects to the name of the option, should this = be Philip> documented in NEWS and/or in the Manual? Also, as the entire p= oint of Philip> the patch was that emacs.git is using relative path names, shou= ld a Philip> .dir-locals.el variable be set to ensure this is done? NEWS and .dir-locals.el definitely. I guess you could add to the "Log Buffer" node in the emacs manual if you=CA=BCre feeling inspired =F0=9F=98= =80 Robert --=20