From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: "Gerd Möllmann" <gerd.moellmann@gmail.com>
Cc: 57727@debbugs.gnu.org
Subject: bug#57727: 29.0.50; Optimize tty display updates
Date: Sun, 18 Sep 2022 00:09:33 +0300 [thread overview]
Message-ID: <877d21g12q.fsf@tcd.ie> (raw)
In-Reply-To: <m2wnaans72.fsf@Mini.fritz.box> ("Gerd Möllmann"'s message of "Sun, 11 Sep 2022 12:03:45 +0200")
Sorry for crashing the party late:
Gerd Möllmann [2022-09-11 12:03 +0200] wrote:
> +DEFUN ("tty--output-buffer-size", Ftty__output_buffer_size,
> + Stty__output_buffer_size, 0, 1, 0, doc:
> + /* Return the output buffer size of TTY.
> +
> +TTY may be a terminal object, a frame, or nil (meaning the selected
> +frame's terminal).
> +
> +A value of zero means TTY uses the system's default value. */)
> + (Lisp_Object tty)
> +{
> + struct terminal *terminal = decode_tty_terminal (tty);
> + return make_fixnum (terminal->display_info.tty->output_buffer_size);
What should tty--output-buffer-size do when called from a graphical
terminal (i.e. when decode_tty_terminal returns NULL)?
It currently crashes, but that's what every other C program is doing,
very banal. Maybe Emacs should do something more eccentric, like return
0 or -1, signal an error, or do my taxes as consolation.
> +DEFUN ("tty--set-output-buffer-size", Ftty__set_output_buffer_size,
> + Stty__set_output_buffer_size, 1, 2, 0, doc:
> + /* Set the output buffer size for a TTY.
> +
> +SIZE zero means use the system's default value. If SIZE is
> +non-zero,this also avoids flushing the output stream.
> +
> +TTY may be a terminal object, a frame, or nil (meaning the selected
> +frame's terminal).
> +
> +This function temporarily suspends and resumes the terminal
> +device. */)
> + (Lisp_Object size, Lisp_Object tty)
> +{
> + if (!TYPE_RANGED_FIXNUMP (size_t, size))
> + error ("Invalid output buffer size");
Just curious: given this is an internal "--" function, do we want to
tell the user what a valid size would be? E.g. along the lines of:
size_t sz = check_uinteger_max (size, min (MOST_POSITIVE_FIXNUM, SIZE_MAX));
Or would that be too much?
BTW, is there a known upper limit for the buffer size in the OS?
> + Fsuspend_tty(tty);
> + struct terminal *terminal = decode_tty_terminal (tty);
Here, terminal should theoretically be non-NULL, as Fsuspend_tty would
have otherwise signalled. Maybe we should eassert this assumption, or
explicitly check for NULL?
Thanks,
--
Basil
next prev parent reply other threads:[~2022-09-17 21:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-11 10:03 bug#57727: 29.0.50; Optimize tty display updates Gerd Möllmann
2022-09-11 11:18 ` Lars Ingebrigtsen
2022-09-12 6:02 ` Gerd Möllmann
2022-09-12 11:21 ` Eli Zaretskii
2022-09-11 13:49 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-12 6:33 ` Gerd Möllmann
2022-09-12 11:29 ` Eli Zaretskii
2022-09-12 11:52 ` Gerd Möllmann
2022-09-12 13:15 ` Gerd Möllmann
2022-09-12 14:18 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-13 5:53 ` Gerd Möllmann
2022-09-13 11:33 ` Eli Zaretskii
2022-09-13 11:36 ` Lars Ingebrigtsen
2022-09-13 12:44 ` Gerd Möllmann
2022-09-13 13:48 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-09-13 13:53 ` Gerd Möllmann
2022-09-17 13:34 ` Gerd Möllmann
2022-09-17 21:09 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-09-18 5:34 ` Gerd Möllmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877d21g12q.fsf@tcd.ie \
--to=bug-gnu-emacs@gnu.org \
--cc=57727@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=gerd.moellmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).