From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs,gmane.emacs.erc.general Subject: bug#51753: bug#55540: 29.0.50; ERC launches autojoin-channels in current frame instead of original frame Date: Wed, 21 Sep 2022 23:22:50 -0700 Message-ID: <877d1wgc79.fsf@neverwas.me> References: <878rqwjqua.fsf@codeisgreat.org> <87a6b92ers.fsf@neverwas.me> <875ylxm07b.fsf@codeisgreat.org> <87fsl0zo2e.fsf@neverwas.me> <87a68cnss7.fsf_-_@neverwas.me> <87sfm3tro1.fsf@codeisgreat.org> <87o7vsu5pc.fsf_-_@gnus.org> <87o7vs38yp.fsf@neverwas.me> <87y1uwr47b.fsf@gnus.org> <874jxj282o.fsf@neverwas.me> <87mtbbmjho.fsf@gnus.org> <87pmfq198w.fsf@neverwas.me> <87y1uc150p.fsf@codeisgreat.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5683"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 55540@debbugs.gnu.org, Lars Ingebrigtsen , emacs-erc@gnu.org, 51753@debbugs.gnu.org To: Pankaj Jangid Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 22 08:26:27 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1obFfG-0001I8-Pa for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 22 Sep 2022 08:26:27 +0200 Original-Received: from localhost ([::1]:38832 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1obFfF-00085S-K2 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 22 Sep 2022 02:26:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45358) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1obFcy-00083J-BI for bug-gnu-emacs@gnu.org; Thu, 22 Sep 2022 02:24:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36868) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1obFcx-0005Y0-VA for bug-gnu-emacs@gnu.org; Thu, 22 Sep 2022 02:24:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1obFcx-0007M9-Q8 for bug-gnu-emacs@gnu.org; Thu, 22 Sep 2022 02:24:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Sep 2022 06:24:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51753 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch moreinfo Original-Received: via spool by 51753-submit@debbugs.gnu.org id=B51753.166382778528133 (code B ref 51753); Thu, 22 Sep 2022 06:24:03 +0000 Original-Received: (at 51753) by debbugs.gnu.org; 22 Sep 2022 06:23:05 +0000 Original-Received: from localhost ([127.0.0.1]:35929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obFc0-0007Jg-MO for submit@debbugs.gnu.org; Thu, 22 Sep 2022 02:23:05 -0400 Original-Received: from mail-108-mta30.mxroute.com ([136.175.108.30]:35957) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obFby-0007Ir-DA for 51753@debbugs.gnu.org; Thu, 22 Sep 2022 02:23:02 -0400 Original-Received: from mail-111-mta2.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta30.mxroute.com (ZoneMTA) with ESMTPSA id 18363dd0c690002b7a.002 for <51753@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Thu, 22 Sep 2022 06:22:54 +0000 X-Zone-Loop: 8fe811b9acdda1d3da7100b037493c67c7205a3a9a61 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=JuUNziPiWXY0xJRYnX68TPsuBUWYwOxg//vRiv+NDIg=; b=jE72GN+c7KXCcbye5azHxEYtDJ le1xGinyqxpfREJTseA0x5xBszYjJ1mqyENpJjyGlyx0Rn36AXistj7hIW4FnWhD11LqMoWkrqruq /OAgB+tA2bVrOwTwow1xkyZnXPDo+v/xf3snNdzxcZVFAqlnWPlrRttiIzymZ+w+RN51NMelCdUit 6xCtsKHrT1NKfusR2uJqBAnyEslZnDbXBzgFzlA/sUsa8mySEfD3Qj1TOB1BrbZF62iE9tvBFqKWI 6ogevQ5xqnvuAqpJ+XFumoq18bU7EAjVCuO1w71Vat5ZX3f6PeWvUa1gtdoALtcdzh4ouDuiBQf/s 3B161GhQ==; In-Reply-To: <87y1uc150p.fsf@codeisgreat.org> (Pankaj Jangid's message of "Thu, 22 Sep 2022 08:37:02 +0530") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243392 gmane.emacs.erc.general:1920 Archived-At: Hi Pankaj, Pankaj Jangid writes: > Now the behaviour is acceptable when "erc-autojoin-channels-alist" is > set to nil. i.e. the frame in which I launched "erc-tls" opens the erc > window instead of occupying the current frame. Hm, right, but I think that was always the baseline behavior, no? If not, I wonder if the recent change to the default for `erc-join-buffer' somehow affected this. > But when I have few channels in "erc-autojoin-channels-alist" then the > channels are still openning in the current frame instead of the > dedicated frame that I started for "erc-tls". Is there some setting > that I missed in the conversation for this? Looks like it, but I should have re-summarized either way. So that's my bad. > (setq erc-prompt-for-nickserv-password nil > erc-use-auth-source-for-nickserv-password t) This is unrelated (so feel free to skip ahead), but are you sure auth-source is even being consulted here? I ask because `services' isn't a default module, and your snippet doesn't modify `erc-modules', AFAICT. Regardless, adding services to the repro mix at this point would only complicate matters, so please forget I said anything. I mean, if really necessary, you can just use Libera's server-password kludge while testing (everything will still be encrypted): (erc-tls :password "$myaccount:$mypass" ...) > [...] > (setq erc-autojoin-channels-alist > '(("libera.chat" "#emacs" "#erc" "#gnus"))) Ah, looks like we're missing (setq erc-join-buffer 'frame erc-auto-query 'frame erc-reuse-frames 'displayed) Also, you *did* apply the patch and rerun make (or at least delete the .elc), right?: https://lists.gnu.org/archive/html/emacs-erc/2022-08/txtAqY2ukHPun.txt (Yeah, those changes aren't on trunk.) Anyway, please let me know if something doesn't add up. Thanks, J.P. P.S. If you want, you can use the symbol `Libera.Chat' instead of the string "libera.chat" in `erc-autojoin-channels-alist'.