unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "J.P." <jp@neverwas.me>
To: Philip Kaludercic <philipk@posteo.net>
Cc: 56514@debbugs.gnu.org, emacs-erc@gnu.org
Subject: bug#56514: ircs:// integration for rcirc (bug#56514)
Date: Tue, 08 Nov 2022 06:41:43 -0800	[thread overview]
Message-ID: <877d05jyoo.fsf__8769.00722957856$1667918566$gmane$org@neverwas.me> (raw)
In-Reply-To: <87pmiabvd5.fsf@neverwas.me>

Hi Philip,

Just a heads up: I'm in the process of possibly tweaking url-irc (and
browse-url) to better support irc:// links in internal Emacs apps. If
you're interested, this mostly concerns the second patch here:

  https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56514#22

Basically, I wanted a way to tell `url-irc-erc' whether to connect via
TLS without relying on port numbers and without changing the signature
of `url-irc-function'. Rather than mess with `func-arity' or the like,
I've opted to just hijack an existing variable from the url(-vars)
library, `url-current-object', which seems ready made for this purpose.
The idea is to simply bind it to the parsed URL object during calls to
`url-irc-function'. Please let me know if you see any downsides
to doing this or if a smarter approach comes to mind.

BTW, as the patch shows, I've left the rcirc side alone. But if you want
to handle ircs:// links without bothering with all the
`url-current-object' business above, simply arranging to switch to 'tls
whenever the port is 6697 should have you pretty well covered, I think.
Let me know if that doesn't make sense.

Thanks,
J.P.





  parent reply	other threads:[~2022-11-08 14:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87pmiabvd5.fsf@neverwas.me>
2022-07-12 12:49 ` bug#56514: 29.0.50; Improve ERC's URI scheme integration for irc:// links Lars Ingebrigtsen
     [not found] ` <87edyqzeag.fsf@gnus.org>
2022-07-13 14:44   ` J.P.
     [not found]   ` <874jzl2hsv.fsf@neverwas.me>
2022-07-13 15:55     ` Stefan Kangas
     [not found]     ` <CADwFkmkgXKH3y2i1si76V_NOuSyJENVrCLdEJ1AfDHEv9qh8jw@mail.gmail.com>
2022-07-14  7:00       ` J.P.
     [not found]       ` <874jzkuqk3.fsf@neverwas.me>
2022-11-08 14:09         ` J.P.
2022-11-08 15:16           ` Stefan Kangas
     [not found]           ` <CADwFkm=d+8wb6o_EwvKZWR7yc4tbwscgZ-YPzBnSqty42W+_Pg@mail.gmail.com>
2022-11-09 13:41             ` J.P.
2022-11-08 14:41 ` J.P. [this message]
2022-11-11 14:05 ` J.P.
     [not found] ` <87iljl4meb.fsf@neverwas.me>
2022-11-16 14:22   ` J.P.
2022-12-30 14:20 ` J.P.
2023-11-06  2:34 ` J.P.
     [not found] ` <875y2flics.fsf@neverwas.me>
2023-11-11 10:15   ` Eli Zaretskii
     [not found] <877d05jyoo.fsf@neverwas.me>
2022-11-09 13:46 ` bug#56514: ircs:// integration for rcirc (bug#56514) J.P.
     [not found] ` <875yfo1brw.fsf@neverwas.me>
2022-11-09 17:09   ` Philip Kaludercic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='877d05jyoo.fsf__8769.00722957856$1667918566$gmane$org@neverwas.me' \
    --to=jp@neverwas.me \
    --cc=56514@debbugs.gnu.org \
    --cc=emacs-erc@gnu.org \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).