From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#59458: [PATCH] Fix tracing for advanced scoring Date: Thu, 24 Nov 2022 11:39:40 -0800 Message-ID: <877czkf8g3.fsf@ericabrahamsen.net> References: <20221121213055.2387178-1-stlman@poczta.fm> <831qpsyaar.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23676"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Lars Ingebrigtsen , 59458@debbugs.gnu.org, =?UTF-8?Q?=C5=81ukasz?= Stelmach To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 24 20:40:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyI4w-0005xy-Qj for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Nov 2022 20:40:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oyI4r-0004VU-ER; Thu, 24 Nov 2022 14:40:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyI4p-0004VI-Sv for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 14:40:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oyI4p-0005ei-Ck for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 14:40:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oyI4o-00011D-8r for bug-gnu-emacs@gnu.org; Thu, 24 Nov 2022 14:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Nov 2022 19:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59458 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59458-submit@debbugs.gnu.org id=B59458.16693187903889 (code B ref 59458); Thu, 24 Nov 2022 19:40:02 +0000 Original-Received: (at 59458) by debbugs.gnu.org; 24 Nov 2022 19:39:50 +0000 Original-Received: from localhost ([127.0.0.1]:60258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyI4c-00010f-G2 for submit@debbugs.gnu.org; Thu, 24 Nov 2022 14:39:50 -0500 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]:32938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyI4a-00010R-0u for 59458@debbugs.gnu.org; Thu, 24 Nov 2022 14:39:48 -0500 Original-Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id A3EDAFA08D; Thu, 24 Nov 2022 19:39:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1669318782; bh=hyJLmwUPMi1URBnF1AU3DaZnNlVoIZeWb7I+sGHAWNY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=kqGYQwrX7YQM++8YwNAfGD2Mo12n88atUHmJCeLgtPkyQ4CzmBfq1Tr3J/tBv12x3 XQ4vEIRt8GJRsLKVgdMUs10L7jkm9L/45FQP3YyoRXrR32ikwNFRTe2rIe/o6YWbDh 9efuXS1UqikShfVV1VuBRvLKvzyhSbAuaUqke6Ek= In-Reply-To: <831qpsyaar.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 24 Nov 2022 11:24:44 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248905 Archived-At: Eli Zaretskii writes: >> Cc: =C5=81ukasz Stelmach >> From: =C5=81ukasz Stelmach >> Date: Mon, 21 Nov 2022 22:30:55 +0100 >>=20 >> * lisp/gnus/gnus-logic.el (gnus-score-advanced): Move the tracing >> code outside of if so it's executed for both branches. I'm not very familiar with this code (this is actually the first I'm hearing of gnus-logic.el), so I hope Lars will chime in. It makes sense that tracing should happen whether or not the rule matched? But what about the sexp before that? Would we be pushing the mail-header-number and new score to `gnus-newsgroup-score' only if the rule *wasn't* successful? I think this one should wait for Lars. If we don't hear from him and it's holding things up, I can look more closely.