From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Rah Guzar via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60426: 29.0.60; Binding to outline-minor-mode-cycle-map correctly is unintuitive and hard Date: Thu, 05 Jan 2023 19:28:38 +0100 Message-ID: <877cy0ztuj.fsf@zoho.eu> References: <871qohm8ht.fsf@zohomail.eu> <861qo95fzi.fsf@mail.linkov.net> Reply-To: Rah Guzar Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25227"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.8.13; emacs 29.0.60 Cc: Rah Guzar , 60426@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 05 20:05:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pDVYN-0006LW-1V for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 05 Jan 2023 20:05:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pDVYB-00012W-Jd; Thu, 05 Jan 2023 14:05:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pDVXz-0000zx-Fr for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2023 14:05:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pDVXz-0002P9-34 for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2023 14:05:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pDVXy-0001mo-J6 for bug-gnu-emacs@gnu.org; Thu, 05 Jan 2023 14:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Rah Guzar Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Jan 2023 19:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60426 X-GNU-PR-Package: emacs Original-Received: via spool by 60426-submit@debbugs.gnu.org id=B60426.16729454556795 (code B ref 60426); Thu, 05 Jan 2023 19:05:02 +0000 Original-Received: (at 60426) by debbugs.gnu.org; 5 Jan 2023 19:04:15 +0000 Original-Received: from localhost ([127.0.0.1]:52886 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDVXD-0001lX-EA for submit@debbugs.gnu.org; Thu, 05 Jan 2023 14:04:15 -0500 Original-Received: from sender11-pp-o91.zoho.eu ([31.186.226.249]:25207) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pDVXB-0001lO-LQ for 60426@debbugs.gnu.org; Thu, 05 Jan 2023 14:04:14 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1672945450; cv=none; d=zohomail.eu; s=zohoarc; b=d3moyvzNEKIxeUBB8Cy6W8JdUszorgDBT7FZrLTFnfsUoyjlhJl8hp7pblrce76gPJChkHWiJ6whZu+dk/Xde/rrwds9nbzC94y7dPTmH+FSFc6mCHDFEzP3fpaAtfzwOJRhi/O8muanqBYeH/aIpWtZnAPpJDYz2NZ/HQgFsYA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.eu; s=zohoarc; t=1672945450; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=xmJytYkZjBvB145a6agDAoIVxj7wsOCAj9C433VxVkE=; b=jQ8DtwHNLAWJyFP4cd1f4IdZRquoH27cV5v3RMUSOmcf9Uz8BMu12ggyT+awnucD7YbHzzbLnc0PjKVXlfeJ7jGL1U67Y9KCrvIvhIv2diPe7MIAznhbysc2gIEHzIU9Ooh7RqmNSD7u87yx4+JQOZyOM0jVJzysmJSUhN0pCOg= ARC-Authentication-Results: i=1; mx.zohomail.eu; dkim=pass header.i=zohomail.eu; spf=pass smtp.mailfrom=rahguzar@zohomail.eu; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1672945450; s=zoho; d=zohomail.eu; i=rahguzar@zohomail.eu; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To; bh=xmJytYkZjBvB145a6agDAoIVxj7wsOCAj9C433VxVkE=; b=gyma5qjKB/vHAATRCo19EigLihhWMIX3D6ihad6xGZK7xQkXaN3scklwrLM3QGqS rJw7EHH2UzKlM+1UYU7oDfp+g4+36F51SF4uC70DcLPIjXkMcQ7jZqn3mARyPJslpDv mhjr9WviVJWFrgiTIw0kl1+UhIV/exf2yPrKKbr4= Original-Received: from localhost (81-231-79-170-no600.tbcn.telia.com [81.231.79.170]) by mx.zoho.eu with SMTPS id 1672945446876631.8030045926605; Thu, 5 Jan 2023 20:04:06 +0100 (CET) In-reply-to: <861qo95fzi.fsf@mail.linkov.net> X-ZohoMailClient: External X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252629 Archived-At: Juri Linkov writes: > We expected this change to be backwards-compatible assuming > that users would define keys in outline-minor-mode-cycle-map > using the same helper as is seen in the default definition: > > (outline-minor-mode-cycle--bind map (kbd "TAB") #'outline-cycle) > > Maybe this requirement should be documented in the docstring > and mentioned in NEWS? I think this is a good idea since people who have already keys bound on outline-minor-mode-cycle-map are likely to be as surprised as I was. But I also think that it is more important to mention this in the docstring for outline-minor-mode-cycle-map. Since its current docstring "Keymap used by outline-minor-mode-cycle." is misleading in my opinion, especially since any key there is going to be active if outline-minor-mode is on, regardless of the value of `outline-minor-mode-cycle`. Also I was confused by the two hyphens in the name outline-minor-mode-cycle--bind and thought that it was a private function even though in retrospect they are in the wrong place for it to be private. By the way I also think that the MAP argument outline-minor-mode-cycle--bind of should be optional. Thanks!