From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#60854: Adjust icons shown with warnings Date: Wed, 18 Jan 2023 07:51:19 +0100 Message-ID: <877cxkqqs8.fsf@gmail.com> References: <874jsog5x0.fsf@gmail.com> <346de561-ac0f-017b-832a-036ff3eadb99@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39082"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Pedro Andres Aranda Gutierrez , 60854@debbugs.gnu.org, Daniel =?UTF-8?Q?Mart=C3=ADn?= To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 18 07:52:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pI2It-0009za-A1 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 18 Jan 2023 07:52:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pI2Ip-0001F3-IK; Wed, 18 Jan 2023 01:52:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pI2Im-0001Ep-FC for bug-gnu-emacs@gnu.org; Wed, 18 Jan 2023 01:52:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pI2Im-0001Wd-7E for bug-gnu-emacs@gnu.org; Wed, 18 Jan 2023 01:52:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pI2Ik-0007ZA-01 for bug-gnu-emacs@gnu.org; Wed, 18 Jan 2023 01:52:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Jan 2023 06:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60854 X-GNU-PR-Package: emacs Original-Received: via spool by 60854-submit@debbugs.gnu.org id=B60854.167402468929044 (code B ref 60854); Wed, 18 Jan 2023 06:52:01 +0000 Original-Received: (at 60854) by debbugs.gnu.org; 18 Jan 2023 06:51:29 +0000 Original-Received: from localhost ([127.0.0.1]:38940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pI2ID-0007YO-EF for submit@debbugs.gnu.org; Wed, 18 Jan 2023 01:51:29 -0500 Original-Received: from mail-wr1-f54.google.com ([209.85.221.54]:36607) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pI2IA-0007YB-HM for 60854@debbugs.gnu.org; Wed, 18 Jan 2023 01:51:29 -0500 Original-Received: by mail-wr1-f54.google.com with SMTP id b7so6895371wrt.3 for <60854@debbugs.gnu.org>; Tue, 17 Jan 2023 22:51:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jTlzn5FzfYekdF5PemcP3OZtCzu5XhMZvGtcEMT7UzA=; b=kre7lwi3Fo+nII60oRpUIuHfUOT5mOEgawfNfryH+MBT9l6jJ6N/xYce4BnVFCUIuU 91fy4n5r93PsMYfWllC8wNjTIoAMHVjxjqPm/PVkt/nrxJGc0km54wJCKUwBMAz1sYfW Z9ittS209gNx6gXnCHaqlMIVKjH03Vfo0JAFdpEtqL+NiQbf3YtYjxE/nRI+nMRCY0OU 8EOnZf8W5i02agicwA6/l4Es8V6CPIxxiof9BhPpEuUAjNBACMxW8ap33ztOKD1Cg9K1 L8rytnx3xyQ92wZoVqTWv/11MXc3wsG9a+khMiHWoQhagXGOXHq9e70MtRGi/v+HvPYw Nb+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=jTlzn5FzfYekdF5PemcP3OZtCzu5XhMZvGtcEMT7UzA=; b=Cg5jqBIeW58CsQjZr2ocOWzk839KxXi3hSfmI3cxylaEh+H/tWIH/H2fpskiuQDoiC bA+6GdofoDdDA7uHlBwnHESDJgdvk2QQqeI7+a23nLbQ5DUkmeblSWsU+EmHeZ21pi0u /QHomha6XPsp1CcZRJrnyAEfb46MxxJEwXwkRSARdFSSVX6O2ijZLcbCODL+Cbsf1BSN dG7cT/xYxkIJ43ae4Mj96cz6esRqtYsXx8EVHaeo0Kc0f2qGjJk0upEQHJBFyRS6DWyE 6v7NfX9vLFNhthOUVhFzapukFfI8OFhi2D9+hOhcDieNNk39vSKFm4euOm3n2PcZo8QQ qQDA== X-Gm-Message-State: AFqh2kooCprcWMNRNIQfT43pYiE1khRneyDLPBSFDpMr2MtNPcp1d06W dRhJiaFlEru/4xLpLocqeZ4= X-Google-Smtp-Source: AMrXdXu4BH8Z7IL8oUnb+Aej1hdbtE7MAUWFkXRnA3nF9i6V+SCcK678B0jZI33odR0xZmw5pCoOEg== X-Received: by 2002:a05:6000:110e:b0:2bd:db2a:ec8 with SMTP id z14-20020a056000110e00b002bddb2a0ec8mr1124853wrw.28.1674024680595; Tue, 17 Jan 2023 22:51:20 -0800 (PST) Original-Received: from amdahl30 ([2a01:e0a:253:fe0:2ef0:5dff:fed2:7b49]) by smtp.gmail.com with ESMTPSA id h3-20020adfe983000000b002bdf5832843sm9661149wrm.66.2023.01.17.22.51.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jan 2023 22:51:20 -0800 (PST) In-Reply-To: <346de561-ac0f-017b-832a-036ff3eadb99@gmail.com> (Jim Porter's message of "Tue, 17 Jan 2023 17:37:15 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253611 Archived-At: Jim Porter writes: > On 1/17/2023 2:19 PM, K=C3=A9vin Le Gouguec wrote: >> Jim Porter writes: >>> Perhaps a bit better would be =F0=9F=9A=AB, whose official name is appa= rently "No Entry >>> Sign", even though the slashed circle visual usually just means "No ___= _", >>> e.g. "No Smoking". Hence, some sources call it the Prohibited emoji. >> (My =C2=A22: wouldn't a cross mark (=E2=9D=8C) also work to convey the i= dea of >> "suppressing" something?) > > That would work too. I still like turning this into a toggle button where= the > icon shows the current state (i.e. is it an active warning - =E2=9A=A0=EF= =B8=8F - or has it been > suppressed - =E2=9A=AC). But changing to =F0=9F=9A=AB or =E2=9D=8C would = be single-character patches, > which is nice too. Sure, the toggle sounds like a nice idea regardless, since IIUC right now a user has to go through Customize to take warnings off either warning-suppress-*types. (Sorry for the idle musing, this is the first time I look at what knobs warnings.el lets the user tweak. As things stand, if a user doesn't want to completely ignore a warning, their only choices seem to be "pop *Warnings*" or "meh, tuck it in *Warnings* but don't pop; hopefully I'll remember to check that buffer someday", is that correct? Might be nice to have further options for "suppression", e.g.=E2=80=A6 "don't pop the *Warnings* buffer, but display in echo area", or "=E2=80=A6 but add a modeline indicator" =E2=80=A6 but that's its own feature request) >> The new icons.el that comes with Emacs 29 would be a prime candidate for >> implementing this, right? It has the advantage of giving the user some >> degree of control via icon-preference. > > Yup, the icon we have today is implemented via icons.el: > > =EF=BB=BF (define-icon warnings-suppress button > '((emoji "=E2=9B=94") > (symbol " =E2=96=A0 ") > (text " stop ")) > "Suppress warnings." > :version "29.1" > :help-echo "Click to suppress this warning type") (Ah, great, so we're only missing an 'image entry for that one. Just a trivial matter of choosing what the image should look like then =F0=9F=98= =81) Thanks for the answers =F0=9F=99=8F