From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mickey Petersen Newsgroups: gmane.emacs.bugs Subject: bug#61235: 30.0.50; tree-sit: `treesit-node-check' lacks a way to tell if a node belongs to a deleted parser Date: Tue, 07 Feb 2023 08:03:56 +0000 Organization: Mastering Emacs Message-ID: <877cwtew8o.fsf@masteringemacs.org> References: <83edr3q8ez.fsf@gnu.org> <87o7q7dl4o.fsf@masteringemacs.org> <83a61rq6ck.fsf@gnu.org> <87k00uexdt.fsf@masteringemacs.org> <835yceris5.fsf@gnu.org> <87fsbievbi.fsf@masteringemacs.org> <83y1paq0pd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14416"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e @VERSION@; emacs 30.0.50 Cc: Eli Zaretskii , 61235@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 07 09:06:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pPIzY-0003Wh-EG for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Feb 2023 09:06:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPIzM-00053f-D5; Tue, 07 Feb 2023 03:06:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPIzK-00051c-Pl for bug-gnu-emacs@gnu.org; Tue, 07 Feb 2023 03:06:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pPIzK-00042J-I1 for bug-gnu-emacs@gnu.org; Tue, 07 Feb 2023 03:06:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pPIzK-0000TO-Dr for bug-gnu-emacs@gnu.org; Tue, 07 Feb 2023 03:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mickey Petersen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Feb 2023 08:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61235 X-GNU-PR-Package: emacs Original-Received: via spool by 61235-submit@debbugs.gnu.org id=B61235.16757571401788 (code B ref 61235); Tue, 07 Feb 2023 08:06:02 +0000 Original-Received: (at 61235) by debbugs.gnu.org; 7 Feb 2023 08:05:40 +0000 Original-Received: from localhost ([127.0.0.1]:50928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPIyy-0000Sm-9J for submit@debbugs.gnu.org; Tue, 07 Feb 2023 03:05:40 -0500 Original-Received: from mail-vi1eur05on2124.outbound.protection.outlook.com ([40.107.21.124]:34721 helo=EUR05-VI1-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPIyw-0000SX-0T for 61235@debbugs.gnu.org; Tue, 07 Feb 2023 03:05:38 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UetHv4E4zFbFkiJOc3gQ+akuPYQ91jmckeRjjolzoSMz7BrVAkGviVwrooV05L79Md4dYoEq8qhmv2BpsOxZfqSAt+aMuEl3i8t7bWGytGu1hG7/OFSHMh8B7hU5rs4hXW8hVy+375sdkGMAmBXEAhopWLvclyu5apPFsjqTOoMTH+YxkXTX0LP5ft8g7My41ym2gyNqMSvO/kSIBPxUg88O1aVUXcYGdjyIAlF+g9SMZUAs2l4jTA+HtvhEiTfB7B8TG4IcxrwBbNSX6pQ2ibPR78Y5MIXGw7KZoS7FwMh52c97LxpttHcF0UK+Ttsm/8lGziXtmKDjpWyDlVj1Aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/eYaVqgP8024MWlFQvcB25AO357ak0tm3o4LiUbowRU=; b=XB5uuZt5yO8bobpEXG9R+k6z/FOWBbXydBWnb4WvmOvj/NDKOAKsU+iWN6+GNSjW1Iq+TGsOtdygAdrK8cul/rYu0UT+Cg1JPq48y65XWmsaBY9LAMEWO17BFo6rIF2itGn51pxvoJQJrJETmxQIbyGhbeE9KaSJtxeaNdg35Mwy6HhgVEyquKVQD0NLUBSHmp3viCopcu228m3Vbde0F8QiG8SmIitfwGc/g8/VnNZV6WR45XFcaXQ3tNzTwDePeKpSbiLLLrKjKZtH817lWRtZsHZuOwmI93kCoViwpYrPzazQNrOQEflUp+gZElo/105lUwRA9DPKEliqnggleA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 178.79.136.144) smtp.rcpttodomain=debbugs.gnu.org smtp.mailfrom=masteringemacs.org; dmarc=pass (p=none sp=none pct=100) action=none header.from=masteringemacs.org; dkim=pass (signature was verified) header.d=masteringemacs.org; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semantical.onmicrosoft.com; s=selector1-semantical-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/eYaVqgP8024MWlFQvcB25AO357ak0tm3o4LiUbowRU=; b=PJOuE4x4hun428C38iG07d2tEiGD/Ybcpvqtq798q4i3KW4Vh/rGSIDenwdXJ7esVS2us8Ab1P03osdCg1wSMX9CX2KTwsmspM7Q+HNAbvopgHWI/Z3ZonFPzVfUxT6igTMtMiOeGq24DtyelbK2MNTVIR2rcOCVeu5hFyMOQG8= Original-Received: from LO2P123CA0019.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:a6::31) by LO4P265MB6747.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2f1::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.34; Tue, 7 Feb 2023 08:05:31 +0000 Original-Received: from LO2GBR01FT030.eop-gbr01.prod.protection.outlook.com (2603:10a6:600:a6:cafe::bb) by LO2P123CA0019.outlook.office365.com (2603:10a6:600:a6::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.36 via Frontend Transport; Tue, 7 Feb 2023 08:05:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 178.79.136.144) smtp.mailfrom=masteringemacs.org; dkim=pass (signature was verified) header.d=masteringemacs.org;dmarc=pass action=none header.from=masteringemacs.org; Received-SPF: Pass (protection.outlook.com: domain of masteringemacs.org designates 178.79.136.144 as permitted sender) receiver=protection.outlook.com; client-ip=178.79.136.144; helo=semantical.co.uk; pr=C Original-Received: from semantical.co.uk (178.79.136.144) by LO2GBR01FT030.mail.protection.outlook.com (10.152.42.157) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.31 via Frontend Transport; Tue, 7 Feb 2023 08:05:30 +0000 Original-Received: by semantical.co.uk (Postfix, from userid 5001) id 848B9114002; Tue, 7 Feb 2023 08:05:30 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=masteringemacs.org; s=masteringemacs.org; t=1675757130; bh=/eYaVqgP8024MWlFQvcB25AO357ak0tm3o4LiUbowRU=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=AmCZp8gp0tVEzt3HI/mG0LmbGPA77mbsmBTqq0j7jKQrnc+mxe3kVaInxt9MBAcPH oiN0ryPXU3rB1ABNyuxJVwSd/cgflYihThGk+9l5mfxsW/l7oo+REqW7Sd88IHEQGN ++LQ/dJNyjnDIb69D4e2QHVLOn/1+w+iWa2vDNGI= In-reply-to: X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LO2GBR01FT030:EE_|LO4P265MB6747:EE_ X-MS-Office365-Filtering-Correlation-Id: 9aec5b65-87f6-4396-d9cb-08db08e214f0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PM9LU5K+rahPJHsLDPPiaD1oYc2OzjoLNkjA0ZqP7xqKRjqoYUaY7MC/MLOv+Oz80G3XDt2WNhovpVFx6jW13fe5rE0GP5o3PwuS3s3g2CDzeDS0Tdv1dNgDr1FWdjTLGBGIIHsHuy3Z67JMEhSuF4ZBq3Zvv9J192kMXGubgH7m+zuGgQTWO+KsrgSxH0SIflA7XfryvHggxZ5xBlqorKyUH1JZioQJK/TfQuY45UIDVCLO1uk4iaH0kafn6XVR7A+L1iIzfg6MHdC9ghcz1Tm4oNgBgZzg4s9ZBD89TlA+KeRzIjnDZKEvilNRAlgsMze90HLNyk//eFR19u/az9itxvLH/2bzmc03ZqfExHERBF0umcWByEmpCddgrVm8+1py+2faFfCWC1nhOK6NIVu/2Dh6zv6G6L1C65ojAK/rm+yDYHncvVCLebSX6j15W8CvALI0RXAojVlG2M5Cvzt4iR4yrPtqhkFhDJEmYFFFrAJSrHSIHbPmCBGpIuoLMsd39+eR0eDt2yQYMyaVyQeqD+0UlF1os8Sf0hyG5YS7XnPL9zTBD+HpVXaolnwVCIjLWLEoaYIAEIUA7PYTD5cwT8XO/OTIEa1BIegV26ivtKCNAfdraQGEU7IUxSUv638hnFnON69YT5vnFRJJ6unOkITIENEzJvokmrUxAU8XS4yBQe2H99VYFru8/6osnxkD2L6sSiipUSXED3oBVRRDfyOLZraGO1kg0gBflq+Cv5DFqLAKzBYUTlnQD IZzXAWlP34h6uhjrShBhVju2vu/TylG3G1EKYlIhRTP0AbbOgD7WUX9gZYKJuPW+J6G X-Forefront-Antispam-Report: CIP:178.79.136.144; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:semantical.co.uk; PTR:semantical.co.uk; CAT:NONE; SFS:(13230025)(136003)(376002)(346002)(39830400003)(396003)(451199018)(36840700001)(46966006)(6266002)(36916002)(42186006)(316002)(478600001)(53546011)(82310400005)(6666004)(2616005)(186003)(26005)(36756003)(5660300002)(86362001)(7636003)(336012)(7596003)(4326008)(40480700001)(83380400001)(70206006)(47076005)(8676002)(70586007)(2906002)(356005)(8936002)(6862004)(36860700001)(41300700001)(38230200001)(81973001)(43043002)(14776008)(79816003); DIR:OUT; SFP:1102; X-OriginatorOrg: masteringemacs.org X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Feb 2023 08:05:30.9548 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9aec5b65-87f6-4396-d9cb-08db08e214f0 X-MS-Exchange-CrossTenant-Id: a4e27e3d-bab0-45e8-8942-e64cf9fbd34f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a4e27e3d-bab0-45e8-8942-e64cf9fbd34f; Ip=[178.79.136.144]; Helo=[semantical.co.uk] X-MS-Exchange-CrossTenant-AuthSource: LO2GBR01FT030.eop-gbr01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO4P265MB6747 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255023 Archived-At: Yuan Fu writes: >> On Feb 6, 2023, at 7:21 AM, Eli Zaretskii wrote: >> >>> From: Mickey Petersen >>> Cc: casouri@gmail.com, 61235@debbugs.gnu.org >>> Date: Mon, 06 Feb 2023 14:08:46 +0000 >>> >>> All I want is a way for treesit-node-check to tell me if the node >>> belongs to a dead or alive parser. >> >> That'd be fine by me, but the patch posted by Yuan was a different >> one. >> >> Yuan, any reason not to extend treesit-node-check instead? > > I did extend treesit-node-check in the patch. But I also added a > function treesit-parser-live-p, which makes the same check but > directly on a parser. It just made sense to me that if we let > treesit-node-check check the nodes=E2=80=99 parser=E2=80=99s status, we= =E2=80=99d also add a > function to allow directly checking the status of a parser. > > Micky, the function I added (and the extension to treesit-node-check) > checks that the parser is not deleted AND its buffer is live. That > makes the most sense to me, but would it cause any problem for your > use case? Thanks for turning around the features so fast. I can use `treesit-node-buffer' and `buffer-live-p' to accomplish that, so perhaps leaving out that check makes sense? > Yuan