From: Basil Contovounesios via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 61395@debbugs.gnu.org, Tom Tromey <tom@tromey.com>,
Tassilo Horn <tsdh@gnu.org>
Subject: bug#61395: 28.2; bug-reference warning seems incorrect
Date: Fri, 10 Feb 2023 15:02:23 +0000 [thread overview]
Message-ID: <877cwplg1s.fsf@tcd.ie> (raw)
In-Reply-To: <838rh6kjua.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 10 Feb 2023 10:25:49 +0200")
Eli Zaretskii [2023-02-10 10:25 +0200] wrote:
>> From: Tom Tromey <tom@tromey.com>
>> Date: Thu, 09 Feb 2023 12:08:39 -0700
>>
>> I got this warning while using bug-reference-prog-mode on a certain file
>> in gdb:
>>
>> Warning (bug-reference): The value of ‘bug-reference-bug-regexp’
>>
>> "\\(\\b\\(?:[Bb]ug ?#?\\|[Pp]atch ?#\\|RFE ?#\\|PR [a-z+-]+/\\)\\([0-9]+\\(?:#[0-9]+\\)?\\)\\)"
>>
>> in buffer "finish.exp" doesn’t conform to the contract specified by its
>> docstring. The subexpression 1 should define the region of the
>> bug-reference overlay and cover all other subexpressions up to
>> subexpression 10. Disable showing Disable logging
>>
>>
>> However, this warning seems wrong to me. If you examine the above
>> regexp, you'll see it does cover all the other subexpressions.
>>
>> Perhaps it is mis-worded somehow and the actual problem is something
>> else? It's worth noting here that this is the default value for this
>> regexp:
>>
>> (defcustom bug-reference-bug-regexp
>> "\\(\\b\\(?:[Bb]ug ?#?\\|[Pp]atch ?#\\|RFE ?#\\|PR [a-z+-]+/\\)\\([0-9]+\\(?:#[0-9]+\\)?\\)\\)"
>>
>> In gdb we use this setting for bug-reference-url-format, in case this
>> matters somehow:
>>
>> (bug-reference-url-format . "http://sourceware.org/bugzilla/show_bug.cgi?id=%s")
>
> Thanks, but could you perhaps post a recipe for reproducing the
> warning? Based on your description, I couldn't understand how to
> reproduce it: which variables to change (with the single exception of
> bug-reference-url-format), and what should be the buffer text to
> trigger the warning. Could you help me reproducing the problem, so I
> could investigate it and see how to fix it?
Copying in Tassilo who worked on this stuff ahead of Emacs 28.
Thanks,
--
Basil
next prev parent reply other threads:[~2023-02-10 15:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 19:08 bug#61395: 28.2; bug-reference warning seems incorrect Tom Tromey
2023-02-10 8:25 ` Eli Zaretskii
2023-02-10 15:02 ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-02-10 15:54 ` Tassilo Horn
2023-02-10 16:27 ` Tom Tromey
2023-02-10 17:21 ` Tassilo Horn
2023-02-10 18:10 ` Tom Tromey
2023-02-10 18:15 ` Tassilo Horn
2023-02-10 18:32 ` Tom Tromey
2023-02-11 9:33 ` Kévin Le Gouguec
2023-02-11 15:56 ` Tom Tromey
2023-02-10 18:25 ` Tom Tromey
2023-02-10 16:41 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cwplg1s.fsf@tcd.ie \
--to=bug-gnu-emacs@gnu.org \
--cc=61395@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=eliz@gnu.org \
--cc=tom@tromey.com \
--cc=tsdh@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).