From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#62845: 29.0.90; nntp-with-open-group-function kills current buffer on timeout Date: Sat, 06 May 2023 10:05:54 -0700 Message-ID: <877ctlwft9.fsf@ericabrahamsen.net> References: <87a5zauofc.fsf@igel.home> <83pm85ej9b.fsf@gnu.org> <87edo619wx.fsf@igel.home> <87leieqawq.fsf@ericabrahamsen.net> <83r0s0nq93.fsf@gnu.org> <87354axr54.fsf@ericabrahamsen.net> <83jzxmgech.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5298"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: schwab@linux-m68k.org, 62845@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 06 19:07:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pvLNM-0001Dq-UU for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 May 2023 19:07:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvLN9-0006AR-Jf; Sat, 06 May 2023 13:07:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvLN8-0006AH-Ax for bug-gnu-emacs@gnu.org; Sat, 06 May 2023 13:07:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pvLN8-000118-2S for bug-gnu-emacs@gnu.org; Sat, 06 May 2023 13:07:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pvLN7-0007Li-TU for bug-gnu-emacs@gnu.org; Sat, 06 May 2023 13:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 May 2023 17:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62845 X-GNU-PR-Package: emacs Original-Received: via spool by 62845-submit@debbugs.gnu.org id=B62845.168339276728180 (code B ref 62845); Sat, 06 May 2023 17:07:01 +0000 Original-Received: (at 62845) by debbugs.gnu.org; 6 May 2023 17:06:07 +0000 Original-Received: from localhost ([127.0.0.1]:35690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvLME-0007KR-E8 for submit@debbugs.gnu.org; Sat, 06 May 2023 13:06:06 -0400 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]:60172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvLMA-0007Jw-VH for 62845@debbugs.gnu.org; Sat, 06 May 2023 13:06:04 -0400 Original-Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 5D54FFA0D6; Sat, 6 May 2023 17:05:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1683392756; bh=kw538w85uObf08yQ9rDua5OAqXKWaSkzFNjwQV5kgtk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=nr1FF5eWzXQ4rrQIjmMshYlkT90A+tCmlH6rq2OAoL0jMhAgf5VOI/+KShWEhUtje fpQRw6g+UZYr10udTkcHkRwLfkpUfrTK9R1HT+QwL30rJ+6fyPWYAQ3RxIhhHIoRRt wso/L7mi+9+syXBctV9zD85RWIAnAW4wxxzfwQ/w= In-Reply-To: <83jzxmgech.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 06 May 2023 09:31:58 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261206 Archived-At: On 05/06/23 09:31 AM, Eli Zaretskii wrote: >> From: Eric Abrahamsen >> Cc: schwab@linux-m68k.org, 62845@debbugs.gnu.org >> Date: Fri, 05 May 2023 17:03:35 -0700 >> >> `nntp-report' used to raise an error in this case, so it didn't matter >> what happened afterwards. That error would derail the entire process of >> Gnus checking for news/mail, so I took it out so that other servers >> could continue doing their work even if this one had lost its >> connection. >> >> But then the current buffer of `with-current-buffer` is gone, which as >> Andreas notes dumps us in the most-recently-used buffer, which could be >> anything. The `nnheader-strip-cr' acts on that buffer, and terrible >> things result. >> >> Other code in this library checks if the timer has killed the process >> buffer in the meantime. There's probably a safe solution in here >> somewhere, but if you're looking for a reliable regression fix to >> include in Emacs 29, it's probably best just to revert 032969e8c65. That >> behavior is annoying, but at least not buggy. >> >> WDYT? > > Fine with me, but what is the plan for master? If you can show the > proposed solution for master, we could then try to figure out if it is > safe enough for emacs-29 as well. > > But if it will take a significant time to come up with such a solution > for master, then let's revert on emacs-29 for now. I've had a patch sitting around since forever that defines a handful of Gnus-specific errors and uses them for explicit flow control, preventing errors with individual servers from interrupting Gnus' top-level usage. Personally I think that's the right way to go, but it seems like too much for a emacs 29 fix. I will look the patch over this afternoon and see how close I got.