From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#63336: [PATCH] package-vc: Process :make and :shell-command spec args Date: Wed, 10 May 2023 06:35:03 +0000 Message-ID: <877ctghey0.fsf@posteo.net> References: <874joprxmx.fsf@breatheoutbreathe.in> <87jzxkecnk.fsf@posteo.net> <87pm7b7up0.fsf@breatheoutbreathe.in> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16608"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63336@debbugs.gnu.org To: Joseph Turner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 10 08:36:28 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pwdR6-00046M-9F for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 May 2023 08:36:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pwdQu-0007V2-LZ; Wed, 10 May 2023 02:36:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwdQi-0007S7-LZ for bug-gnu-emacs@gnu.org; Wed, 10 May 2023 02:36:09 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pwdQh-0002b3-6b for bug-gnu-emacs@gnu.org; Wed, 10 May 2023 02:36:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pwdQg-00028S-Hz for bug-gnu-emacs@gnu.org; Wed, 10 May 2023 02:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 May 2023 06:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63336 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63336-submit@debbugs.gnu.org id=B63336.16837005138128 (code B ref 63336); Wed, 10 May 2023 06:36:02 +0000 Original-Received: (at 63336) by debbugs.gnu.org; 10 May 2023 06:35:13 +0000 Original-Received: from localhost ([127.0.0.1]:45049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwdPt-00026y-5B for submit@debbugs.gnu.org; Wed, 10 May 2023 02:35:13 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:33869) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwdPq-00026f-CU for 63336@debbugs.gnu.org; Wed, 10 May 2023 02:35:11 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 57044240350 for <63336@debbugs.gnu.org>; Wed, 10 May 2023 08:35:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1683700504; bh=nuQpf1V3TVYzeVsE3ExjNzCzR4lsWoiz9dfhp2QMxHQ=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=DmdRwl/Y5siLNxO585/PZbcencw/JzvQ1VNnbniyEaEbLqB/nsUS4lmbppgkwIGX2 1yMqiWfhjAXGLHPrT8c7dda5lNxEVOrT3gi9t05FYjc1gdqjqd/jaa6ZaLcjf3ZJ9R UPJ3KOyR07lsdkduWu9exeNMCpfl5m1boa1ZarOuh9bIxGx5OlI7qNKOaWe7FOBa81 PVOu3dfBp9sVpDRSodtgPYkp3+LVdw7VNYnnoCExbVt7gEEv6ca4k6TRbcnDJ2a5v3 S5UScgVDgYz2U1AynOTNwQzu8eD8OOmd3psxJZONNL1LoOgV65O7J5JQ7qjXpDvm2E QxIDN0P1xcYug== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QGQHq5Hpxz9rxT; Wed, 10 May 2023 08:35:03 +0200 (CEST) In-Reply-To: <87pm7b7up0.fsf@breatheoutbreathe.in> (Joseph Turner's message of "Sun, 07 May 2023 11:47:29 -0700") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261469 Archived-At: Joseph Turner writes: >>> +(defun package-vc--make (pkg-spec dir) >>> + "Process :make and :shell-command spec arguments." >>> + (let ((target (plist-get pkg-spec :make)) >>> + (cmd (plist-get pkg-spec :shell-command))) >>> + (when (or cmd target) >>> + (with-current-buffer (get-buffer-create " *package-vc make*") >> ^ >> should the package name >> be mentioned here? > > I like this idea, but IIUC package-vc--make would then need to take an > extra arg, since pkg-spec doesn't contain the :name of the package. We > could also add :name to the pkg-spec plist? I wouldn't be in favour of that, I think that passing the name as a separate argument would be a better solution. > For comparison, package-vc--build-documentation creates a buffer called > " *package-vc doc*" without the package name. The difference I see here is that documentation usually builds fine, while :make or :shell-command have a higher chance of failing because some software is missing, especially if people don't use :make the way it is used on the ELPA server but to build external dependencies (I'm thinking of mail clients like notmuch) >>> + target (buffer-name))))))) >>> + >>> (declare-function org-export-to-file "ox" (backend file)) >>> >>> (defun package-vc--build-documentation (pkg-desc file) >>> @@ -486,6 +515,9 @@ documentation and marking the package as installed." >>> ;; Generate package file >>> (package-vc--generate-description-file pkg-desc pkg-file) >>> >>> + ;; Process :make and :shell-command arguments before building documentation >>> + (when package-vc-process-make (package-vc--make pkg-spec pkg-dir)) >> >> Wasn't the plan to allow `package-vc-process-make' to either be a >> generic "build-anything" or a selective listing of packages where we >> allow :make and :shell-command to be executed? > > Let me know if the attached commit accomplishes what you had in mind. Yes, that (or rather the newest version from a different message) looks good. >>> + >>> ;; Detect a manual >>> (when (executable-find "install-info") >>> (dolist (doc-file (ensure-list (plist-get pkg-spec :doc))) >> >> Otherwise this looks good, but I haven't tried it out yet. > > I fixed up a couple other issues: > > - removed unnecessary dir arg to package-vc--make > - added function arg to the docstring for package-vc--make > > I'm not sure if the customization type for package-vc-process-make is > correct. Please double check that. > > Also, should users be able to run :make and :shell-command args defined > in a spec passed into package-vc-install? Yes, is that currently not supported? > Best, > > Joseph