From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#64596: 30.0.50; On FIXME: in src/buffer.c:1481 (force-mode-line-update) Date: Thu, 13 Jul 2023 13:00:26 +0000 Message-ID: <877cr4nez9.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26535"; mail-complaints-to="usenet@ciao.gmane.io" To: 64596@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 13 15:01:43 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qJvx0-0006hk-HR for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Jul 2023 15:01:42 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qJvwm-00032Z-S1; Thu, 13 Jul 2023 09:01:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJvwO-0002zv-C1 for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 09:01:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qJvwM-00087G-P7 for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 09:01:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qJvwM-00085Z-8Z for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 09:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Jul 2023 13:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 64596 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.168925325031066 (code B ref -1); Thu, 13 Jul 2023 13:01:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 13 Jul 2023 13:00:50 +0000 Original-Received: from localhost ([127.0.0.1]:53578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJvw6-00084w-U9 for submit@debbugs.gnu.org; Thu, 13 Jul 2023 09:00:50 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:39556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJvw3-00084l-1k for submit@debbugs.gnu.org; Thu, 13 Jul 2023 09:00:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJvvx-0002vi-8h for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 09:00:42 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJvvs-000811-Dq for bug-gnu-emacs@gnu.org; Thu, 13 Jul 2023 09:00:36 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id B1B06240028 for ; Thu, 13 Jul 2023 15:00:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1689253218; bh=16DSjzB/waXYU2h5O1KFtVW7ZyIBDPkni13O2SrW63Y=; h=From:To:Subject:Date:Message-ID:MIME-Version:From; b=OYjr2NNhqZhW5tDckx3tr/UZujHHEsLTfx9IylKnTAO08U0wmRXu4VD7GXKPWlQTl hx9wF+cQtQ1vK7vI7ygKepX7LkBYnIZ26dGhFiX3Ni7WCc1k7d6PRecLCh+4jdL7jf Cq3vTmjPNitC+NmFQAMX1bmdnvsuw4w7usERyVb/rj5quTxe4cVvLjZMnBnjZOg7hy LSHimd4tF99AE2gCC1mtsN4rhN79o96ewuThuN2/1IRy2yu6DpHANTDGWETqH/IzBE LeEPv+62qzMvVN9Ad6Dvh2BPZsynHIfcXaGCihf4m7YVRpGf1QikC2wKi8R2QaCwQr DtmuS1OMWFtzg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R1vpn70JNz9rxS for ; Thu, 13 Jul 2023 15:00:17 +0200 (CEST) Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265017 Archived-At: Hello, `force-mode-line-update' has the following FIXME: if (!NILP (all)) { update_mode_lines = 10; /* FIXME: This can't be right. */ current_buffer->prevent_redisplay_optimizations_p = true; } else if (buffer_window_count (current_buffer)) { bset_update_mode_line (current_buffer); current_buffer->prevent_redisplay_optimizations_p = true; } This FIXME has been introduced in 655ab9a3800, shortly after ecda65d4f7e, which moved this code from `set-buffer-modified-p'. AFAIU, the purpose of disabling redisplay optimizations is avoiding the situation when the modification flag is unset in the buffer, but the buffer was actually modified, and has to be redrawn. If my understanding is correct, current_buffer->prevent_redisplay_optimizations_p = true does not belong to `force-mode-line-update', but rather to `restore-buffer-modified-p'. I also grepped through src/display.c looking at the usage of update_mode_lines, and there seems to be no obvious situation where update_mode_lines being non-nil is ignored. In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.17.8) of 2023-07-06 built on localhost Repository revision: d97b77e6c66db46b198c696f83458aa141794727 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101008 System Description: Gentoo Linux -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at