From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: sbaugh@catern.com Newsgroups: gmane.emacs.bugs Subject: bug#64735: 29.0.92; find invocations are ~15x slower because of ignores Date: Tue, 25 Jul 2023 19:16:20 +0000 (UTC) Message-ID: <877cqniyyk.fsf@catern.com> References: <1fd5e3ed-e1c3-5d6e-897f-1d5d55e379fa@gutov.dev> <87wmyupvlw.fsf@localhost> <5c4d9bea-3eb9-b262-138a-4ea0cb203436@gutov.dev> <87tttypp2e.fsf@localhost> <87r0p030w0.fsf@yahoo.com> <83sf9f6wm0.fsf@gnu.org> <83sf9eub9d.fsf@gnu.org> <2d844a34-857d-3d59-b897-73372baac480@gutov.dev> <83bkg2tsu6.fsf@gnu.org> <83bd4246-ac41-90ec-1df3-02d0bd59ca44@gutov.dev> <834jlttv1p.fsf@gnu.org> <937c3b8e-7742-91b7-c2cf-4cadd0782f0c@gutov.dev> <83a5vlsanw.fsf@gnu.org> <69a98e2a-5816-d36b-9d04-8609291333cd@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32353"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: luangruo@yahoo.com, sbaugh@janestreet.com, Eli Zaretskii , yantar92@posteo.net, 64735@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 25 21:17:30 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qONXF-0008Dy-Fv for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 Jul 2023 21:17:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qONWy-00060z-OZ; Tue, 25 Jul 2023 15:17:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qONWq-0005yI-9y for bug-gnu-emacs@gnu.org; Tue, 25 Jul 2023 15:17:10 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qONWo-0000yu-7B for bug-gnu-emacs@gnu.org; Tue, 25 Jul 2023 15:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qONWo-0001cY-36 for bug-gnu-emacs@gnu.org; Tue, 25 Jul 2023 15:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: sbaugh@catern.com Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Jul 2023 19:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64735 X-GNU-PR-Package: emacs Original-Received: via spool by 64735-submit@debbugs.gnu.org id=B64735.16903125886182 (code B ref 64735); Tue, 25 Jul 2023 19:17:02 +0000 Original-Received: (at 64735) by debbugs.gnu.org; 25 Jul 2023 19:16:28 +0000 Original-Received: from localhost ([127.0.0.1]:46993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qONWF-0001be-L8 for submit@debbugs.gnu.org; Tue, 25 Jul 2023 15:16:27 -0400 Original-Received: from s.wrqvtbkv.outbound-mail.sendgrid.net ([149.72.123.24]:45740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qONWD-0001bQ-PI for 64735@debbugs.gnu.org; Tue, 25 Jul 2023 15:16:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catern.com; h=from:subject:in-reply-to:references:mime-version:to:cc:content-type: content-transfer-encoding:cc:content-type:from:subject:to; s=s1; bh=IBR4/bLNhmMuVWLT8kELUMGk3qDwcpDbnzCKfKDjpnc=; b=Oi6sgk3f8o5xl4ny2SNda8LXfuTPOYqHkAdJ9CfoZwFjPEWeQpMsrGfvrkRWUsiIfeFq 30wE1kM5nxJ9vFT1fFlx4SQvvNml2kD0VLraQjVq7yD1XqXD1Oe4kko6Nq2kchk15vT3Qj MLxtZ1SJtd9NZyA8MgBEmkEbZzj1WaURQ1rPnjQ+vr7pmBYXRyHEAPsZMA3bm5g/bBFnqZ W7an40y63uE6dkwoBTdV2TgseTg+4ZrODFB1MT4uS+r/QNQKV/O+0Uuxl/uBonJWOq0dwp qzZwkY5HpT+dK/hHSgUBa5E9kcxITJTWYgGkE5PyLbtpRFh3W5rVlpk1YLNSDbSA== Original-Received: by filterdrecv-d7bbbc8bf-ftxgm with SMTP id filterdrecv-d7bbbc8bf-ftxgm-1-64C01F84-38 2023-07-25 19:16:20.292981975 +0000 UTC m=+6550593.487377294 Original-Received: from earth.catern.com (unknown) by geopod-ismtpd-canary-0 (SG) with ESMTP id VmMM01OkQD2enD_ee9hN2g Tue, 25 Jul 2023 19:16:20.261 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=::1; helo=localhost; envelope-from=sbaugh@catern.com; receiver=gutov.dev Original-Received: from localhost (localhost [IPv6:::1]) by earth.catern.com (Postfix) with ESMTPSA id B92F860171; Tue, 25 Jul 2023 15:16:19 -0400 (EDT) In-Reply-To: <69a98e2a-5816-d36b-9d04-8609291333cd@gutov.dev> (Dmitry Gutov's message of "Tue, 25 Jul 2023 05:41:13 +0300") X-SG-EID: ZgbRq7gjGrt0q/Pjvxk7wM0yQFRdOkTJAtEbkjCkHbJBtyc/2Had/AF8pYFPW7yam57WgVZDCYyakw+TpVDVX8szhc1PBagwIzxv6ScccyHq9TPxXj4qzq/dfKFVQXqNYGms7xDZf0gQ12Bhwv/YP3SgUFrLrpRJkMTJzm9YGIn/tKEbM2XIbAik9MWN5NfyDVL9haS8cz80tYxWa110gA== X-Entity-ID: d/0VcHixlS0t7iB1YKCv4Q== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266090 Archived-At: Dmitry Gutov writes: >> (my-bench 1 default-directory "") > > (("built-in" . "Elapsed time: 1.601649s (0.709108s in 22 GCs)") > ("with-find" . "Elapsed time: 1.792383s (1.135869s in 38 GCs)") > ("with-find-p" . "Elapsed time: 1.248543s (0.682827s in 20 GCs)") > ("with-find-sync" . "Elapsed time: 0.922291s (0.343497s in 10 GCs)")) Tangent, but: Ugh, wow, call-process really is a lot faster than make-process. I see now why people disliked my idea of replacing call-process with something based on make-process, this is a big difference... There's zero reason it has to be so slow... maybe I should try to make a better make-process API and implementation which is actually fast. (without worrying about being constrained by compatibility with something that's already dog-slow)