From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61394: 30.0.50; [PATCH] Image-dired thumb name based on content Date: Fri, 28 Jul 2023 11:33:19 +0200 Message-ID: <877cqkcrds.fsf@ledu-giraud.fr> References: <874jruy7xx.fsf@ledu-giraud.fr> <87ttztk0yw.fsf@tcd.ie> <87v8k9s6j9.fsf@ledu-giraud.fr> <83ilg8jzti.fsf@gnu.org> <87k00oo03r.fsf@ledu-giraud.fr> <838rh4jlsq.fsf@gnu.org> <87bklzol8n.fsf@ledu-giraud.fr> <877cwmo8ij.fsf@ledu-giraud.fr> <87y1oz54bn.fsf@ledu-giraud.fr> <87wn4dra0h.fsf@ledu-giraud.fr> <87bklhtwhd.fsf@ledu-giraud.fr> <871qgumqh7.fsf@ledu-giraud.fr> <83ila5n8co.fsf@gnu.org> <87fs59qx54.fsf@ledu-giraud.fr> <83wmyll9s5.fsf@gnu.org> <87bkfxcaa2.fsf@ledu-giraud.fr> <83wmykjzji.fsf@gnu.org> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40086"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: contovob@tcd.ie, stefankangas@gmail.com, 61394@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 28 12:03:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qPKJa-000A6j-Rh for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 Jul 2023 12:03:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qPJrI-0004r4-92; Fri, 28 Jul 2023 05:34:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPJrG-0004qh-HV for bug-gnu-emacs@gnu.org; Fri, 28 Jul 2023 05:34:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qPJrG-0000hd-A3 for bug-gnu-emacs@gnu.org; Fri, 28 Jul 2023 05:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qPJrG-0005u2-5m for bug-gnu-emacs@gnu.org; Fri, 28 Jul 2023 05:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Jul 2023 09:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61394 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61394-submit@debbugs.gnu.org id=B61394.169053680622643 (code B ref 61394); Fri, 28 Jul 2023 09:34:02 +0000 Original-Received: (at 61394) by debbugs.gnu.org; 28 Jul 2023 09:33:26 +0000 Original-Received: from localhost ([127.0.0.1]:43718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPJqg-0005t9-5y for submit@debbugs.gnu.org; Fri, 28 Jul 2023 05:33:26 -0400 Original-Received: from ledu-giraud.fr ([51.159.28.247]:31025) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPJqd-0005sz-6m for 61394@debbugs.gnu.org; Fri, 28 Jul 2023 05:33:24 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=DCSvED+9 FdeFIQub5eigK8tSUEJ1IwopPRSau6+W8Bc=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=f2LhUsz0FCo0CTF6/4gvpiodKoj4vp VBODnoxCclLwBrr8y2HxltdxdxtMfTvi1pCqCPEfCKABODehJNv7JBDQ== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=DCSvED+9FdeFIQub 5eigK8tSUEJ1IwopPRSau6+W8Bc=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=vyWs9uLUSmXL2+YMBqVfZ9NI+bjA0oMTXB2/C9 PXNyFK7LogZQnRJNR3qeljSWzjfZ4eCtik+jiQGZA/vmcuJPe6FSP01gb1Z51iHQ1444AH VNGPge0LEHv7NzB6en6B36B+tDPMgf12yXGfDQTK/+RhzOxhNZfbCGRzrKIvZekFk9QyA0 MSTHP8VfuYIZDaU/cl0y6xWYqRzSFvsxhYH4eoh82FE3zbEs5nWc/wr4GTM2I8CDJNZ6X6 s9jXtMo83vwVxHvbwb+QhpNfj2wD09U5g7x0Koe8by3FUT5PLCVO/pSLxXCT9ejLoTssrq fofB/VQpSVbW1EFtoeRRKsTg== Original-Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 0f717557 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 28 Jul 2023 11:33:21 +0200 (CEST) In-Reply-To: <83wmykjzji.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 28 Jul 2023 09:55:13 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266248 Archived-At: Eli Zaretskii writes: [...] > Thanks, the tests now pass, but I wonder about this part: > >> (should (equal (cdr (file-name-split >> - (image-dired-thumb-name "/tmp/foo.jpg"))) >> - '("tmp" ".image-dired" "foo.jpg.thumb.jpg"))) >> + (image-dired-thumb-name abs-path))) >> + (list "tmp" ".image-dired" hash-name))) > > Does this mean that thumbnail naming under 'per-directory' has > changed, and it now uses the SHA-1 hash of the base-name? IOW, does > this mean your changes for bug#61394 included incompatible changes in > behavior? Yes I think it does. My patch for bug#61394 changes the previous behaviour of 'image-dired-thumbnail-storage'. Now 'image-dired-thumbnail-storage' defines where (ie. in which directory) the thumbnails are stored and I introduce 'image-dired-thumb-naming' which tells how thumbnail file ared named (ie. the file name part sans directory). 'image-dired-thumb-naming' is meaning less if 'image-dired-thumbnail-storage' is one of the "standard*" method because those methods already define storage locations, file names and even sizes. But for the "per-directory" method, I'm using 'image-dired-thumb-naming'. As we are talking about thumbnail I did not think it was a big deal but if it is I can prepare a patch, on top of the one in place, and then 'image-dired-thumb-naming' will be used only for the "image-dired" storage method. WDYT? -- Manuel Giraud