From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#65649: [PATCH] package-vc: Continue installing package when documentation build fails Date: Sun, 03 Sep 2023 07:00:22 +0000 Message-ID: <877cp7212x.fsf@posteo.net> References: <87v8cvvi6r.fsf@breatheoutbreathe.in> <87r0njvhyo.fsf@breatheoutbreathe.in> <87msy7vhum.fsf@breatheoutbreathe.in> <87pm33r87q.fsf@posteo.net> <87sf7yoq9p.fsf@breatheoutbreathe.in> <87fs3yvxve.fsf@posteo.net> <87ttsdmpwm.fsf@breatheoutbreathe.in> <877cp8g4sy.fsf@posteo.net> <87h6ocms72.fsf@breatheoutbreathe.in> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18046"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65649-done@debbugs.gnu.org To: Joseph Turner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 03 09:01:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qch6p-0004Xt-6B for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 Sep 2023 09:01:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qch6O-0007kd-AX; Sun, 03 Sep 2023 03:00:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qch6L-0007kL-7n for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 03:00:54 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qch6K-0003D5-V6 for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 03:00:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qch6U-0000cz-Sr for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 03:01:02 -0400 Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Sep 2023 07:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 65649 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 65649@debbugs.gnu.org, philipk@posteo.net, joseph@breatheoutbreathe.in Original-Received: via spool by 65649-done@debbugs.gnu.org id=D65649.16937244462378 (code D ref 65649); Sun, 03 Sep 2023 07:01:02 +0000 Original-Received: (at 65649-done) by debbugs.gnu.org; 3 Sep 2023 07:00:46 +0000 Original-Received: from localhost ([127.0.0.1]:39123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qch6E-0000cI-Bi for submit@debbugs.gnu.org; Sun, 03 Sep 2023 03:00:46 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:34263) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qch69-0000c2-7P for 65649-done@debbugs.gnu.org; Sun, 03 Sep 2023 03:00:45 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 1C832240101 for <65649-done@debbugs.gnu.org>; Sun, 3 Sep 2023 09:00:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1693724424; bh=QIvh8c+1Jv1jkMeGh28Mm5yu8bO6y9h0NmJdg9ONfuQ=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=VlhmtIInhk6nfdvrKJ6LS4/xyggi/lAFCUuR50lx5f28TirZO6d8Th1vz9bL3lBUB uPraltUyZH++AcRjDpdgcsN4tkyBTGofhamMsbrqO7YY61BlsHFcfgR3Wh++6GIlKO XMlDlcBQUoJUSQsVlkts3x9VH76EeZt5Al24PNI9dx+S1jMiVA/EhuNV7qWP4ge/Oj l2ozJkrGJPD5fs6016v6QytAat+Jdu6rsCUi5U8tivwcnWpMOaqh2EiX/aQCMKthPL gkGAZTZGHGYmlysTfEK83W8jYHD8SPALlQYNZTkqfE1tobTZrpt//+7FguddqkE2JF BsoL7ess9bzLg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RdjMW3V2bz9rxD; Sun, 3 Sep 2023 09:00:23 +0200 (CEST) In-Reply-To: <87h6ocms72.fsf@breatheoutbreathe.in> (Joseph Turner's message of "Sat, 02 Sep 2023 09:49:24 -0700") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269078 Archived-At: Joseph Turner writes: > Philip Kaludercic writes: > >> I think it would be better to wrap only the org code in the >> `condition-case' body, ideally with a more specific error type (if that >> doesn't exist, that is something we could mention to the Org >> maintainers). > > The reason I wrapped both the org-export and makeinfo logic in > condition-case is so that the makeinfo logic does not run when the > org-export logic fails. Is there a better way? > > We could let-bind a flag like failed-org-export-p, then set it to t in > the condition case handler, then only run makeinfo when > failed-org-export-p is nil. Seems a bit ugly. Oh right, never-mind then, I guess this is the simplest solution. > The only define-error in org-mode that's relevant to org-export is not > general enough: > > (define-error 'org-link-broken "Unable to resolve link; aborting") Then this should be fine. I'll apply the changes the master. Thanks.