From: Antero Mejr via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Stefan Kangas <stefankangas@gmail.com>
Cc: 66551@debbugs.gnu.org
Subject: bug#66551: [PATCH] Add completion for Unix 'doas' command.
Date: Sun, 15 Oct 2023 13:41:55 +0000 [thread overview]
Message-ID: <877cnoc89o.fsf@mailbox.org> (raw)
In-Reply-To: <CADwFkmmNvdToH4zwwr6OVkLrPa2btMwWTi5_skG2J0qmyYoqYw@mail.gmail.com> (Stefan Kangas's message of "Sun, 15 Oct 2023 05:55:01 -0700")
[-- Attachment #1: Type: text/plain, Size: 373 bytes --]
Stefan Kangas <stefankangas@gmail.com> writes:
> I believe it might be better to align with the flags available on
> GNU/Linux, then. Especially considering our larger GNU/Linux user base
> compared to BSD.
>
> It's less cumbersome for users to manually add a missing flag than for
> pcomplete to suggest an incorrect one.
Sounds good, patch with Linux flags is below.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Add-completion-for-Unix-doas-command.patch --]
[-- Type: text/x-patch, Size: 1560 bytes --]
From 2e54ecf8714088a1c5cf596edb7cf66bc3468dfe Mon Sep 17 00:00:00 2001
From: Antero Mejr <antero@mailbox.org>
Date: Sun, 15 Oct 2023 00:32:57 +0000
Subject: [PATCH] Add completion for Unix 'doas' command.
* lisp/pcmpl-unix.el (pcomplete/doas): New procedure.
* etc/NEWS: Announce. (Bug#66551)
---
etc/NEWS | 4 ++++
lisp/pcmpl-unix.el | 8 ++++++++
2 files changed, 12 insertions(+)
diff --git a/etc/NEWS b/etc/NEWS
index 3bd47a0112b..d73ec031d85 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -477,6 +477,10 @@ When this option is non-nil, remote file names are not completed by
Pcomplete. Packages, like 'shell-mode', could set this in order to
suppress remote file name completion at all.
+---
+*** Completions for the Unix 'doas' command are now provided.
+Command completion for 'doas' in Eshell and Shell mode will now work.
+
** Shell Mode
+++
diff --git a/lisp/pcmpl-unix.el b/lisp/pcmpl-unix.el
index e6b67256a4c..0626bc5a890 100644
--- a/lisp/pcmpl-unix.el
+++ b/lisp/pcmpl-unix.el
@@ -685,6 +685,14 @@ Includes files as well as host names followed by a colon."
(funcall (or (pcomplete-find-completion-function (pcomplete-arg 1))
pcomplete-default-completion-function)))
+;;;###autoload
+(defun pcomplete/doas ()
+ "Completion for the `doas' command."
+ (pcomplete-opt "CLnsu")
+ (funcall pcomplete-command-completion-function)
+ (funcall (or (pcomplete-find-completion-function (pcomplete-arg 1))
+ pcomplete-default-completion-function)))
+
(provide 'pcmpl-unix)
;;; pcmpl-unix.el ends here
--
2.41.0
next prev parent reply other threads:[~2023-10-15 13:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-15 0:39 bug#66551: [PATCH] Add completion for Unix 'doas' command Antero Mejr via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-15 7:58 ` Stefan Kangas
2023-10-15 11:29 ` Antero Mejr via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-15 12:55 ` Stefan Kangas
2023-10-15 13:41 ` Antero Mejr via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-10-15 14:09 ` Stefan Kangas
2023-10-15 14:35 ` Visuwesh
2023-10-15 16:36 ` Antero Mejr via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-21 10:08 ` Stefan Kangas
2023-10-21 18:47 ` Antero Mejr via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-10-22 22:44 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cnoc89o.fsf@mailbox.org \
--to=bug-gnu-emacs@gnu.org \
--cc=66551@debbugs.gnu.org \
--cc=antero@mailbox.org \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).