From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Alan Third <alan@idiocy.org>
Cc: 67794@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: bug#67794: 30.0.50; mouse-face is not respected on SVG images
Date: Tue, 12 Dec 2023 17:35:18 +0100 [thread overview]
Message-ID: <877cljnzuh.fsf@ledu-giraud.fr> (raw)
In-Reply-To: <ZXhxfIr3sclonrSt@idiocy.org> (Alan Third's message of "Tue, 12 Dec 2023 14:43:08 +0000")
Alan Third <alan@idiocy.org> writes:
[...]
>> This means that when you do a 'C-s foobar' and that the SVG is correctly
>> displayed with the isearch face (foreground and background), such an
>> embedded SVG was created on the fly? If so, I think we should do the
>> same for mouse-face too because this SVG generation is very fast!
>
> I don't see any reason why we shouldn't do that.
>
> lookup_image in image.c is where most of the work is done. It takes a
> face ID number. There are three calls to it from xdisp.c. I don't know
> if it would be best to change the callers to pass in the mouse face
> instead of the local face, or to pass in the mouse face as well as the
> local face and then allow lookup_image to work it out.
>
> This assumes the mouse face details have been worked out before the
> calls to lookup_image, I don't know much about how it works.
Thanks, I think your explanation would greatly help. BTW, mouse-face is
a standard Emacs face so I don't why it seems not to be handled by one
of those calls.
--
Manuel Giraud
next prev parent reply other threads:[~2023-12-12 16:35 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 13:12 bug#67794: 30.0.50; mouse-face is not respected on SVG images Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-12 13:31 ` Eli Zaretskii
2023-12-12 14:07 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-12 14:43 ` Alan Third
2023-12-12 16:35 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-12-12 17:28 ` Eli Zaretskii
2023-12-13 8:18 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-13 12:19 ` Eli Zaretskii
2023-12-13 14:13 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-13 15:08 ` Eli Zaretskii
2023-12-13 16:04 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-13 16:23 ` Eli Zaretskii
2023-12-13 16:50 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-13 17:29 ` Eli Zaretskii
2023-12-13 17:57 ` Gerd Möllmann
2023-12-13 18:11 ` Eli Zaretskii
2023-12-13 18:24 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-13 18:46 ` Eli Zaretskii
2023-12-14 9:07 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-14 9:23 ` Eli Zaretskii
2023-12-14 9:48 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-14 10:05 ` Eli Zaretskii
2023-12-18 11:02 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-18 11:42 ` Alan Third
2023-12-18 18:36 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-18 19:48 ` Alan Third
2023-12-19 12:45 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-19 13:03 ` Eli Zaretskii
2023-12-19 13:23 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-19 13:40 ` Eli Zaretskii
2023-12-19 13:48 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-19 14:25 ` Eli Zaretskii
2023-12-19 14:39 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-19 15:34 ` Eli Zaretskii
2023-12-20 8:47 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-20 13:19 ` Eli Zaretskii
2023-12-20 13:54 ` Alan Third
2023-12-20 13:54 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-20 17:53 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-23 10:22 ` Eli Zaretskii
2023-12-12 14:47 ` Eli Zaretskii
2023-12-12 15:20 ` Alan Third
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877cljnzuh.fsf@ledu-giraud.fr \
--to=bug-gnu-emacs@gnu.org \
--cc=67794@debbugs.gnu.org \
--cc=alan@idiocy.org \
--cc=eliz@gnu.org \
--cc=manuel@ledu-giraud.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).