From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#67661: 30.0.50; *Completions* has started popping up for icomplete-in-buffer Date: Fri, 29 Dec 2023 20:24:26 +0000 Message-ID: <877ckw21vp.fsf@zephyr.silentflame.com> References: <87o7f3e4cb.fsf@melete.silentflame.com> <87lea3wpai.fsf@zephyr.silentflame.com> <8334wby0bq.fsf@gnu.org> <83y1e3wia7.fsf@gnu.org> <87sf4buzpc.fsf@zephyr.silentflame.com> <86edfv9tuz.fsf@mail.linkov.net> <87fs0burie.fsf@zephyr.silentflame.com> <86msuihxwl.fsf@mail.linkov.net> <87r0jtbuq9.fsf@zephyr.silentflame.com> <865y147vbu.fsf@mail.linkov.net> <871qbnodjd.fsf@zephyr.silentflame.com> <86il4ut85p.fsf@mail.linkov.net> <87sf3yxcw2.fsf@zephyr.silentflame.com> <86plz2rp3v.fsf@mail.linkov.net> <87le9pxivy.fsf@zephyr.silentflame.com> <87frzk294o.fsf@zephyr.silentflame.com> <87bka828jm.fsf@zephyr.silentflame.com> <83bka86c8r.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24354"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 67661@debbugs.gnu.org, me@eshelyaron.com To: Eli Zaretskii , juri@linkov.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 29 21:25:28 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rJJQ5-00066c-If for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 29 Dec 2023 21:25:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rJJPl-0006ph-6o; Fri, 29 Dec 2023 15:25:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rJJPi-0006pR-F9 for bug-gnu-emacs@gnu.org; Fri, 29 Dec 2023 15:25:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rJJPi-0001QS-66 for bug-gnu-emacs@gnu.org; Fri, 29 Dec 2023 15:25:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rJJPi-00038L-2I for bug-gnu-emacs@gnu.org; Fri, 29 Dec 2023 15:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Dec 2023 20:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67661 X-GNU-PR-Package: emacs Original-Received: via spool by 67661-submit@debbugs.gnu.org id=B67661.170388147612002 (code B ref 67661); Fri, 29 Dec 2023 20:25:02 +0000 Original-Received: (at 67661) by debbugs.gnu.org; 29 Dec 2023 20:24:36 +0000 Original-Received: from localhost ([127.0.0.1]:42325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJJPH-00037W-G6 for submit@debbugs.gnu.org; Fri, 29 Dec 2023 15:24:35 -0500 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:36853) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rJJPF-00037K-Q5 for 67661@debbugs.gnu.org; Fri, 29 Dec 2023 15:24:34 -0500 Original-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 8F6475C02F7; Fri, 29 Dec 2023 15:24:28 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 29 Dec 2023 15:24:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1703881468; x= 1703967868; bh=SrM/zTDb7HIlCtWDW0W+e8IJknUj6KScA6/NlWnn6co=; b=o NZBeU2He1C4MwH9vRz8Z/IujyQl2W2bIZx3FHHUZWfBIrSq7U5vRtWMuMgtzEqg+ DTuANIM59tWRIv6IJXyHihw+wkdfCYNJJB7YJ8qdBWXu1XLWlQc/K9ippKUrh2vs 57qW4WA7c66zFC7vzz+jPl/s8P0l2V2qZQW+aYNbmFs0dPGUDayRa0i4msSy8oP5 6Bd6YDwpeJZbDGf6b8xYcWswAMwxR/+3Q3IN83BRuf0Wd9364uf8nuEw6JmhUzT5 psB5/8aB0l5Wyqe2d4MwdtxCx7QaWoByhcJDFIQzJwm5Wv/jxYGfK9B/bwZaqvax 6rxkrawIoBtV8YY+/tEwg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1703881468; x=1703967868; bh=SrM/zTDb7HIlCtWDW0W+e8IJknUj 6KScA6/NlWnn6co=; b=Jbls7WdcqwtLl3KFCk8iDdLlYowx0vjFevEcJ2HJcgEL 64N2pQOXPsM/WVfRhNykaqYlXoAsuyC1Qz44vAMY0megAMTxe36Ex+Pcwxm3Vyow y7GSWzIRsYoW+jOOwZcaijrpyBU6rAOsLrxW9efG5c2SHWPqAFF9hBzmmsxRIFbp AzviWgp9j3CG+b15dj1DE20O7bGHiEye7anuvOXzGm7W+ogcUhdzAzMZ4QRMMQTM EkXcuRexFL6zG9XIuNlKJiU7DClMlX9lm3yXhf/B7ZpVOGlKI6aL/w69S3E5DVLJ H3VqnyJNdIMZjd37vuizQVOVaojLzRKZhHrIU/dutg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdeffedgudefjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggr nhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg eqnecuggftrfgrthhtvghrnheptdffvdffueeluedvteekvdevhefghedvgeevgffhvedu keeggeelveegjeekteeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 29 Dec 2023 15:24:27 -0500 (EST) Original-Received: by zephyr.silentflame.com (Postfix, from userid 1000) id 20937941829; Fri, 29 Dec 2023 20:24:26 +0000 (GMT) In-Reply-To: <83bka86c8r.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 29 Dec 2023 21:27:00 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277039 Archived-At: Hello, On Fri 29 Dec 2023 at 09:27pm +02, Eli Zaretskii wrote: > To which entry in Emacs 29's NEWS would this be related? I'm talking about how Juri fixed icomplete-in-buffer for Emacs 29, and how it's now working differently. Juri's fix wasn't noted in NEWS.29, so there isn't a relevant entry. Let me lay out where I think things stand now that the confounding Pcomplete bug is fixed. Here are four reproductions: ,---- | | 1. emacs -q | 2. (setopt icomplete-in-buffer t | completion-auto-help 'lazy) | 3. M-x icomplete-mode | | | 4a. M-x eshell | 5a. cd ~/src/emacs/ | 6a. lsl | - Emacs 29: in-buffer Icomplete appears | - Emacs 30: nothing happens | 7a. a second time | - Emacs 29: *Completions* pops up | - Emacs 30: in-buffer Icomplete appears & *Completions* pops up | | | 4b. Insert text into *scratch*: (setopt icomplete- | 5b. C-M-i | - Emacs 29: in-buffer Icomplete appears | - Emacs 30: nothing happens | 6b. C-M-i a second time | - Emacs 29: accepts the completion | - Emacs 30: in-buffer Icomplete appears & *Completion* pops up | |---- | | 1. emacs -q | 2. (setopt icomplete-in-buffer t) | 3. M-x icomplete-mode | | | 4a. M-x eshell | 5a. cd ~/src/emacs/ | 6a. lsl | - Emacs 29: in-buffer Icomplete appears | - Emacs 30: in-buffer Icomplete appears & *Completions* pops up | 7a. a second time | - Emacs 29: *Completions* pops up | - Emacs 30: n/a | | | 4b. Insert text into *scratch*: (setopt icomplete- | 5b. C-M-i | - Emacsen 29 & 30: in-buffer Icomplete appears & *Completions* pops up. |---- We could see this as two incompatible changes to icomplete-in-buffer since Emacs 29: A. completion-auto-help now controls whether C-M-i or must be typed twice to display in-buffer Icomplete. Previously, completion-auto-help affected only minibuffer completion. I must have been thinking of it this way when I set it to `lazy'. B. *Completions* now always appears at the same time as the in-buffer Icomplete. Previously, in some cases, it would appear only after typing C-M-i or twice. An Icomplete user like me is likely to want to respond to both these changes. The worst case is how nothing happens after a single in the first reproduction, such that typing two s is always required. Thus, I propose adding a NEWS.30 entry like this: There have been some changes which normalise some behaviour of in-buffer completion that affect users of icomplete-in-buffer. Firstly, completion-auto-help now governs icomplete-in-buffer, whereas previously it affected only minibuffer completion. You may wish to review any existing customisation for completion-auto-help if in-buffer completion behaves in a way that surprises you. Secondly, the *Completions* buffer now always pops up at the same time that Icomplete displays its in-buffer completion. If you would prefer to see only Icomplete's display, which is what you might be used to, you could use (advice-add 'completion-at-point :after #'minibuffer-hide-completions) The reason I haven't gone ahead and added this already is that Juri has suggested further changing icomplete-in-buffer's default behaviour. I don't think that we should do that. -- Sean Whitton