unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Emanuel Berg <incal@dataswamp.org>
To: 68395@debbugs.gnu.org
Subject: bug#68395: 30.0.50; ERC 5.6-git: erc-cmd-GMSG, erc-cmd-AMSG, erc-cmd-GME, erc-cmd-AME
Date: Fri, 12 Jan 2024 06:52:42 +0100	[thread overview]
Message-ID: <877ckfw11x.fsf@dataswamp.org> (raw)
In-Reply-To: <87h6jjw58t.fsf@dataswamp.org>

J.P. wrote:

>> Patch
>
> I think debbugs wants the full "Tags: patch".

It is there, what you cite is just what I wrote in the message
instead of a bug report.

> At some point, you'll need to include a commit message.

I added a message, if not 'git commit' wouldn't have worked.

>> ---
>>  lisp/erc/erc.el | 156 ++++++++++++++++++++++++++++--------------------
>>  1 file changed, 90 insertions(+), 66 deletions(-)
>>
>> diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
>> index 478683a77f5..12078f6970d 100644
>> --- a/lisp/erc/erc.el
>> +++ b/lisp/erc/erc.el
>> @@ -2003,10 +2003,10 @@ erc-get-buffer
>>  (defun erc--buffer-p (buf predicate proc)
>>    (with-current-buffer buf
>>      (and (derived-mode-p 'erc-mode)
>> -	 (or (not proc)
>> -	     (eq proc erc-server-process))
>> -	 (funcall predicate)
>> -	 buf)))
>> +         (or (not proc)
>> +             (eq proc erc-server-process))
>> +         (funcall predicate)
>> +         buf)))
>
> I haven't looked at the proposed commands yet, but can you
> remove all these hopefully inadvertent white space changes
> in the meantime, please?

Ah, you are using tabs in the source, saving the buffer
changed them to whitespace. This is what happens if you use
tabs! But you are right it wasn't intended for the patch.

-- 
underground experts united
https://dataswamp.org/~incal






  reply	other threads:[~2024-01-12  5:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-12  4:22 bug#68395: 30.0.50; ERC 5.6-git: erc-cmd-GMSG, erc-cmd-AMSG, erc-cmd-GME, erc-cmd-AME Emanuel Berg
2024-01-12  5:34 ` J.P.
2024-01-12  5:52   ` Emanuel Berg [this message]
2024-01-12 10:49     ` Emanuel Berg
2024-01-19  2:53     ` J.P.
     [not found]     ` <87v87qowym.fsf@neverwas.me>
2024-01-22  8:23       ` Emanuel Berg
2024-01-12  6:53   ` Emanuel Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877ckfw11x.fsf@dataswamp.org \
    --to=incal@dataswamp.org \
    --cc=68395@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).