unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: pranshusharma366@gmail.com, 68947@debbugs.gnu.org
Subject: bug#68947: 30.0.50; Gnus article mode keybindings
Date: Sat, 17 Feb 2024 10:13:02 -0800	[thread overview]
Message-ID: <877cj3q7rl.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <87mss8xi0m.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sat, 10 Feb 2024 10:59:21 -0800")

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> On 02/10/24 20:15 PM, Eli Zaretskii wrote:
>>> Cc: 68947@debbugs.gnu.org
>>> From: Eric Abrahamsen <eric@ericabrahamsen.net>
>>> Date: Sat, 10 Feb 2024 10:09:14 -0800
>>> 
>>> Your immediate issue is caused by the fact that
>>> `gnus-article-describe-bindings', which theoretically should be
>>> responsible for telling the user about all the redirections, is only
>>> aware of the "S" keymap prefix. It doesn't know all the ways in which an
>>> 'undefined binding might get translated into a valid summary-mode
>>> command, and can't show you those.
>>> 
>>> To be honest, I don't think I'm going to be able to fix this. If we keep
>>> the current implementation, `gnus-article-describe-bindings' would have
>>> to be made aware of the additional redirections, and I wouldn't even
>>> know where to start.
>>> 
>>> It could be that Elisp has better tools for this situation by now (the
>>> original architecture was in place before 1997), but I'm not sure what
>>> those tools are. Perhaps someone will chime in with a helpful
>>> suggestion...
>>
>> Strange as it may sound, I see no grave problem here: C-h is not
>> guaranteed to work after any arbitrary prefix, anyway.  So if that is
>> too hard to fix, we could just punt and leave it unsolved.
>
> I'm inclined to say it's too hard to fix! The only cleaner solution I
> can think of is to actually define article-mode versions of all the
> summary-mode commands we'd want to call, which would also provide a
> place to do the necessary article-specific adjustments. That's a lot of
> very tightly-coupled code, though.
>
>> What about "C-h b" -- does that work in the situation described by the
>> recipe?
>
> No, that doesn't really work. The gnus-article-mode bindings are listed
> under a "fundamental-mode Major Mode Bindings:" heading (??). That
> includes gnus-article-mode's own keybindings, and the summary-mode
> bindings that have been explicitly attached at the "S" prefix, but
> nothing else.

I don't know, I don't see a good solution to this without a massive
rewrite, which I don't have the stomach for right now. Should we leave
the bug open, since it's a real problem?





  reply	other threads:[~2024-02-17 18:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-06  8:29 bug#68947: 30.0.50; Gnus article mode keybindings Pranshu
2024-02-06 15:09 ` Eric Abrahamsen
     [not found]   ` <87r0hofow9.fsf@gmail.com>
2024-02-10 18:09     ` Eric Abrahamsen
2024-02-10 18:15       ` Eli Zaretskii
2024-02-10 18:59         ` Eric Abrahamsen
2024-02-17 18:13           ` Eric Abrahamsen [this message]
2024-02-17 18:14             ` Eli Zaretskii
2024-02-06 15:42 ` Andreas Schwab
2024-02-06 20:33   ` Eric Abrahamsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877cj3q7rl.fsf@ericabrahamsen.net \
    --to=eric@ericabrahamsen.net \
    --cc=68947@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=pranshusharma366@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).