From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#68559: [PATCH] Improve Python shell completion Date: Thu, 14 Mar 2024 15:24:04 +0100 Message-ID: <877ci4ao3f.fsf@epfl.ch> References: <6BAFD8BF-8F18-4D9F-9DB3-A185AEF2EBCA@gmail.com> <8B4172D0-FC31-4437-99C4-683C892C5F86@gmail.com> <3A206D3C-E193-4240-A6DB-D3EC7DAAE7C2@gmail.com> <16E39FDF-5F8E-4C1B-8BCD-A0147B97F2B8@gmail.com> <7150E568-B07D-4D92-8073-979387553394@gmail.com> <87bk80ve20.fsf@epfl.ch> <87y1asybi4.fsf@epfl.ch> <87zfv4lpsn.fsf@epfl.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20981"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: kobarity , Eli Zaretskii , Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , 68559@debbugs.gnu.org To: Liu Hui Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 14 15:24:51 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rkm0p-0005EC-Rf for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Mar 2024 15:24:51 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rkm0S-0006dz-Gs; Thu, 14 Mar 2024 10:24:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rkm0Q-0006dJ-TC for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2024 10:24:26 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rkm0Q-0000OF-9a for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2024 10:24:26 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rkm0z-0004aW-VN for bug-gnu-emacs@gnu.org; Thu, 14 Mar 2024 10:25:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Mar 2024 14:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68559 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 68559-submit@debbugs.gnu.org id=B68559.171042629017614 (code B ref 68559); Thu, 14 Mar 2024 14:25:01 +0000 Original-Received: (at 68559) by debbugs.gnu.org; 14 Mar 2024 14:24:50 +0000 Original-Received: from localhost ([127.0.0.1]:50416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rkm0n-0004a1-UN for submit@debbugs.gnu.org; Thu, 14 Mar 2024 10:24:50 -0400 Original-Received: from mail-ed1-f46.google.com ([209.85.208.46]:38945) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rkm0k-0004Zo-RK for 68559@debbugs.gnu.org; Thu, 14 Mar 2024 10:24:48 -0400 Original-Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5586764bd0aso328510a12.0 for <68559@debbugs.gnu.org>; Thu, 14 Mar 2024 07:24:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710426245; x=1711031045; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XUbl2f2waGhxPh7ofHuMPc7zETa+jsx4VCi+vf4EY2g=; b=GnvEjyUI0ZgszHlv57LUbZ70POhIGrMDcre3Nkg/0kpUGEbfwiP9Kb7eRTmWWLylC/ 2Gar0Ohzj6Qzpcc1Oeh0ovTCHEEthYUFmW8ZFH7vSLVRGARuRLM21+I83k247o3cB2HV li3vyI/wSTXcCO0ouOC1KMqSd+TLH5tVV2+YabgqX/VTP9tqh6K0tGMOWtc1dKhlji9u S536wh16tgxOS+t75gnwyKFlmpdlSU+kIRqpG/QRBYnZrrYgo5f7B7Pd4ZLJa3rdy3gf z8WhQXPLLLwPINFOVdz3C8nLdpf3z/TIrfdT5IFA0zYJ+BcvzL0+c2IOCKl5sYt6vkG3 Fg5g== X-Forwarded-Encrypted: i=1; AJvYcCULIPnc9dvvEaefeiXqG0fQVWvLwNCfZowe2n8FQ/jKLSd06Wq6Sa5nSqrt7lo/8aK3wwfGMhj3yzCiF4kDmmNxC6+AM2s= X-Gm-Message-State: AOJu0YwAh6kXjTwAzkvIxDtFVQsp+4/v6yRp9FuUrC6lHuxAK21WJjr7 sQmxHSk80nzLOXh0hUyjXukcAILm2WuoCFfEeU/yJG7dyRNkQmm5 X-Google-Smtp-Source: AGHT+IE/NSF87+DXGGJfeZJFU8TMEn+cqpv0bDIEUl7SobUOVS/LIe5uDKiJ/sDLa4k8P3xlgzd3Pw== X-Received: by 2002:a05:6402:321c:b0:568:7491:908d with SMTP id g28-20020a056402321c00b005687491908dmr1331866eda.0.1710426245075; Thu, 14 Mar 2024 07:24:05 -0700 (PDT) Original-Received: from localhost ([2001:620:618:5c0:2:80b3:0:95c]) by smtp.gmail.com with ESMTPSA id el9-20020a056402360900b005684173e413sm757327edb.72.2024.03.14.07.24.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Mar 2024 07:24:04 -0700 (PDT) In-Reply-To: (Liu Hui's message of "Wed, 13 Mar 2024 18:21:00 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281618 Archived-At: Liu Hui [2024-03-13 18:21 +0800] wrote: > On Tue, Mar 12, 2024 at 12:02=E2=80=AFAM Basil L. Contovounesios > wrote: >> >> Thanks! But that makes me wonder: in the cases where we check >> >> (string=3D python-shell-readline-completer-delims "") >> >> is there a possibility that the variable's value will be nil? >> (In which case we should compare with equal instead of string=3D.) > > Yes, it is a string with native completion and may be nil with > non-native completion. Sorry, I completely forgot that string=3D works on symbols too. I was worried that (string=3D nil "") would signal an error, but it actually does what we want. > I have updated the patch. Thanks, pushed: Detect the readline support for Python shell completion a7057745f5e 2024-03-14 15:09:56 +0100 https://git.sv.gnu.org/cgit/emacs.git/commit/?id=3Da7057745f5e Is there more left to do as part of this bug report? --=20 Basil